Re: [PATCH 1/4] i2c: nvidia-gpu: add runtime pm support

2019-05-20 Thread Wolfram Sang
> > I am not nacking this, yet the use of goto here seems too much for my > > taste. If > > you could try refactoring the whole code (dunno, maybe using a flag when to > > use stop?), I'd appreciate this. > Ok, I will add a local variable to make it more readable. I was brainstorming here, I am

RE: [PATCH 1/4] i2c: nvidia-gpu: add runtime pm support

2019-05-20 Thread Ajay Gupta
Hi Wolfram, > -Original Message- > From: Wolfram Sang > Sent: Sunday, May 19, 2019 7:47 AM > To: Ajay Gupta > Cc: heikki.kroge...@linux.intel.com; linux-usb@vger.kernel.org; linux- > i...@vger.kernel.org; Ajay Gupta > Subject: Re: [PATCH 1/4] i2c: nvidia-gpu: a

Re: [PATCH 1/4] i2c: nvidia-gpu: add runtime pm support

2019-05-19 Thread Wolfram Sang
> diff --git a/drivers/i2c/busses/i2c-nvidia-gpu.c > b/drivers/i2c/busses/i2c-nvidia-gpu.c > index 1c8f708f212b..9d347583f8dc 100644 > --- a/drivers/i2c/busses/i2c-nvidia-gpu.c > +++ b/drivers/i2c/busses/i2c-nvidia-gpu.c > @@ -175,6 +175,7 @@ static int gpu_i2c_master_xfer(struct i2c_adapter *adap