Re: [PATCH 03/10] staging: dwc2: move some interrupt enabling around

Hi Paul, > If RXFLVL is a host+device mode interrupt, doesn't it make sense to > enable it in both enable_host_interrupts and (the future) > enable_device_interrupts instead of in enable_common_interrupts? Hmm, I just realized the underlying thing here is that I'm distinguishing "common" interrupt

Re: [PATCH 03/10] staging: dwc2: move some interrupt enabling around

Hi Paul, > > Before, the DISCONNINT interrupt was enabled in > > dwc2_enable_host_interrupts, but handled in dwc2_handle_common_intr, > > while the RXFLVL interrupt was enabled in dwc2_enable_commont_interrupts > > and handled in dwc_handle_hcd_intr. > > And, the RXFLVL interrupt is a host+device

Re: [PATCH 03/10] staging: dwc2: move some interrupt enabling around

Hi Paul, > > Before, the DISCONNINT interrupt was enabled in > > dwc2_enable_host_interrupts, but handled in dwc2_handle_common_intr, > > while the RXFLVL interrupt was enabled in dwc2_enable_commont_interrupts > > and handled in dwc_handle_hcd_intr. > > I guess you meant dwc2_hcd_intr, not dwc_h

RE: [PATCH 03/10] staging: dwc2: move some interrupt enabling around

Hi Matthijs, > -Original Message- > From: Matthijs Kooijman [mailto:matth...@stdin.nl] > > Before, the DISCONNINT interrupt was enabled in > dwc2_enable_host_interrupts, but handled in dwc2_handle_common_intr, > while the RXFLVL interrupt was enabled in dwc2_enable_commont_interrupts > an