Re: [PATCH] usbip: fix warning in vhci_hcd_probe/lockdep_init_map

2016-12-08 Thread Shuah Khan
On 12/08/2016 05:08 PM, fx IWATA NOBUO wrote: > Dear Shuah, > > Sorry for taking time. > > It's caused by my patch. > It was included "vhci number of ports extension" patch set. > The set consists of 3 patches. > > The fixing was included in v5. > Only 1/3 of the set was merged but I missed to c

RE: [PATCH] usbip: fix warning in vhci_hcd_probe/lockdep_init_map

2016-12-08 Thread fx IWATA NOBUO
v > Cc: Greg Kroah-Hartman; Valentina Manea; Shuah Khan; > linux-usb@vger.kernel.org; LKML; Shuah Khan > Subject: Re: [PATCH] usbip: fix warning in vhci_hcd_probe/lockdep_init_map > > On 12/07/2016 09:12 PM, fx IWATA NOBUO wrote: > > Dear Shuah, > > > >> I notic

Re: [PATCH] usbip: fix warning in vhci_hcd_probe/lockdep_init_map

2016-12-08 Thread Shuah Khan
On 12/07/2016 09:12 PM, fx IWATA NOBUO wrote: > Dear Shuah, > >> I noticed that in many places sysfs_attr_init() is called before populating >> the fields such as name etc. However, I don't think the order matters. >> >> sysfs_attr_init() doesn't depend on name or any other fields being set: >> >>

RE: [PATCH] usbip: fix warning in vhci_hcd_probe/lockdep_init_map

2016-12-07 Thread fx IWATA NOBUO
est Regards, > > > > nobuo.iwata > > // > >> -Original Message- > >> From: linux-usb-ow...@vger.kernel.org > >> [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Andrey > >> Konovalov > >> Sent: Tuesday, December 06, 2016 9:07 PM

Re: [PATCH] usbip: fix warning in vhci_hcd_probe/lockdep_init_map

2016-12-07 Thread Shuah Khan
> nobuo.iwata > // >> -Original Message- >> From: linux-usb-ow...@vger.kernel.org >> [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Andrey Konovalov >> Sent: Tuesday, December 06, 2016 9:07 PM >> To: Shuah Khan >> Cc: Greg Kroah-Hartman; Va

RE: [PATCH] usbip: fix warning in vhci_hcd_probe/lockdep_init_map

2016-12-07 Thread fx IWATA NOBUO
-usb-ow...@vger.kernel.org] On Behalf Of Andrey Konovalov > Sent: Tuesday, December 06, 2016 9:07 PM > To: Shuah Khan > Cc: Greg Kroah-Hartman; Valentina Manea; Shuah Khan; > linux-usb@vger.kernel.org; LKML > Subject: Re: [PATCH] usbip: fix warning in vhci_hcd_probe/lockdep_init_m

Re: [PATCH] usbip: fix warning in vhci_hcd_probe/lockdep_init_map

2016-12-06 Thread Andrey Konovalov
On Mon, Dec 5, 2016 at 9:00 PM, Shuah Khan wrote: > Hi Andrey, > > On 12/05/2016 12:56 PM, Shuah Khan wrote: >> vhci_hcd calls sysfs_create_group() with dynamically allocated sysfs >> attributes triggering the lock-class key not persistent warning. Call >> sysfs_attr_init() for dynamically allocat

Re: [PATCH] usbip: fix warning in vhci_hcd_probe/lockdep_init_map

2016-12-05 Thread Shuah Khan
Hi Andrey, On 12/05/2016 12:56 PM, Shuah Khan wrote: > vhci_hcd calls sysfs_create_group() with dynamically allocated sysfs > attributes triggering the lock-class key not persistent warning. Call > sysfs_attr_init() for dynamically allocated sysfs attributes to fix it. > > vhci_hcd vhci_hcd: USB/