Re: [PATCH] usb: hcd: get/put device and hcd for hcd_buffers()

2014-12-10 Thread Sebastian Andrzej Siewior
* 'Greg Kroah-Hartman' | 2014-12-09 11:54:15 [-0500]: >> You can unbind the HCD driver from the PCI-device via sysfs and this is >> not something not only a developer does. This "unbind" calls the remove >> function of the driver and the only difference between unbind and rmmod >> is that the modu

Re: [PATCH] usb: hcd: get/put device and hcd for hcd_buffers()

2014-12-09 Thread 'Greg Kroah-Hartman'
On Tue, Dec 09, 2014 at 05:01:35PM +0100, Sebastian Andrzej Siewior wrote: > On 12/09/2014 04:24 PM, 'Greg Kroah-Hartman' wrote: > > On Mon, Dec 08, 2014 at 09:44:05AM +, David Laight wrote: > >> From: Greg Kroah-Hartman > >>> On Fri, Dec 05, 2014 at 09:03:57PM +0100, Sebastian Andrzej Siewior

Re: [PATCH] usb: hcd: get/put device and hcd for hcd_buffers()

2014-12-09 Thread Sebastian Andrzej Siewior
On 12/09/2014 04:24 PM, 'Greg Kroah-Hartman' wrote: > On Mon, Dec 08, 2014 at 09:44:05AM +, David Laight wrote: >> From: Greg Kroah-Hartman >>> On Fri, Dec 05, 2014 at 09:03:57PM +0100, Sebastian Andrzej Siewior wrote: Consider the following scenario: - plugin a webcam - play the

Re: [PATCH] usb: hcd: get/put device and hcd for hcd_buffers()

2014-12-09 Thread 'Greg Kroah-Hartman'
On Mon, Dec 08, 2014 at 09:44:05AM +, David Laight wrote: > From: Greg Kroah-Hartman > > On Fri, Dec 05, 2014 at 09:03:57PM +0100, Sebastian Andrzej Siewior wrote: > > > Consider the following scenario: > > > - plugin a webcam > > > - play the stream via gst-launch-0.10 v4l2src device=/dev/vide

RE: [PATCH] usb: hcd: get/put device and hcd for hcd_buffers()

2014-12-08 Thread David Laight
From: Greg Kroah-Hartman > On Fri, Dec 05, 2014 at 09:03:57PM +0100, Sebastian Andrzej Siewior wrote: > > Consider the following scenario: > > - plugin a webcam > > - play the stream via gst-launch-0.10 v4l2src device=/dev/video0 > > - remove the USB-HCD during playback via "rmmod $HCD" > > > > and

Re: [PATCH] usb: hcd: get/put device and hcd for hcd_buffers()

2014-12-08 Thread Sebastian Andrzej Siewior
* Sebastian Andrzej Siewior | 2014-12-06 00:23:27 [+0100]: >I had one patch doing that. Let me grab it out on Monday. okay, this is it. Laurent, any idea why this could not fly? I haven't seen anything odd so far. diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_drive

Re: [PATCH] usb: hcd: get/put device and hcd for hcd_buffers()

2014-12-05 Thread Greg Kroah-Hartman
On Sat, Dec 06, 2014 at 12:13:13AM +0100, Sebastian Andrzej Siewior wrote: > * Greg Kroah-Hartman | 2014-12-05 13:19:32 [-0800]: > > >On Fri, Dec 05, 2014 at 09:03:57PM +0100, Sebastian Andrzej Siewior wrote: > >> Consider the following scenario: > >> - plugin a webcam > >> - play the stream via g

Re: [PATCH] usb: hcd: get/put device and hcd for hcd_buffers()

2014-12-05 Thread Sebastian Andrzej Siewior
* Alan Stern | 2014-12-05 16:21:02 [-0500]: >On Fri, 5 Dec 2014, Sebastian Andrzej Siewior wrote: >> So instead, I hold the device struct in the HCD and the HCD struct on >> every USB-buf-alloc. That means after a disconnect we still have a >> refcount on usb_hcd and device and it will be cleaned

Re: [PATCH] usb: hcd: get/put device and hcd for hcd_buffers()

2014-12-05 Thread Sebastian Andrzej Siewior
* Greg Kroah-Hartman | 2014-12-05 13:19:32 [-0800]: >On Fri, Dec 05, 2014 at 09:03:57PM +0100, Sebastian Andrzej Siewior wrote: >> Consider the following scenario: >> - plugin a webcam >> - play the stream via gst-launch-0.10 v4l2src device=/dev/video0… >> - remove the USB-HCD during playback via

Re: [PATCH] usb: hcd: get/put device and hcd for hcd_buffers()

2014-12-05 Thread Alan Stern
On Fri, 5 Dec 2014, Sebastian Andrzej Siewior wrote: > Consider the following scenario: > - plugin a webcam > - play the stream via gst-launch-0.10 v4l2src device=/dev/video0… > - remove the USB-HCD during playback via "rmmod $HCD" > > and now wait for the crash > > |musb-hdrc musb-hdrc.2.auto:

Re: [PATCH] usb: hcd: get/put device and hcd for hcd_buffers()

2014-12-05 Thread Greg Kroah-Hartman
On Fri, Dec 05, 2014 at 09:03:57PM +0100, Sebastian Andrzej Siewior wrote: > Consider the following scenario: > - plugin a webcam > - play the stream via gst-launch-0.10 v4l2src device=/dev/video0… > - remove the USB-HCD during playback via "rmmod $HCD" > > and now wait for the crash Which you de