Re: [PATCH] usb/musb: debugfs, fix copy_from_user argument

2015-01-14 Thread 'Markus Pargmann'
Hi, On Wed, Jan 14, 2015 at 11:08:12AM -0600, Felipe Balbi wrote: > On Wed, Jan 14, 2015 at 05:12:55PM +0100, 'Markus Pargmann' wrote: > > Hi, > > > > On Wed, Jan 14, 2015 at 03:19:42PM +, David Laight wrote: > > > From: Markus Pargmann > > > > The first arugment has to be a pointer to the me

Re: [PATCH] usb/musb: debugfs, fix copy_from_user argument

2015-01-14 Thread Felipe Balbi
On Wed, Jan 14, 2015 at 05:12:55PM +0100, 'Markus Pargmann' wrote: > Hi, > > On Wed, Jan 14, 2015 at 03:19:42PM +, David Laight wrote: > > From: Markus Pargmann > > > The first arugment has to be a pointer to the memory. buf is a char > > > array and already a pointer itself. The current code

Re: [PATCH] usb/musb: debugfs, fix copy_from_user argument

2015-01-14 Thread 'Markus Pargmann'
Hi, On Wed, Jan 14, 2015 at 03:19:42PM +, David Laight wrote: > From: Markus Pargmann > > The first arugment has to be a pointer to the memory. buf is a char > > array and already a pointer itself. The current code passes a pointer to > > a char array to copy_from_user() which is not correct.

RE: [PATCH] usb/musb: debugfs, fix copy_from_user argument

2015-01-14 Thread David Laight
From: Markus Pargmann > The first arugment has to be a pointer to the memory. buf is a char > array and already a pointer itself. The current code passes a pointer to > a char array to copy_from_user() which is not correct. It doesn't matter, while the type of the argument is subtly different the