Re: Possible memory leak in acm_probe not freeing (acm->country_codes) on error path

2014-11-20 Thread Alan Stern
On Thu, 20 Nov 2014, Oliver Neukum wrote: > On Thu, 2014-11-20 at 15:36 +0100, Bjørn Mork wrote: > > Oliver Neukum writes: > > > On Thu, 2014-11-20 at 15:09 +0100, Bjørn Mork wrote: > > >> Oliver Neukum writes: > > >> > On Thu, 2014-11-20 at 14:27 +0100, Johan Hovold wrote: > > >> > > > >> >> It

Re: Possible memory leak in acm_probe not freeing (acm->country_codes) on error path

2014-11-20 Thread Oliver Neukum
On Thu, 2014-11-20 at 15:36 +0100, Bjørn Mork wrote: > Oliver Neukum writes: > > On Thu, 2014-11-20 at 15:09 +0100, Bjørn Mork wrote: > >> Oliver Neukum writes: > >> > On Thu, 2014-11-20 at 14:27 +0100, Johan Hovold wrote: > >> > > >> >> It looks like it's never freed in the alloc_fail8 error pat

Re: Possible memory leak in acm_probe not freeing (acm->country_codes) on error path

2014-11-20 Thread Bjørn Mork
Oliver Neukum writes: > On Thu, 2014-11-20 at 15:09 +0100, Bjørn Mork wrote: >> Oliver Neukum writes: >> > On Thu, 2014-11-20 at 14:27 +0100, Johan Hovold wrote: >> > >> >> It looks like it's never freed in the alloc_fail8 error path of probe, >> >> though. >> > >> > Indeed. A case of the coder b

Re: Possible memory leak in acm_probe not freeing (acm->country_codes) on error path

2014-11-20 Thread Oliver Neukum
On Thu, 2014-11-20 at 15:09 +0100, Bjørn Mork wrote: > Oliver Neukum writes: > > On Thu, 2014-11-20 at 14:27 +0100, Johan Hovold wrote: > > > >> It looks like it's never freed in the alloc_fail8 error path of probe, > >> though. > > > > Indeed. A case of the coder being blind to his own code. > >

Re: Possible memory leak in acm_probe not freeing (acm->country_codes) on error path

2014-11-20 Thread Bjørn Mork
Oliver Neukum writes: > On Thu, 2014-11-20 at 14:27 +0100, Johan Hovold wrote: > >> It looks like it's never freed in the alloc_fail8 error path of probe, >> though. > > Indeed. A case of the coder being blind to his own code. > Patch is forthcoming. Why does the driver have to allocate anything

Re: Possible memory leak in acm_probe not freeing (acm->country_codes) on error path

2014-11-20 Thread Oliver Neukum
On Thu, 2014-11-20 at 14:27 +0100, Johan Hovold wrote: > It looks like it's never freed in the alloc_fail8 error path of probe, > though. Indeed. A case of the coder being blind to his own code. Patch is forthcoming. Thanks Oliver -- To unsubscribe from this list: send

Re: Possible memory leak in acm_probe not freeing (acm->country_codes) on error path

2014-11-20 Thread Johan Hovold
On Thu, Nov 20, 2014 at 01:45:05PM +0100, Oliver Neukum wrote: > On Wed, 2014-11-19 at 19:22 -0600, Ahmed Tamrawi wrote: > > Bug Report Filed: https://bugzilla.kernel.org/show_bug.cgi?id=88521 > > Linux Version [3.17-rc1] > > Configuration: Default configuration for x86 > > > > Function Source: >

Re: Possible memory leak in acm_probe not freeing (acm->country_codes) on error path

2014-11-20 Thread Oliver Neukum
On Wed, 2014-11-19 at 19:22 -0600, Ahmed Tamrawi wrote: > Bug Report Filed: https://bugzilla.kernel.org/show_bug.cgi?id=88521 > Linux Version [3.17-rc1] > Configuration: Default configuration for x86 > > Function Source: > http://lxr.free-electrons.com/source/drivers/usb/class/cdc-acm.c#L1404 > >

Re: Possible memory leak in acm_probe not freeing (acm->country_codes) on error path

2014-11-19 Thread Greg KH
On Wed, Nov 19, 2014 at 07:22:06PM -0600, Ahmed Tamrawi wrote: > Bug Report Filed: https://bugzilla.kernel.org/show_bug.cgi?id=88521 > Linux Version [3.17-rc1] > Configuration: Default configuration for x86 > > Function Source: > http://lxr.free-electrons.com/source/drivers/usb/class/cdc-acm.c#L14

Possible memory leak in acm_probe not freeing (acm->country_codes) on error path

2014-11-19 Thread Ahmed Tamrawi
Bug Report Filed: https://bugzilla.kernel.org/show_bug.cgi?id=88521 Linux Version [3.17-rc1] Configuration: Default configuration for x86 Function Source: http://lxr.free-electrons.com/source/drivers/usb/class/cdc-acm.c#L1404 In function (acm_probe) in file (drivers/usb/class/cdc-acm.c): Pointer