Re: MUSB interrupt storm on device removal

2019-03-07 Thread Bin Liu
Hi, On Tue, Mar 05, 2019 at 11:30:28AM +, Måns Rullgård wrote: [...] > > Thanks for the info. > > I will handle this case in musb driver. > > What's happening to this? There's no immediate urgency from my side, > but I don't want it to get forgotten either. no, it is not forgotten. it is

Re: MUSB interrupt storm on device removal

2019-03-05 Thread Måns Rullgård
Bin Liu writes: > On Wed, Jan 23, 2019 at 03:55:47PM +0100, Johan Hovold wrote: >> On Wed, Jan 23, 2019 at 08:09:47AM -0600, Bin Liu wrote: >> > On Wed, Jan 23, 2019 at 09:55:49AM +0100, Johan Hovold wrote: >> > > On Wed, Jan 23, 2019 at 07:52:12AM +0100, Greg Kroah-Hartman wrote: >> >> > > > Th

Re: MUSB interrupt storm on device removal

2019-01-25 Thread Bin Liu
On Thu, Jan 24, 2019 at 04:31:19PM +, Måns Rullgård wrote: > Bin Liu writes: > > > On Thu, Jan 24, 2019 at 12:56:33PM +, Måns Rullgård wrote: > >> Johan Hovold writes: > >> > >> > On Wed, Jan 23, 2019 at 08:50:38PM +, Måns Rullgård wrote: > >> >> Bin Liu writes: > >> >> > >> >> >>

Re: MUSB interrupt storm on device removal

2019-01-24 Thread Måns Rullgård
Bin Liu writes: > On Thu, Jan 24, 2019 at 12:56:33PM +, Måns Rullgård wrote: >> Johan Hovold writes: >> >> > On Wed, Jan 23, 2019 at 08:50:38PM +, Måns Rullgård wrote: >> >> Bin Liu writes: >> >> >> >> >> > > Why doesn't the same problem occur with other types of host >> >> >> > > co

Re: MUSB interrupt storm on device removal

2019-01-24 Thread Bin Liu
On Thu, Jan 24, 2019 at 10:49:30AM -0500, Alan Stern wrote: > On Thu, 24 Jan 2019, Bin Liu wrote: > > > > Perhaps it has something to do with the timing of the completion > > > interrupts. I don't know anything about how musb works, though. Some > > > low-level timing information would be good

Re: MUSB interrupt storm on device removal

2019-01-24 Thread Alan Stern
On Thu, 24 Jan 2019, Bin Liu wrote: > > Perhaps it has something to do with the timing of the completion > > interrupts. I don't know anything about how musb works, though. Some > > low-level timing information would be good to see. > > The musb controller driver itself doesn't have a isr BH,

Re: MUSB interrupt storm on device removal

2019-01-24 Thread Bin Liu
On Thu, Jan 24, 2019 at 10:22:26AM -0500, Alan Stern wrote: > On Thu, 24 Jan 2019, Johan Hovold wrote: > > > > At least when -EPROTO errors are caused by device disconnect, we know > > > that they will eventually go away when the upstream hub reports the > > > port disconnect event. But until t

Re: MUSB interrupt storm on device removal

2019-01-24 Thread Bin Liu
On Thu, Jan 24, 2019 at 12:56:33PM +, Måns Rullgård wrote: > Johan Hovold writes: > > > On Wed, Jan 23, 2019 at 08:50:38PM +, Måns Rullgård wrote: > >> Bin Liu writes: > >> > >> >> > > Why doesn't the same problem occur with other types of host > >> >> > > controller? > >> >> > > >> >

Re: MUSB interrupt storm on device removal

2019-01-24 Thread Alan Stern
On Thu, 24 Jan 2019, Johan Hovold wrote: > > At least when -EPROTO errors are caused by device disconnect, we know > > that they will eventually go away when the upstream hub reports the > > port disconnect event. But until then, an interrupt storm is certainly > > possible. > > Indeed, and t

Re: MUSB interrupt storm on device removal

2019-01-24 Thread Måns Rullgård
Johan Hovold writes: > On Wed, Jan 23, 2019 at 08:50:38PM +, Måns Rullgård wrote: >> Bin Liu writes: >> >> >> > > Why doesn't the same problem occur with other types of host >> >> > > controller? >> >> > >> >> > Not sure, I am on musb for most of the times. Maybe other HCD doesn't >> >> >

Re: MUSB interrupt storm on device removal

2019-01-24 Thread Johan Hovold
On Wed, Jan 23, 2019 at 08:50:38PM +, Måns Rullgård wrote: > Bin Liu writes: > > >> > > Why doesn't the same problem occur with other types of host controller? > >> > > >> > Not sure, I am on musb for most of the times. Maybe other HCD doesn't > >> > giveback URBs with -EPROTO in such error

Re: MUSB interrupt storm on device removal

2019-01-24 Thread Johan Hovold
On Wed, Jan 23, 2019 at 11:05:40AM -0500, Alan Stern wrote: > On Wed, 23 Jan 2019, Bin Liu wrote: > > > On Wed, Jan 23, 2019 at 03:55:47PM +0100, Johan Hovold wrote: > > > On Wed, Jan 23, 2019 at 08:09:47AM -0600, Bin Liu wrote: > > > > On Wed, Jan 23, 2019 at 09:55:49AM +0100, Johan Hovold wrote:

Re: MUSB interrupt storm on device removal

2019-01-24 Thread Greg KH
On Wed, Jan 23, 2019 at 02:12:38PM -0600, Bin Liu wrote: > > > > > Thanks for the info. > > > > > I will handle this case in musb driver. > > > > > > > > Why doesn't the same problem occur with other types of host controller? > > > > > > Not sure, I am on musb for most of the times. Maybe other H

Re: MUSB interrupt storm on device removal

2019-01-23 Thread Måns Rullgård
Bin Liu writes: >> > > Why doesn't the same problem occur with other types of host controller? >> > >> > Not sure, I am on musb for most of the times. Maybe other HCD doesn't >> > giveback URBs with -EPROTO in such error case. >> >> ehci-hcd also uses -EPROTO. > > Is it possible to test the use

Re: MUSB interrupt storm on device removal

2019-01-23 Thread Alan Stern
On Wed, 23 Jan 2019, Bin Liu wrote: > On Wed, Jan 23, 2019 at 12:42:36PM -0500, Alan Stern wrote: > > On Wed, 23 Jan 2019, Bin Liu wrote: > > > > > > One possibility is to giveback URBs with certain errors (such as > > > > -EPROTO) only at a frame boundary, or at 1-ms intervals. This feels > >

Re: MUSB interrupt storm on device removal

2019-01-23 Thread Bin Liu
On Wed, Jan 23, 2019 at 12:42:36PM -0500, Alan Stern wrote: > On Wed, 23 Jan 2019, Bin Liu wrote: > > > > One possibility is to giveback URBs with certain errors (such as > > > -EPROTO) only at a frame boundary, or at 1-ms intervals. This feels > > > like a very artificial solution, though. > >

Re: MUSB interrupt storm on device removal

2019-01-23 Thread Alan Stern
On Wed, 23 Jan 2019, Bin Liu wrote: > > One possibility is to giveback URBs with certain errors (such as > > -EPROTO) only at a frame boundary, or at 1-ms intervals. This feels > > like a very artificial solution, though. > > My plan is to add an error counter in musb driver endpoint struct, if

Re: MUSB interrupt storm on device removal

2019-01-23 Thread Bin Liu
On Wed, Jan 23, 2019 at 11:05:40AM -0500, Alan Stern wrote: > On Wed, 23 Jan 2019, Bin Liu wrote: > > > On Wed, Jan 23, 2019 at 03:55:47PM +0100, Johan Hovold wrote: > > > On Wed, Jan 23, 2019 at 08:09:47AM -0600, Bin Liu wrote: > > > > On Wed, Jan 23, 2019 at 09:55:49AM +0100, Johan Hovold wrote:

Re: MUSB interrupt storm on device removal

2019-01-23 Thread Alan Stern
On Wed, 23 Jan 2019, Bin Liu wrote: > On Wed, Jan 23, 2019 at 03:55:47PM +0100, Johan Hovold wrote: > > On Wed, Jan 23, 2019 at 08:09:47AM -0600, Bin Liu wrote: > > > On Wed, Jan 23, 2019 at 09:55:49AM +0100, Johan Hovold wrote: > > > > On Wed, Jan 23, 2019 at 07:52:12AM +0100, Greg Kroah-Hartman

Re: MUSB interrupt storm on device removal

2019-01-23 Thread Bin Liu
On Wed, Jan 23, 2019 at 03:55:47PM +0100, Johan Hovold wrote: > On Wed, Jan 23, 2019 at 08:09:47AM -0600, Bin Liu wrote: > > On Wed, Jan 23, 2019 at 09:55:49AM +0100, Johan Hovold wrote: > > > On Wed, Jan 23, 2019 at 07:52:12AM +0100, Greg Kroah-Hartman wrote: > > > > > That's not what any other h

Re: MUSB interrupt storm on device removal

2019-01-23 Thread Johan Hovold
On Wed, Jan 23, 2019 at 08:09:47AM -0600, Bin Liu wrote: > On Wed, Jan 23, 2019 at 09:55:49AM +0100, Johan Hovold wrote: > > On Wed, Jan 23, 2019 at 07:52:12AM +0100, Greg Kroah-Hartman wrote: > > > That's not what any other host controller returns when a device is > > > removed, so either you are

Re: MUSB interrupt storm on device removal

2019-01-23 Thread Bin Liu
On Wed, Jan 23, 2019 at 09:55:49AM +0100, Johan Hovold wrote: > On Wed, Jan 23, 2019 at 07:52:12AM +0100, Greg Kroah-Hartman wrote: > > On Tue, Jan 22, 2019 at 02:52:44PM -0600, Bin Liu wrote: > > > Hi Johan, > > > > > > On Tue, Jan 22, 2019 at 02:16:30PM -0600, Bin Liu wrote: > > > > On Tue, Jan

Re: MUSB interrupt storm on device removal

2019-01-23 Thread Johan Hovold
On Wed, Jan 23, 2019 at 07:52:12AM +0100, Greg Kroah-Hartman wrote: > On Tue, Jan 22, 2019 at 02:52:44PM -0600, Bin Liu wrote: > > Hi Johan, > > > > On Tue, Jan 22, 2019 at 02:16:30PM -0600, Bin Liu wrote: > > > On Tue, Jan 22, 2019 at 05:19:39PM +, Måns Rullgård wrote: > > > > Bin Liu writes

Re: MUSB interrupt storm on device removal

2019-01-22 Thread Greg KH
On Tue, Jan 22, 2019 at 02:52:44PM -0600, Bin Liu wrote: > Hi Johan, > > On Tue, Jan 22, 2019 at 02:16:30PM -0600, Bin Liu wrote: > > On Tue, Jan 22, 2019 at 05:19:39PM +, Måns Rullgård wrote: > > > Bin Liu writes: > > > > > > > On Mon, Jan 21, 2019 at 09:20:52PM +, Måns Rullgård wrote:

Re: MUSB interrupt storm on device removal

2019-01-22 Thread Bin Liu
Hi Johan, On Tue, Jan 22, 2019 at 02:16:30PM -0600, Bin Liu wrote: > On Tue, Jan 22, 2019 at 05:19:39PM +, Måns Rullgård wrote: > > Bin Liu writes: > > > > > On Mon, Jan 21, 2019 at 09:20:52PM +, Måns Rullgård wrote: > > >> Bin Liu writes: > > >> > > >> > On Fri, Jan 18, 2019 at 08:15:

Re: MUSB interrupt storm on device removal

2019-01-22 Thread Bin Liu
On Tue, Jan 22, 2019 at 05:19:39PM +, Måns Rullgård wrote: > Bin Liu writes: > > > On Mon, Jan 21, 2019 at 09:20:52PM +, Måns Rullgård wrote: > >> Bin Liu writes: > >> > >> > On Fri, Jan 18, 2019 at 08:15:02PM +, Måns Rullgård wrote: > >> >> Bin Liu writes: > >> >> > >> >> > On Mo

Re: MUSB interrupt storm on device removal

2019-01-22 Thread Måns Rullgård
Bin Liu writes: > On Mon, Jan 21, 2019 at 09:20:52PM +, Måns Rullgård wrote: >> Bin Liu writes: >> >> > On Fri, Jan 18, 2019 at 08:15:02PM +, Måns Rullgård wrote: >> >> Bin Liu writes: >> >> >> >> > On Mon, Dec 17, 2018 at 09:36:17PM +, Måns Rullgård wrote: >> >> >> Bin Liu write

Re: MUSB interrupt storm on device removal

2019-01-22 Thread Bin Liu
On Mon, Jan 21, 2019 at 09:20:52PM +, Måns Rullgård wrote: > Bin Liu writes: > > > On Fri, Jan 18, 2019 at 08:15:02PM +, Måns Rullgård wrote: > >> Bin Liu writes: > >> > >> > On Mon, Dec 17, 2018 at 09:36:17PM +, Måns Rullgård wrote: > >> >> Bin Liu writes: > >> >> > >> >> > On Mo

Re: MUSB interrupt storm on device removal

2019-01-21 Thread Måns Rullgård
Bin Liu writes: > On Fri, Jan 18, 2019 at 08:15:02PM +, Måns Rullgård wrote: >> Bin Liu writes: >> >> > On Mon, Dec 17, 2018 at 09:36:17PM +, Måns Rullgård wrote: >> >> Bin Liu writes: >> >> >> >> > On Mon, Dec 17, 2018 at 07:16:08PM +, Måns Rullgård wrote: >> >> >> Bin Liu write

Re: MUSB interrupt storm on device removal

2019-01-21 Thread Bin Liu
On Fri, Jan 18, 2019 at 08:15:02PM +, Måns Rullgård wrote: > Bin Liu writes: > > > On Mon, Dec 17, 2018 at 09:36:17PM +, Måns Rullgård wrote: > >> Bin Liu writes: > >> > >> > On Mon, Dec 17, 2018 at 07:16:08PM +, Måns Rullgård wrote: > >> >> Bin Liu writes: > >> >> > >> >> > Hi, >

Re: MUSB interrupt storm on device removal

2019-01-18 Thread Måns Rullgård
Bin Liu writes: > On Mon, Dec 17, 2018 at 09:36:17PM +, Måns Rullgård wrote: >> Bin Liu writes: >> >> > On Mon, Dec 17, 2018 at 07:16:08PM +, Måns Rullgård wrote: >> >> Bin Liu writes: >> >> >> >> > Hi, >> >> > >> >> > On Mon, Dec 17, 2018 at 03:13:12PM +, Måns Rullgård wrote: >>

Re: MUSB interrupt storm on device removal

2019-01-09 Thread Bin Liu
On Mon, Dec 17, 2018 at 09:36:17PM +, Måns Rullgård wrote: > Bin Liu writes: > > > On Mon, Dec 17, 2018 at 07:16:08PM +, Måns Rullgård wrote: > >> Bin Liu writes: > >> > >> > Hi, > >> > > >> > On Mon, Dec 17, 2018 at 03:13:12PM +, Måns Rullgård wrote: > >> >> I have a strange proble

Re: MUSB interrupt storm on device removal

2019-01-09 Thread Måns Rullgård
Bin Liu writes: > On Mon, Dec 17, 2018 at 07:16:08PM +, Måns Rullgård wrote: >> Bin Liu writes: >> >> > Hi, >> > >> > On Mon, Dec 17, 2018 at 03:13:12PM +, Måns Rullgård wrote: >> >> I have a strange problem with the musb driver in host mode on AM3358 >> >> (beaglebone) hardware. If I

Re: MUSB interrupt storm on device removal

2018-12-17 Thread Måns Rullgård
Bin Liu writes: > On Mon, Dec 17, 2018 at 07:16:08PM +, Måns Rullgård wrote: >> Bin Liu writes: >> >> > Hi, >> > >> > On Mon, Dec 17, 2018 at 03:13:12PM +, Måns Rullgård wrote: >> >> I have a strange problem with the musb driver in host mode on AM3358 >> >> (beaglebone) hardware. If I

Re: MUSB interrupt storm on device removal

2018-12-17 Thread Bin Liu
On Mon, Dec 17, 2018 at 07:16:08PM +, Måns Rullgård wrote: > Bin Liu writes: > > > Hi, > > > > On Mon, Dec 17, 2018 at 03:13:12PM +, Måns Rullgård wrote: > >> I have a strange problem with the musb driver in host mode on AM3358 > >> (beaglebone) hardware. If I connect a multi-port serial

Re: MUSB interrupt storm on device removal

2018-12-17 Thread Måns Rullgård
Bin Liu writes: > Hi, > > On Mon, Dec 17, 2018 at 03:13:12PM +, Måns Rullgård wrote: >> I have a strange problem with the musb driver in host mode on AM3358 >> (beaglebone) hardware. If I connect a multi-port serial adapter and >> open two or more of the ttys, then unplug the device, an inte

Re: MUSB interrupt storm on device removal

2018-12-17 Thread Bin Liu
Hi, On Mon, Dec 17, 2018 at 03:13:12PM +, Måns Rullgård wrote: > I have a strange problem with the musb driver in host mode on AM3358 > (beaglebone) hardware. If I connect a multi-port serial adapter and > open two or more of the ttys, then unplug the device, an interrupt storm > ensues that

MUSB interrupt storm on device removal

2018-12-17 Thread Måns Rullgård
I have a strange problem with the musb driver in host mode on AM3358 (beaglebone) hardware. If I connect a multi-port serial adapter and open two or more of the ttys, then unplug the device, an interrupt storm ensues that makes the system completely unresponsive until the watchdog resets it. Enab