Re: [PATCH v7 3/5] usb: dwc2: add generic PHY framework support for dwc2 usb controler platform driver.

2015-01-13 Thread Felipe Balbi
On Tue, Jan 13, 2015 at 10:35:52AM +0100, Robert Jarzmik wrote: > Paul Zimmerman writes: > > The patch below fixes it. And it seems like the right thing to me, > > since GPIOs should be optional for a generic phy, I would think. But > > my device tree foo is very weak, so I'm not sure. > > > > CCi

Re: [PATCH v7 3/5] usb: dwc2: add generic PHY framework support for dwc2 usb controler platform driver.

2015-01-13 Thread Robert Jarzmik
Paul Zimmerman writes: > The patch below fixes it. And it seems like the right thing to me, > since GPIOs should be optional for a generic phy, I would think. But > my device tree foo is very weak, so I'm not sure. > > CCing Robert, who touched the generic phy code last. Robert, what do > you thin

RE: [PATCH v7 3/5] usb: dwc2: add generic PHY framework support for dwc2 usb controler platform driver.

2015-01-12 Thread Paul Zimmerman
> From: Paul Zimmerman > Sent: Saturday, January 10, 2015 3:52 PM > > > From: Yunzhi Li [mailto:l...@rock-chips.com] > > Sent: Saturday, January 10, 2015 8:07 AM > > > > 在 2015/1/9 10:15, Paul Zimmerman 写道: > > >> [...] > > >> /* > > >> - * Attempt to find a generic PHY, then look

RE: [PATCH v7 3/5] usb: dwc2: add generic PHY framework support for dwc2 usb controler platform driver.

2015-01-10 Thread Paul Zimmerman
> From: Yunzhi Li [mailto:l...@rock-chips.com] > Sent: Saturday, January 10, 2015 8:07 AM > > 在 2015/1/9 10:15, Paul Zimmerman 写道: > >> [...] > >>/* > >> - * Attempt to find a generic PHY, then look for an old style > >> - * USB PHY, finally fall back to pdata > >> + * If platform probe

Re: [PATCH v7 3/5] usb: dwc2: add generic PHY framework support for dwc2 usb controler platform driver.

2015-01-10 Thread Yunzhi Li
Hi paul: 在 2015/1/9 10:15, Paul Zimmerman 写道: [...] /* -* Attempt to find a generic PHY, then look for an old style -* USB PHY, finally fall back to pdata +* If platform probe couldn't find a generic PHY or an old style +* USB PHY, fall back to pdata

Re: [PATCH v7 3/5] usb: dwc2: add generic PHY framework support for dwc2 usb controler platform driver.

2015-01-10 Thread Yunzhi Li
Hi Paul: On 2015/1/9 10:15, Paul Zimmerman wrote: /* -* Attempt to find a generic PHY, then look for an old style -* USB PHY, finally fall back to pdata +* If platform probe couldn't find a generic PHY or an old style +* USB PHY, fall back to pdata

RE: [PATCH v7 3/5] usb: dwc2: add generic PHY framework support for dwc2 usb controler platform driver.

2015-01-08 Thread Paul Zimmerman
rk. I am testing with the driver built-in. I haven't tried it as a module yet. Any ideas? Is the -EPROBE_DEFER return really needed here? -- Paul > + } > + hsotg->plat = plat; > + } else if (hsotg->phy) { > /* >

Re: [PATCH v7 3/5] usb: dwc2: add generic PHY framework support for dwc2 usb controler platform driver.

2014-12-15 Thread Doug Anderson
Yunzhi, On Fri, Dec 12, 2014 at 7:09 AM, Yunzhi Li wrote: > Get PHY parameters from devicetree and power off usb PHY during > system suspend. > > Signed-off-by: Yunzhi Li > Acked-by: Paul Zimmerman > > --- > > Changes in v7: None > Changes in v6: None > Changes in v5: None > Changes in v4: None

[PATCH v7 3/5] usb: dwc2: add generic PHY framework support for dwc2 usb controler platform driver.

2014-12-12 Thread Yunzhi Li
dev_err(dev, + "no platform data or transceiver defined\n"); + return -EPROBE_DEFER; + } + hsotg->plat = plat; + } else if (hsotg->phy) { /* * If using the generic PHY framewo

[PATCH v6 3/5] usb: dwc2: add generic PHY framework support for dwc2 usb controler platform driver.

2014-12-11 Thread Yunzhi Li
"no platform data or transceiver defined\n"); + return -EPROBE_DEFER; + } + hsotg->plat = plat; + } else if (hsotg->phy) { /* * If using the generic PHY framework, check if t

[PATCH v5 3/5] usb: dwc2: add generic PHY framework support for dwc2 usb controler platform driver.

2014-12-10 Thread Yunzhi Li
"no platform data or transceiver defined\n"); + return -EPROBE_DEFER; + } + hsotg->plat = plat; + } else if (hsotg->phy) { /* * If using the generic PHY framework, check if t

Re: [PATCH v4 3/5] usb: dwc2: add generic PHY framework support for dwc2 usb controler platform driver.

2014-12-08 Thread Felipe Balbi
On Tue, Dec 09, 2014 at 10:50:27AM +0800, Yunzhi Li wrote: > Get PHY parameters from devicetree and power off usb PHY during > system suspend. > > Signed-off-by: Yunzhi Li > > Acked-by: Paul Zimmerman > > Changes in v3: > - Fix coding style: both branches of the if() which only one > branch

[PATCH v4 3/5] usb: dwc2: add generic PHY framework support for dwc2 usb controler platform driver.

2014-12-08 Thread Yunzhi Li
"no platform data or transceiver defined\n"); + return -EPROBE_DEFER; + } + hsotg->plat = plat; + } else if (hsotg->phy) { /* * If using the generic PHY framework, check if t

RE: [PATCH v3 3/5] usb: dwc2: add generic PHY framework support for dwc2 usb controler platform driver.

2014-12-08 Thread Paul Zimmerman
{ > - hsotg->phy = phy; > + if (IS_ERR_OR_NULL(hsotg->phy) && IS_ERR_OR_NULL(hsotg->uphy)) { > + plat = dev_get_platdata(dev); > + if (!plat) { > + dev_err(dev, > + "no platform

RE: [PATCH v2 3/5] usb: dwc2: Add generic PHY framework support for dwc2 usb controler platform driver.

2014-12-08 Thread Paul Zimmerman
> From: Yunzhi Li [mailto:l...@rock-chips.com] > Sent: Sunday, December 07, 2014 7:58 PM > > On 2014/12/6 3:04, Paul Zimmerman wrote: > >> From: Yunzhi Li [mailto:l...@rock-chips.com] > >> Sent: Friday, December 05, 2014 4:52 AM > >> > >> Get PHY parameters from devicetree and power off usb PHY du

[PATCH v3 3/5] usb: dwc2: add generic PHY framework support for dwc2 usb controler platform driver.

2014-12-08 Thread Yunzhi Li
return -EPROBE_DEFER; + } + hsotg->plat = plat; + } else if (hsotg->phy) { /* * If using the generic PHY framework, check if the PHY bus * width is 8-bit and set the phyif appropriately.

Re: [PATCH v2 3/5] usb: dwc2: Add generic PHY framework support for dwc2 usb controler platform driver.

2014-12-07 Thread Yunzhi Li
Hi Paul: Thank you for replying. On 2014/12/6 3:04, Paul Zimmerman wrote: From: Yunzhi Li [mailto:l...@rock-chips.com] Sent: Friday, December 05, 2014 4:52 AM Get PHY parameters from devicetree and power off usb PHY during system suspend. Signed-off-by: Yunzhi Li --- drivers/usb/dwc2/gadg

RE: [PATCH v2 3/5] usb: dwc2: Add generic PHY framework support for dwc2 usb controler platform driver.

2014-12-05 Thread Paul Zimmerman
latform data or transceiver defined\n"); > + return -EPROBE_DEFER; > + } > + hsotg->plat = plat; > + } else if (hsotg->phy) { You have changed the behavior here. Previously, the driver would work even if there were no phys or pd

[PATCH v2 3/5] usb: dwc2: Add generic PHY framework support for dwc2 usb controler platform driver.

2014-12-05 Thread Yunzhi Li
"no platform data or transceiver defined\n"); + return -EPROBE_DEFER; + } + hsotg->plat = plat; + } else if (hsotg->phy) { /* * If using the generic PHY framework, check if the

Re: [PATCH v8 0/7] usb: add support for the generic PHY framework

2014-11-12 Thread Felipe Balbi
t 01:33:25PM +, Peter Chen wrote: > > > > > > > > > > > > > > > > > > > > > > Antoine Tenart (7): > > > > > usb: move the OTG state from the USB PHY to the OTG structure > > > > > usb: rename phy to usb_phy in OTG >

Re: [PATCH v8 0/7] usb: add support for the generic PHY framework

2014-11-11 Thread Peter Chen
gt; > > > Antoine Tenart (7): > > > > usb: move the OTG state from the USB PHY to the OTG structure > > > > usb: rename phy to usb_phy in OTG > > > > usb: add support to the generic PHY framework in OTG > > > > usb: allow to supply the

Re: [PATCH v8 0/7] usb: add support for the generic PHY framework

2014-11-11 Thread Peter Chen
gt; > > > Antoine Tenart (7): > > > > usb: move the OTG state from the USB PHY to the OTG structure > > > > usb: rename phy to usb_phy in OTG > > > > usb: add support to the generic PHY framework in OTG > > > > usb: allow to supply the

Re: [PATCH v8 0/7] usb: add support for the generic PHY framework

2014-11-07 Thread Felipe Balbi
TG structure > > > usb: rename phy to usb_phy in OTG > > > usb: add support to the generic PHY framework in OTG > > > usb: allow to supply the PHY in the drivers when using HCD > > > usb: chipidea: rename transceiver and phy to usb_phy > > > us

Re: [PATCH v8 0/7] usb: add support for the generic PHY framework

2014-11-07 Thread Felipe Balbi
Hi, On Fri, Nov 07, 2014 at 01:33:25PM +, Peter Chen wrote: > > > > > > > Antoine Tenart (7): > > usb: move the OTG state from the USB PHY to the OTG structure > > usb: rename phy to usb_phy in OTG > > usb: add support to the generic PHY fram

RE: [PATCH v8 0/7] usb: add support for the generic PHY framework

2014-11-07 Thread Peter Chen
> > Antoine Tenart (7): > usb: move the OTG state from the USB PHY to the OTG structure > usb: rename phy to usb_phy in OTG > usb: add support to the generic PHY framework in OTG > usb: allow to supply the PHY in the drivers when using HCD > usb: chipidea: renam

[PATCH v8 3/7] usb: add support to the generic PHY framework in OTG

2014-10-30 Thread Antoine Tenart
This patch adds support of the PHY framework in OTG and keeps the USB PHY compatibility. Here the only modification is to add PHY member in the OTG structure, along with the USB PHY one. Signed-off-by: Antoine Tenart --- include/linux/usb/otg.h | 3 +++ 1 file changed, 3 insertions(+) diff --gi

[PATCH v8 0/7] usb: add support for the generic PHY framework

2014-10-30 Thread Antoine Tenart
usb: add support to the generic PHY framework in OTG usb: allow to supply the PHY in the drivers when using HCD usb: chipidea: rename transceiver and phy to usb_phy usb: chipidea: move usb_otg into struct ci_hdrc usb: chipidea: add support to the generic PHY framework drivers/phy/phy-o

[PATCH v8 7/7] usb: chipidea: add support to the generic PHY framework

2014-10-30 Thread Antoine Tenart
This patch adds support of the PHY framework for ChipIdea drivers. Changes are done in both the ChipIdea common code and in the drivers accessing the PHY. This is done by adding a new PHY member in ChipIdea's structures and by taking care of it in the code. Signed-off-by: Antoine Tenart Acked-by:

Re: [PATCH v7 0/7] usb: add support for the generic PHY framework

2014-10-30 Thread Felipe Balbi
/msg48068.html > > Antoine Tenart (7): > usb: move the OTG state from the USB PHY to the OTG structure > usb: rename phy to usb_phy in OTG > usb: add support to the generic PHY framework in OTG > usb: allow to supply the PHY in the drivers when using HCD > usb: rename t

Re: [PATCH v7 0/7] usb: add support for the generic PHY framework

2014-10-28 Thread Peter Chen
html > > Antoine Tenart (7): > usb: move the OTG state from the USB PHY to the OTG structure > usb: rename phy to usb_phy in OTG > usb: add support to the generic PHY framework in OTG > usb: allow to supply the PHY in the drivers when using HCD > usb: rename transceiv

[PATCH v7 0/7] usb: add support for the generic PHY framework

2014-10-28 Thread Antoine Tenart
arate patches [1] https://www.mail-archive.com/linux-usb%40vger.kernel.org/msg48068.html Antoine Tenart (7): usb: move the OTG state from the USB PHY to the OTG structure usb: rename phy to usb_phy in OTG usb: add support to the generic PHY framework in OTG usb: allow to supply the PHY i

[PATCH v7 7/7] usb: chipidea: add support to the generic PHY framework in ChipIdea

2014-10-28 Thread Antoine Tenart
This patch adds support of the PHY framework for ChipIdea drivers. Changes are done in both the ChipIdea common code and in the drivers accessing the PHY. This is done by adding a new PHY member in ChipIdea's structures and by taking care of it in the code. Signed-off-by: Antoine Tenart --- driv

[PATCH v7 3/7] usb: add support to the generic PHY framework in OTG

2014-10-28 Thread Antoine Tenart
This patch adds support of the PHY framework in OTG and keeps the USB PHY compatibility. Here the only modification is to add PHY member in the OTG structure, along with the USB PHY one. Signed-off-by: Antoine Tenart --- include/linux/usb/otg.h | 3 +++ 1 file changed, 3 insertions(+) diff --gi

Re: [PATCH v6 0/7] usb: add support for the generic PHY framework

2014-09-28 Thread Peter Chen
s/phy/usb_phy/ renaming and generic PHY support in separate > patches > > [1] https://www.mail-archive.com/linux-usb%40vger.kernel.org/msg48068.html > [2] git://github.com/hzpeterchen/linux-usb.git ci-for-usb-next > > Antoine Tenart (7): > usb: move the OTG state from

[PATCH v6 0/7] usb: add support for the generic PHY framework

2014-09-23 Thread Antoine Tenart
Tenart (7): usb: move the OTG state from the USB PHY to the OTG structure usb: rename phy to usb_phy in OTG usb: add support to the generic PHY framework in OTG usb: allow to supply the PHY in the drivers when using HCD usb: rename transceiver and phy to usb_phy in ChipIdea usb: chip

[PATCH v6 7/7] usb: chipidea: add support to the generic PHY framework in ChipIdea

2014-09-23 Thread Antoine Tenart
This patch adds support of the PHY framework for ChipIdea drivers. Changes are done in both the ChipIdea common code and in the drivers accessing the PHY. This is done by adding a new PHY member in ChipIdea's structures and by taking care of it in the code. Signed-off-by: Antoine Tenart --- driv

[PATCH v6 3/7] usb: add support to the generic PHY framework in OTG

2014-09-23 Thread Antoine Tenart
This patch adds support of the PHY framework in OTG and keeps the USB PHY compatibility. Here the only modification is to add PHY member in the OTG structure, along with the USB PHY one. Signed-off-by: Antoine Tenart --- include/linux/usb/otg.h | 3 +++ 1 file changed, 3 insertions(+) diff --gi

Re: [PATCH v5 9/9] usb: chipidea: add support to the generic PHY framework in ChipIdea

2014-09-16 Thread Antoine Tenart
On Tue, Sep 16, 2014 at 08:07:21AM +0800, Peter Chen wrote: > On Mon, Sep 15, 2014 at 12:35:09PM +0200, Antoine Tenart wrote: > > diff --git a/drivers/usb/chipidea/debug.c b/drivers/usb/chipidea/debug.c > > index 8f437e1512fa..999e9d683d7a 100644 > > --- a/drivers/usb/chipidea/debug.c > > +++ b/dri

Re: [PATCH v5 9/9] usb: chipidea: add support to the generic PHY framework in ChipIdea

2014-09-15 Thread Peter Chen
On Mon, Sep 15, 2014 at 12:35:09PM +0200, Antoine Tenart wrote: > This patch adds support of the PHY framework for ChipIdea drivers. > Changes are done in both the ChipIdea common code and in the drivers > accessing the PHY. This is done by adding a new PHY member in > ChipIdea's structures and by

[PATCH v5 0/9] usb: add support for the generic PHY framework

2014-09-15 Thread Antoine Tenart
Hi all, This is an attempt to add more common USB code aware of the generic PHY framework, while keeping the compatibility for the USB PHY one. It does not add the full support, some USB PHY specific functions not being available currently in the generic PHY subsystem (e.g. usb_phy_set_power

[PATCH v5 9/9] usb: chipidea: add support to the generic PHY framework in ChipIdea

2014-09-15 Thread Antoine Tenart
This patch adds support of the PHY framework for ChipIdea drivers. Changes are done in both the ChipIdea common code and in the drivers accessing the PHY. This is done by adding a new PHY member in ChipIdea's structures and by taking care of it in the code. Signed-off-by: Antoine Tenart --- driv

[PATCH v5 3/9] usb: add support to the generic PHY framework in OTG

2014-09-15 Thread Antoine Tenart
This patch adds support of the PHY framework in OTG and keeps the USB PHY compatibility. Here the only modification is to add PHY member in the OTG structure, along with the USB PHY one. Signed-off-by: Antoine Tenart --- include/linux/usb/otg.h | 3 +++ 1 file changed, 3 insertions(+) diff --gi

RE: [PATCH v4 9/9] usb: chipidea: add support to the generic PHY framework in ChipIdea

2014-09-12 Thread Peter Chen
; > > > > > + return -ENXIO; > > > > > > > > > > > > > > > > > > - dev_err(dev, "no usb2 phy configured\n"); > > > > > > > > > - return -EPROBE_DE

Re: [PATCH v4 9/9] usb: chipidea: add support to the generic PHY framework in ChipIdea

2014-09-12 Thread Antoine Tenart
t; > > > > > > > > > > > > > - dev_err(dev, "no usb2 phy configured\n"); > > > > > > > > - return -EPROBE_DEFER; > > > > > > > > + ci->usb_phy = devm_usb_get_ph

Re: [PATCH v4 9/9] usb: chipidea: add support to the generic PHY framework in ChipIdea

2014-09-12 Thread Peter Chen
> > > + return -ENXIO; > > > > > > > > > > > > > > - dev_err(dev, "no usb2 phy configured\n"); > > > > > > > - return -EPROBE_DEFER; > > > > > > > + ci->usb

Re: [PATCH v4 9/9] usb: chipidea: add support to the generic PHY framework in ChipIdea

2014-09-12 Thread Antoine Tenart
> - return -EPROBE_DEFER; > > > > > > + ci->usb_phy = devm_usb_get_phy(dev, USB_PHY_TYPE_USB2); > > > > > > + if (IS_ERR(ci->usb_phy)) { > > > > > > + dev_err(dev, "no usb2 phy configu

Re: [PATCH v4 9/9] usb: chipidea: add support to the generic PHY framework in ChipIdea

2014-09-12 Thread Peter Chen
dev_err(dev, "no usb2 phy configured\n"); > > > > > - return -EPROBE_DEFER; > > > > > + ci->usb_phy = devm_usb_get_phy(dev, USB_PHY_TYPE_USB2); > > > > > + if (IS_ERR(ci->usb_phy)) { > > > &g

Re: [PATCH v4 9/9] usb: chipidea: add support to the generic PHY framework in ChipIdea

2014-09-12 Thread Antoine Tenart
ev, USB_PHY_TYPE_USB2); > > > > + if (IS_ERR(ci->usb_phy)) { > > > > + dev_err(dev, "no usb2 phy configured\n"); > > > > + return -EPROBE_DEFER; > > > > + } > > >

RE: [PATCH v4 9/9] usb: chipidea: add support to the generic PHY framework in ChipIdea

2014-09-11 Thread Peter Chen
dev_err(dev, "no usb2 phy configured\n"); > > > + return -EPROBE_DEFER; > > > + } > > > } > > > > Sorry, I can't accept this change, why devm_usb_get_phy(dev, > > USB_PHY_TYPE_USB2) is put at error pa

Re: [PATCH v4 9/9] usb: chipidea: add support to the generic PHY framework in ChipIdea

2014-09-11 Thread Antoine Tenart
PROBE_DEFER; > > + } > > } > > Sorry, I can't accept this change, why devm_usb_get_phy(dev, > USB_PHY_TYPE_USB2) > is put at error path? Since current get PHY operation is a little complicated, > we may have a dedicate function to do it, dwc3 driver i

Re: [PATCH v4 9/9] usb: chipidea: add support to the generic PHY framework in ChipIdea

2014-09-10 Thread Peter Chen
On Wed, Sep 03, 2014 at 09:40:40AM +0200, Antoine Tenart wrote: > This patch adds support of the PHY framework for ChipIdea drivers. > Changes are done in both the ChipIdea common code and in the drivers > accessing the PHY. This is done by adding a new PHY member in > ChipIdea's structures and by

RE: [PATCH v4 9/9] usb: chipidea: add support to the generic PHY framework in ChipIdea

2014-09-03 Thread b47...@freescale.com
support to the generic PHY framework in ChipIdea This patch adds support of the PHY framework for ChipIdea drivers. Changes are done in both the ChipIdea common code and in the drivers accessing the PHY. This is done by adding a new PHY member in ChipIdea's structures and by taking care of

[PATCH v4 0/9] usb: add support for the generic PHY framework

2014-09-03 Thread Antoine Tenart
Hi all, This is an attempt to add more common USB code aware of the generic PHY framework, while keeping the compatibility for the USB PHY one. It does not add the full support, some USB PHY specific functions not being available currently in the generic PHY subsystem (e.g. usb_phy_set_power

[PATCH v4 3/9] usb: add support to the generic PHY framework in OTG

2014-09-03 Thread Antoine Tenart
This patch adds support of the PHY framework in OTG and keeps the USB PHY compatibility. Here the only modification is to add PHY member in the OTG structure, along with the USB PHY one. Signed-off-by: Antoine Tenart --- include/linux/usb/otg.h | 3 +++ 1 file changed, 3 insertions(+) diff --gi

[PATCH v4 9/9] usb: chipidea: add support to the generic PHY framework in ChipIdea

2014-09-03 Thread Antoine Tenart
This patch adds support of the PHY framework for ChipIdea drivers. Changes are done in both the ChipIdea common code and in the drivers accessing the PHY. This is done by adding a new PHY member in ChipIdea's structures and by taking care of it in the code. Signed-off-by: Antoine Tenart --- driv

Re: [PATCH v3 9/9] usb: chipidea: add support to the generic PHY framework in ChipIdea

2014-08-29 Thread Antoine Ténart
Hi, On Tue, Aug 26, 2014 at 06:42:42PM +0800, Peter Chen wrote: > On Fri, Aug 22, 2014 at 05:50:20PM +0200, Antoine Ténart wrote: > > > > /** > > + * _ci_usb_phy_init: initialize phy taking in account both phy and usb_phy > > + * interfaces > > + * @ci: the controller > > + * > > + * This funct

Re: [PATCH v3 9/9] usb: chipidea: add support to the generic PHY framework in ChipIdea

2014-08-26 Thread Peter Chen
On Fri, Aug 22, 2014 at 05:50:20PM +0200, Antoine Ténart wrote: > This patch adds support of the PHY framework for ChipIdea drivers. > Changes are done in both the ChipIdea common code and in the drivers > accessing the PHY. This is done by adding a new PHY member in > ChipIdea's structures and by

[PATCH v3 0/9] usb: add support for the generic PHY framework

2014-08-22 Thread Antoine Ténart
Hi all, This is an attempt to add more common USB code aware of the generic PHY framework, while keeping the compatibility for the USB PHY one. It does not add the full support, some USB PHY specific functions not being available currently in the generic PHY subsystem (e.g. usb_phy_set_power

[PATCH v3 3/9] usb: add support to the generic PHY framework in OTG

2014-08-22 Thread Antoine Ténart
This patch adds support of the PHY framework in OTG and keeps the USB PHY compatibility. Here the only modification is to add PHY member in the OTG structure, along with the USB PHY one. Signed-off-by: Antoine Ténart --- include/linux/usb/otg.h | 3 +++ 1 file changed, 3 insertions(+) diff --gi

[PATCH v3 9/9] usb: chipidea: add support to the generic PHY framework in ChipIdea

2014-08-22 Thread Antoine Ténart
This patch adds support of the PHY framework for ChipIdea drivers. Changes are done in both the ChipIdea common code and in the drivers accessing the PHY. This is done by adding a new PHY member in ChipIdea's structures and by taking care of it in the code. Signed-off-by: Antoine Ténart --- driv

Re: [PATCH v2 8/8] usb: chipidea: add support to the generic PHY framework in ChipIdea

2014-07-25 Thread Antoine Ténart
On Fri, Jul 25, 2014 at 08:33:28AM +, Peter Chen wrote: > > > > > > > > > > > Just add OTG member into ci_hdrc structure, see below patch > > > > > > diff --git a/drivers/usb/chipidea/ci.h b/drivers/usb/chipidea/ci.h > > > index 9563cb5..186fb3f 100644 > > > --- a/drivers/usb/chipidea/ci.h >

RE: [PATCH v2 8/8] usb: chipidea: add support to the generic PHY framework in ChipIdea

2014-07-25 Thread Peter Chen
> > > > > > > Just add OTG member into ci_hdrc structure, see below patch > > > > diff --git a/drivers/usb/chipidea/ci.h b/drivers/usb/chipidea/ci.h > > index 9563cb5..186fb3f 100644 > > --- a/drivers/usb/chipidea/ci.h > > +++ b/drivers/usb/chipidea/ci.h > > @@ -207,6 +207,7 @@ struct ci_hdrc { >

Re: [PATCH v2 8/8] usb: chipidea: add support to the generic PHY framework in ChipIdea

2014-07-25 Thread Antoine Ténart
Hi Peter, On Fri, Jul 25, 2014 at 12:34:39AM +, Peter Chen wrote: > > > > > > > > > - if (ci->platdata->usb_phy) > > > > + if (ci->platdata->phy) > > > > + ci->phy = ci->platdata->phy; > > > > + else if (ci->platdata->usb_phy) > > > > ci->usb_p

RE: [PATCH v2 8/8] usb: chipidea: add support to the generic PHY framework in ChipIdea

2014-07-24 Thread Peter Chen
> > > > > > - if (ci->platdata->usb_phy) > > > + if (ci->platdata->phy) > > > + ci->phy = ci->platdata->phy; > > > + else if (ci->platdata->usb_phy) > > > ci->usb_phy = ci->platdata->usb_phy; > > > else > > > - ci->usb_phy = devm_usb_get_phy(dev, USB_PHY_TYPE_USB2); >

Re: [PATCH v2 8/8] usb: chipidea: add support to the generic PHY framework in ChipIdea

2014-07-24 Thread Antoine Ténart
Hi Peter, On Thu, Jul 24, 2014 at 07:39:42PM +0800, Peter Chen wrote: > On Tue, Jul 15, 2014 at 04:39:16PM +0200, Antoine Ténart wrote: > > > > /** > > + * _ci_usb_phy_init: initialize phy taking in account both phy and usb_phy > > + * interfaces > > + * @ci: the controller > > + * > > + * This

Re: [PATCH v2 8/8] usb: chipidea: add support to the generic PHY framework in ChipIdea

2014-07-24 Thread Peter Chen
On Tue, Jul 15, 2014 at 04:39:16PM +0200, Antoine Ténart wrote: > This patch adds support of the PHY framework for ChipIdea drivers. > Changes are done in both the ChipIdea common code and in the drivers > accessing the PHY. This is done by adding a new PHY member in > ChipIdea's structures and by

Re: [PATCH v2 0/8] usb: add support for the generic PHY framework

2014-07-23 Thread Peter Chen
On Tue, Jul 15, 2014 at 04:39:08PM +0200, Antoine Ténart wrote: > Hi all, > > This is an attempt to add more common USB code aware of the generic PHY > framework, while keeping the compatibility for the USB PHY one. It does > not add the full support, some USB PHY specific func

Re: [PATCH v2 0/8] usb: add support for the generic PHY framework

2014-07-17 Thread Felipe Balbi
Hi, On Thu, Jul 17, 2014 at 10:03:02AM +0200, Antoine Ténart wrote: > Hi Felipe, > > On Wed, Jul 16, 2014 at 12:45:13PM -0500, Felipe Balbi wrote: > > On Tue, Jul 15, 2014 at 04:39:08PM +0200, Antoine Ténart wrote: > > > > > > [1] https://www.mail-archive.com/linux-usb@vger.kernel.org/msg43471.h

Re: [PATCH v2 0/8] usb: add support for the generic PHY framework

2014-07-17 Thread Antoine Ténart
Hi Felipe, On Wed, Jul 16, 2014 at 12:45:13PM -0500, Felipe Balbi wrote: > On Tue, Jul 15, 2014 at 04:39:08PM +0200, Antoine Ténart wrote: > > > > [1] https://www.mail-archive.com/linux-usb@vger.kernel.org/msg43471.html > > Since this has a dependency on the other series which hasn't showed up >

Re: [PATCH v2 0/8] usb: add support for the generic PHY framework

2014-07-16 Thread Felipe Balbi
Hi, On Tue, Jul 15, 2014 at 04:39:08PM +0200, Antoine Ténart wrote: > Hi all, > > This is an attempt to add more common USB code aware of the generic PHY > framework, while keeping the compatibility for the USB PHY one. It does > not add the full support, some USB PHY specifi

Re: [PATCH v2 0/8] usb: add support for the generic PHY framework

2014-07-15 Thread Alan Stern
On Tue, 15 Jul 2014, Antoine Ténart wrote: > Hi all, > > This is an attempt to add more common USB code aware of the generic PHY > framework, while keeping the compatibility for the USB PHY one. It does > not add the full support, some USB PHY specific functions not being > a

[PATCH v2 0/8] usb: add support for the generic PHY framework

2014-07-15 Thread Antoine Ténart
Hi all, This is an attempt to add more common USB code aware of the generic PHY framework, while keeping the compatibility for the USB PHY one. It does not add the full support, some USB PHY specific functions not being available currently in the generic PHY subsystem (e.g. usb_phy_set_power

[PATCH v2 8/8] usb: chipidea: add support to the generic PHY framework in ChipIdea

2014-07-15 Thread Antoine Ténart
This patch adds support of the PHY framework for ChipIdea drivers. Changes are done in both the ChipIdea common code and in the drivers accessing the PHY. This is done by adding a new PHY member in ChipIdea's structures and by taking care of it in the code. Signed-off-by: Antoine Ténart --- driv

[PATCH v2 3/8] usb: add support to the generic PHY framework in OTG

2014-07-15 Thread Antoine Ténart
This patch adds support of the PHY framework in OTG and keeps the USB PHY compatibility. Here the only modification is to add PHY member in the OTG structure, along with the USB PHY one. Signed-off-by: Antoine Ténart --- include/linux/usb/otg.h | 3 +++ 1 file changed, 3 insertions(+) diff --gi

[PATCH 0/4] usb: add support for the generic PHY framework

2014-07-09 Thread Antoine Ténart
Hi all, This is an attempt to add more common USB code aware of the generic PHY framework, while keeping the compatibility for the USB PHY one. It does not add the full support, some USB PHY specific functions not being available currently in the generic PHY subsystem (e.g. usb_phy_set_power

[PATCH v9 0/3] Add Exynos5 USB 3.0 phy driver based on generic PHY framework

2014-05-13 Thread Vivek Gautam
Based on 'next' branch of Kishon's phy tree (linux-phy). Changes from v8: - Moved out the bindings documentation for the PHY in a separate patch to avoid checkpatch warnings. Changes from v7: - Providing an **alternative** approach for pmu-offset; instead of getting it from DT, using offs

Re: [PATCH v12 4/4] usb: ehci-exynos: Change to use phy provided by the generic phy framework

2014-05-09 Thread Tomasz Figa
Hi Vivek, On 05.05.2014 07:02, Vivek Gautam wrote: > From: Kamil Debski > > Add the phy provider, supplied by new Exynos-usb2phy using > Generic phy framework. > Keeping the support for older USB phy intact right now, in order > to prevent any functionality break in absence of

Re: [PATCH v6 3/4] usb: ohci-exynos: Add facility to use phy provided by the generic phy framework

2014-05-09 Thread Tomasz Figa
Hi Vivek, On 05.05.2014 07:02, Vivek Gautam wrote: > Add support to consume phy provided by Generic phy framework. > Keeping the support for older usb-phy intact right now, in order > to prevent any functionality break in absence of relevant > device tree side change for ohci-exyno

[PATCH v6 3/4] usb: ohci-exynos: Add facility to use phy provided by the generic phy framework

2014-05-04 Thread Vivek Gautam
Add support to consume phy provided by Generic phy framework. Keeping the support for older usb-phy intact right now, in order to prevent any functionality break in absence of relevant device tree side change for ohci-exynos. Once we move to new phy in the device nodes for ohci, we can remove the

[PATCH v12 4/4] usb: ehci-exynos: Change to use phy provided by the generic phy framework

2014-05-04 Thread Vivek Gautam
From: Kamil Debski Add the phy provider, supplied by new Exynos-usb2phy using Generic phy framework. Keeping the support for older USB phy intact right now, in order to prevent any functionality break in absence of relevant device tree side change for ehci-exynos. Once we move to new phy in the

Re: [PATCH v5 3/4] usb: ohci-exynos: Add facility to use phy provided by the generic phy framework

2014-05-02 Thread Tomasz Figa
Hi Vivek, This looks much better, but there still are some issues. Please see my comments inline. On 02.05.2014 14:47, Vivek Gautam wrote: Add support to consume phy provided by Generic phy framework. Keeping the support for older usb-phy intact right now, in order to prevent any

Re: [PATCH v5 0/4] usb: ehci/ohci-exynos: Move to generic phy framework

2014-05-02 Thread Kukjin Kim
ttps://lkml.org/lkml/2014/4/30/119 Kamil Debski (1): usb: ehci-exynos: Change to use phy provided by the generic phy framework Vivek Gautam (3): usb: ohci-exynos: Use struct device instead of platform_device usb: ehci-exynos: Use struct device instead of platform_device usb: o

[PATCH v5 0/4] usb: ehci/ohci-exynos: Move to generic phy framework

2014-05-02 Thread Vivek Gautam
-exynos: Change to use phy provided by the generic phy framework Vivek Gautam (3): usb: ohci-exynos: Use struct device instead of platform_device usb: ehci-exynos: Use struct device instead of platform_device usb: ohci-exynos: Add facility to use phy provided by the generic ph

[PATCH v5 3/4] usb: ohci-exynos: Add facility to use phy provided by the generic phy framework

2014-05-02 Thread Vivek Gautam
Add support to consume phy provided by Generic phy framework. Keeping the support for older usb-phy intact right now, in order to prevent any functionality break in absence of relevant device tree side change for ohci-exynos. Once we move to new phy in the device nodes for ohci, we can remove the

[PATCH v11 4/4] usb: ehci-exynos: Change to use phy provided by the generic phy framework

2014-05-02 Thread Vivek Gautam
From: Kamil Debski Add the phy provider, supplied by new Exynos-usb2phy using Generic phy framework. Keeping the support for older USB phy intact right now, in order to prevent any functionality break in absence of relevant device tree side change for ehci-exynos. Once we move to new phy in the

Re: [PATCH v4 3/4] usb: ohci-exynos: Add facility to use phy provided by the generic phy framework

2014-05-02 Thread Vivek Gautam
> On 30.04.2014 07:19, Vivek Gautam wrote: >>> >>> Add support to consume phy provided by Generic phy framework. >>> Keeping the support for older usb-phy intact right now, in order >>> to prevent any functionality break in absence of relevant >>> dev

Re: [PATCH v4 3/4] usb: ohci-exynos: Add facility to use phy provided by the generic phy framework

2014-05-02 Thread Vivek Gautam
Hi Tomasz, On Thu, May 1, 2014 at 10:46 PM, Tomasz Figa wrote: > Hi Vivek, > > Please see my comments inline. Thanks for the review, please find my answers inline. > > > On 30.04.2014 07:19, Vivek Gautam wrote: >> >> Add support to consume phy provided by Generic

Re: [PATCH v10 4/4] usb: ehci-exynos: Change to use phy provided by the generic phy framework

2014-05-01 Thread Tomasz Figa
Hi Vivek, I believe the same comments as for the patch for ohci-exynos apply for this patch as well. Best regards, Tomasz On 30.04.2014 07:19, Vivek Gautam wrote: From: Kamil Debski Add the phy provider, supplied by new Exynos-usb2phy using Generic phy framework. Keeping the support for

Re: [PATCH v4 3/4] usb: ohci-exynos: Add facility to use phy provided by the generic phy framework

2014-05-01 Thread Tomasz Figa
Hi Vivek, Please see my comments inline. On 30.04.2014 07:19, Vivek Gautam wrote: Add support to consume phy provided by Generic phy framework. Keeping the support for older usb-phy intact right now, in order to prevent any functionality break in absence of relevant device tree side change for

[PATCH v4 3/4] usb: ohci-exynos: Add facility to use phy provided by the generic phy framework

2014-04-29 Thread Vivek Gautam
Add support to consume phy provided by Generic phy framework. Keeping the support for older usb-phy intact right now, in order to prevent any functionality break in absence of relevant device tree side change for ohci-exynos. Once we move to new phy in the device nodes for ohci, we can remove the

[PATCH v10 4/4] usb: ehci-exynos: Change to use phy provided by the generic phy framework

2014-04-29 Thread Vivek Gautam
From: Kamil Debski Add the phy provider, supplied by new Exynos-usb2phy using Generic phy framework. Keeping the support for older USB phy intact right now, in order to prevent any functionality break in absence of relevant device tree side change for ehci-exynos. Once we move to new phy in the

Re: [PATCH v3 3/4] usb: ohci-exynos: Add facility to use phy provided by the generic phy framework

2014-04-29 Thread Vivek Gautam
Hi, On Mon, Apr 28, 2014 at 9:11 PM, Alan Stern wrote: > On Mon, 28 Apr 2014, Vivek Gautam wrote: > >> Add support to consume phy provided by Generic phy framework. >> Keeping the support for older usb-phy intact right now, in order >> to prevent any functionality brea

Re: [PATCH v3 3/4] usb: ohci-exynos: Add facility to use phy provided by the generic phy framework

2014-04-28 Thread Alan Stern
On Mon, 28 Apr 2014, Vivek Gautam wrote: > Add support to consume phy provided by Generic phy framework. > Keeping the support for older usb-phy intact right now, in order > to prevent any functionality break in absence of relevant > device tree side change for ohci-exynos. > Once

Re: [PATCH v3 0/4] usb: ehci/ohci-exynos: Move to generic phy framework

2014-04-28 Thread Vivek Gautam
usb: ehci-exynos: Change to use phy provided by the generic phy > framework > > Vivek Gautam (3): > usb: ohci-exynos: Use struct device instead of platform_device > usb: ehci-exynos: Use struct device instead of platform_device > usb: ohci-exynos: Add facility to use phy provided b

[PATCH v3 0/4] usb: ehci/ohci-exynos: Move to generic phy framework

2014-04-28 Thread Vivek Gautam
Added necessary checks. Kamil Debski (1): usb: ehci-exynos: Change to use phy provided by the generic phy framework Vivek Gautam (3): usb: ohci-exynos: Use struct device instead of platform_device usb: ehci-exynos: Use struct device instead of platform_device usb: ohci-exynos: Add faci

[PATCH v3 0/4] usb: ehci/ohci-exynos: Move to generic phy framework

2014-04-28 Thread Vivek Gautam
Added necessary checks. Kamil Debski (1): usb: ehci-exynos: Change to use phy provided by the generic phy framework Vivek Gautam (3): usb: ohci-exynos: Use struct device instead of platform_device usb: ehci-exynos: Use struct device instead of platform_device usb: ohci-exynos: Add faci

[PATCH v3 3/4] usb: ohci-exynos: Add facility to use phy provided by the generic phy framework

2014-04-28 Thread Vivek Gautam
Add support to consume phy provided by Generic phy framework. Keeping the support for older usb-phy intact right now, in order to prevent any functionality break in absence of relevant device tree side change for ohci-exynos. Once we move to new phy in the device nodes for ohci, we can remove the

[PATCH v9 4/4] usb: ehci-exynos: Change to use phy provided by the generic phy framework

2014-04-28 Thread Vivek Gautam
From: Kamil Debski Add the phy provider, supplied by new Exynos-usb2phy using Generic phy framework. Keeping the support for older USB phy intact right now, in order to prevent any functionality break in absence of relevant device tree side change for ehci-exynos. Once we move to new phy in the

Re: [PATCH v8 2/2] usb: ehci-exynos: Change to use phy provided by the generic phy framework

2014-04-27 Thread Vivek Gautam
Hi, On Fri, Apr 25, 2014 at 8:11 PM, Alan Stern wrote: > On Fri, 25 Apr 2014, Vivek Gautam wrote: > >> From: Kamil Debski >> >> Add the phy provider, supplied by new Exynos-usb2phy using >> Generic phy framework. >> Keeping the support for older USB phy inta

Re: [PATCH v2 1/2] usb: ohci-exynos: Add facility to use phy provided by the generic phy framework

2014-04-27 Thread Vivek Gautam
Hi, On Fri, Apr 25, 2014 at 8:06 PM, Alan Stern wrote: > On Fri, 25 Apr 2014, Vivek Gautam wrote: > >> Add support to consume phy provided by Generic phy framework. >> Keeping the support for older usb-phy intact right now, in order >> to prevent any functionality brea

  1   2   3   4   5   6   >