Re: FTDI USB-to-UART converters and tcdrain()

2012-10-15 Thread Jarkko Huijts
On Sat, 2012-10-13 at 17:33 +0200, Johan Hovold wrote: > Thanks for the patch Jarkko. Your solution is nice, but I think it could > implemented in a slightly better way. > > For starters, the subdrivers really shouldn't be poking around in the > generic driver's implementation details unless reall

Re: FTDI USB-to-UART converters and tcdrain()

2012-10-13 Thread Johan Hovold
On Thu, Oct 11, 2012 at 04:57:11AM +0900, Greg KH wrote: > On Wed, Oct 10, 2012 at 03:05:09PM +0200, Jarkko Huijts wrote: > > On Tue, 2012-10-09 at 07:59 -0700, Greg KH wrote: > > > On Tue, Oct 09, 2012 at 12:21:56PM +0200, Jarkko Huijts wrote: > > > > I have e-mailed FTDI's support to ask whether

Re: FTDI USB-to-UART converters and tcdrain()

2012-10-11 Thread Jarkko Huijts
On Thu, 2012-10-11 at 04:57 +0900, Greg KH wrote: > The patch looks great, thanks so much for doing this. I'll queue it up > after 3.7-rc1 is released by Linus (which should be in a few days). No problem. It's pretty cool to be able to contribute. -- To unsubscribe from this list: send the line

Re: FTDI USB-to-UART converters and tcdrain()

2012-10-10 Thread Greg KH
On Wed, Oct 10, 2012 at 03:05:09PM +0200, Jarkko Huijts wrote: > On Tue, 2012-10-09 at 07:59 -0700, Greg KH wrote: > > On Tue, Oct 09, 2012 at 12:21:56PM +0200, Jarkko Huijts wrote: > > > I have e-mailed FTDI's support to ask whether the assumptions described > > > above are true and whether there

Re: FTDI USB-to-UART converters and tcdrain()

2012-10-10 Thread Jarkko Huijts
On Tue, 2012-10-09 at 07:59 -0700, Greg KH wrote: > On Tue, Oct 09, 2012 at 12:21:56PM +0200, Jarkko Huijts wrote: > > I have e-mailed FTDI's support to ask whether the assumptions described > > above are true and whether there is no register to read the actual > > amount of data in the hardware bu

Re: FTDI USB-to-UART converters and tcdrain()

2012-10-09 Thread Greg KH
On Tue, Oct 09, 2012 at 12:21:56PM +0200, Jarkko Huijts wrote: > On Thu, 2012-10-04 at 15:25 -0700, Greg KH wrote: > > > - Is tcdrain() supposed to ensure that all TX data has been sent for any > > > serial device? If so, why is it not implemented for this device? > > > > No one has implemented it

Re: FTDI USB-to-UART converters and tcdrain()

2012-10-09 Thread Jarkko Huijts
On Thu, 2012-10-04 at 15:25 -0700, Greg KH wrote: > > - Is tcdrain() supposed to ensure that all TX data has been sent for any > > serial device? If so, why is it not implemented for this device? > > No one has implemented it to do so. Other usb-serial drivers have > implemented this functionalit

Re: FTDI USB-to-UART converters and tcdrain()

2012-10-04 Thread Greg KH
On Tue, Oct 02, 2012 at 05:56:30PM +0200, Jarkko Huijts wrote: > Hello knowledgeable people, > > I have a question regarding tcdrain() and kernel driver > drivers/usb/serial/ftdi_sio.c (for a family of USB-to-UART converter > chips from FTDI). I'm using an FT232RL and kernel 2.6.38-16. (The driver

FTDI USB-to-UART converters and tcdrain()

2012-10-02 Thread Jarkko Huijts
Hello knowledgeable people, I have a question regarding tcdrain() and kernel driver drivers/usb/serial/ftdi_sio.c (for a family of USB-to-UART converter chips from FTDI). I'm using an FT232RL and kernel 2.6.38-16. (The driver code does not seem to have changed much between that version and 3.6.)