Re: Endpoint is not halted

2012-11-01 Thread Sarah Sharp
On Wed, Oct 31, 2012 at 12:31:43PM +0800, Shimmer Huang wrote: > Sarah, > > This patch works for me. Would you please help submit and merge this patch ? Yep, I'll get it merged shortly. It will be marked for stable kernels, so it should make it into the Linux distribution kernels as well. Sarah

Re: Endpoint is not halted

2012-10-31 Thread Sarah Sharp
On Wed, Oct 31, 2012 at 07:33:17PM +0530, Bhavik Kothari wrote: > Hi Sarah, > > Thanks Sarah, for your TD-size patch. > > We have tried with your given driver. > At first time, USB device gets successfully mounted, however after removing > USB device, once again if we insert the USB device, it do

Re: Endpoint is not halted

2012-10-30 Thread Shimmer Huang
Sarah, This patch works for me. Would you please help submit and merge this patch ? On Sat, Oct 27, 2012 at 1:51 AM, Sarah Sharp wrote: > On Fri, Oct 26, 2012 at 02:50:20PM +0800, Shimmer Huang wrote: >> Sarah, >> >> We've found the TD_size issue when developing a new XHCI host controller >> al

Re: Endpoint is not halted

2012-10-26 Thread Sarah Sharp
On Fri, Oct 26, 2012 at 02:50:20PM +0800, Shimmer Huang wrote: > Sarah, > > We've found the TD_size issue when developing a new XHCI host controller also: > 1. need fix xhci_td_remainder() and xhci_v1_0_td_remainder() What needed to be fixed in xhci_td_remainder()? > 2. we need to use DIV_ROUND

Re: Endpoint is not halted

2012-10-26 Thread Sarah Sharp
On Fri, Oct 26, 2012 at 10:45:56AM +0530, Chintan Mehta wrote: > Hi Sarah, > > Thanks for the patch, I will try this out and let you know the results. > > One thing I am curios about, will this same patch apply to windows > driver/Compliance Verification Suite as well? > > If this also applies t

Re: Endpoint is not halted

2012-10-25 Thread Shimmer Huang
Sarah, We've found the TD_size issue when developing a new XHCI host controller also: 1. need fix xhci_td_remainder() and xhci_v1_0_td_remainder() 2. we need to use DIV_ROUND_UP() instead of roundup() when we calculating total_packet_count . As in recent kernel versions, roundup() is defined as f

Re: Endpoint is not halted

2012-10-25 Thread Sarah Sharp
Hi Chintan, I think I have a fix for the TD size issue. Can you install a custom kernel and test it out on your host controller? The directions for building a custom kernel are here: http://kernelnewbies.org/KernelBuild Instead of running any of the commands in "Which kernel to build?"

Re: Endpoint is not halted

2012-10-25 Thread Sarah Sharp
Going back over your example, it does look there is a couple bugs in the Linux xHCI TD size calculations. Notes are below, I'll send you a patch to test out on your host controller shortly. Thanks for catching this! Sarah Sharp On Thu, Oct 25, 2012 at 02:24:04PM -0700, Sarah Sharp wrote: > On F

Re: Endpoint is not halted

2012-10-25 Thread Sarah Sharp
Ah, ok, I thought your host was a 0.96 host. I see that the xHCI driver does handle the TD size field differently, based on whether the host is a 1.0 host or not (see xhci_td_remainder and xhci_v1_0_td_remainder). I'll have to take a look at that code again to see if it's compliant with the xHCI 1

Re: Endpoint is not halted

2012-10-18 Thread Sarah Sharp
Since you both seem to be asking the same question: On Wed, Oct 17, 2012 at 10:34:39AM +0530, ankit patel wrote: > Thanks Sarah, >I just need to know that driver is doing reset when device is not > attached by writing HCRST to 1 in USB Command Register of xHC. Does > the host controller needs

Re: Endpoint is not halted

2012-10-15 Thread Sarah Sharp
On Mon, Oct 15, 2012 at 11:28:34AM +0530, ankit patel wrote: > Hi Sarah, Hi Ankit, thanks for the bug report. >We have found some problems during inserting device. It shows the error > like > >- [ 85.694152] xhci_hcd :01:00.0: Endpoint 0x84 not halted, >refusing to reset.