Re: BUG: USB audio discontinuities with 'UHCI: implement new semantics for URB_ISO_ASAP'

2013-05-09 Thread Alan Stern
On Wed, 8 May 2013, Joe Rayhawk wrote: > For what it's worth, the following -stable patch > > "ALSA: USB: adjust for changed 3.8 USB API" > c75c5ab575af7db707689cdbb5a5c458e9a034bb > > fixes the discontinuous playback on period sizes between 139 and 192, > but the discontinuous playback on perio

Re: BUG: USB audio discontinuities with 'UHCI: implement new semantics for URB_ISO_ASAP'

2013-05-08 Thread Joe Rayhawk
On Tue, Apr 23, 2013 at 05:09:35PM +0200, Clemens Ladisch wrote: > Alan Stern wrote: > > On Tue, 23 Apr 2013, Clemens Ladisch wrote: > >> Why is having a queue of two URB with one packet each suddenly not > >> allowed? > > > > It _is_ allowed when URB_ISO_ASAP is clear. I have never fully > > unde

Re: BUG: USB audio discontinuities with 'UHCI: implement new semantics for URB_ISO_ASAP'

2013-04-27 Thread Clemens Ladisch
Alan Stern wrote: > It is now unnecessary to set urb->start_frame; in fact that field is > now output-only. > > (To be fair, I haven't checked _all_ the HCDs in this regard, just > uhci-hcd, ohci-hcd, and ehci-hcd. However, if any other HCD requires > urb->start_frame to be set then that HCD shoul

Re: BUG: USB audio discontinuities with 'UHCI: implement new semantics for URB_ISO_ASAP'

2013-04-23 Thread Alan Stern
On Tue, 23 Apr 2013, Clemens Ladisch wrote: > Alan Stern wrote: > > On Tue, 23 Apr 2013, Clemens Ladisch wrote: > >> Why is having a queue of two URB with one packet each suddenly not > >> allowed? > > > > It _is_ allowed when URB_ISO_ASAP is clear. I have never fully > > understood why the audio

Re: BUG: USB audio discontinuities with 'UHCI: implement new semantics for URB_ISO_ASAP'

2013-04-23 Thread Clemens Ladisch
Alan Stern wrote: > On Tue, 23 Apr 2013, Clemens Ladisch wrote: >> Why is having a queue of two URB with one packet each suddenly not >> allowed? > > It _is_ allowed when URB_ISO_ASAP is clear. I have never fully > understood why the audio driver sets that flag. By setting it, you are > telling t

Re: BUG: USB audio discontinuities with 'UHCI: implement new semantics for URB_ISO_ASAP'

2013-04-23 Thread Alan Stern
On Tue, 23 Apr 2013, Clemens Ladisch wrote: > Alan Stern wrote: > > On Fri, 19 Apr 2013, Joe Rayhawk wrote: > >> On Fri, Apr 19, 2013 at 02:18:24PM -0400, Alan Stern wrote: > >>> On Fri, 19 Apr 2013, Clemens Ladisch wrote: > Alan Stern wrote: > > + next = uhci->frame_number

Re: BUG: USB audio discontinuities with 'UHCI: implement new semantics for URB_ISO_ASAP'

2013-04-23 Thread Clemens Ladisch
Alan Stern wrote: > On Fri, 19 Apr 2013, Joe Rayhawk wrote: >> On Fri, Apr 19, 2013 at 02:18:24PM -0400, Alan Stern wrote: >>> On Fri, 19 Apr 2013, Clemens Ladisch wrote: Alan Stern wrote: > + next = uhci->frame_number + 2; > > That 2 is the minimum latency, in frames (one

Re: BUG: USB audio discontinuities with 'UHCI: implement new semantics for URB_ISO_ASAP'

2013-04-22 Thread Alan Stern
On Fri, 19 Apr 2013, Joe Rayhawk wrote: > On Fri, Apr 19, 2013 at 02:18:24PM -0400, Alan Stern wrote: > > On Fri, 19 Apr 2013, Clemens Ladisch wrote: > > > Alan Stern wrote: > > > > + next = uhci->frame_number + 2; > > > > > > > > That 2 is the minimum latency, in frames (one frame p

Re: BUG: USB audio discontinuities with 'UHCI: implement new semantics for URB_ISO_ASAP'

2013-04-19 Thread Joe Rayhawk
On Fri, Apr 19, 2013 at 02:18:24PM -0400, Alan Stern wrote: > On Fri, 19 Apr 2013, Clemens Ladisch wrote: > > Alan Stern wrote: > > > + next = uhci->frame_number + 2; > > > > > > That 2 is the minimum latency, in frames (one frame per ms). > > > > One frame worked fine with the old driver.

Re: BUG: USB audio discontinuities with 'UHCI: implement new semantics for URB_ISO_ASAP'

2013-04-19 Thread Alan Stern
On Fri, 19 Apr 2013, Clemens Ladisch wrote: > Alan Stern wrote: > > ... > > This trace shows that the frame numbers do not increase sequentially: > > 1057125, 1057126, 1057128, 1057129, 1053131, ... This is because the > > new driver is a little more conservative than the old driver, > > requirin

Re: BUG: USB audio discontinuities with 'UHCI: implement new semantics for URB_ISO_ASAP'

2013-04-19 Thread Clemens Ladisch
Alan Stern wrote: > ... > This trace shows that the frame numbers do not increase sequentially: > 1057125, 1057126, 1057128, 1057129, 1053131, ... This is because the > new driver is a little more conservative than the old driver, > requiring latencies to be larger than 1 ms. You can see this > e

Re: BUG: USB audio discontinuities with 'UHCI: implement new semantics for URB_ISO_ASAP'

2013-04-19 Thread Alan Stern
On Thu, 18 Apr 2013, Joe Rayhawk wrote: > On Thu, Apr 18, 2013 at 12:42:00PM -0400, Alan Stern wrote: > > On Wed, 17 Apr 2013, Joe Rayhawk wrote: > > > Small buffer/period sizes on usb audio playback though UHCI works fine on > > > v3.7 but causes audio discontinuities/delays on v3.8 and v3.9-rc7

Re: BUG: USB audio discontinuities with 'UHCI: implement new semantics for URB_ISO_ASAP'

2013-04-18 Thread Joe Rayhawk
On Thu, Apr 18, 2013 at 12:42:00PM -0400, Alan Stern wrote: > On Wed, 17 Apr 2013, Joe Rayhawk wrote: > > Small buffer/period sizes on usb audio playback though UHCI works fine on > > v3.7 but causes audio discontinuities/delays on v3.8 and v3.9-rc7. > > Can you provide a usbmon trace showing the

Re: BUG: USB audio discontinuities with 'UHCI: implement new semantics for URB_ISO_ASAP'

2013-04-18 Thread Alan Stern
On Wed, 17 Apr 2013, Joe Rayhawk wrote: > Small buffer/period sizes on usb audio playback though UHCI works fine on > v3.7 but causes audio discontinuities/delays on v3.8 and v3.9-rc7. > > I've bisected the behavior down to > > c44b225077bb1fb25ed5cd5c4f226897b91bedd4 > 'UHCI: implement

BUG: USB audio discontinuities with 'UHCI: implement new semantics for URB_ISO_ASAP'

2013-04-17 Thread Joe Rayhawk
Small buffer/period sizes on usb audio playback though UHCI works fine on v3.7 but causes audio discontinuities/delays on v3.8 and v3.9-rc7. I've bisected the behavior down to c44b225077bb1fb25ed5cd5c4f226897b91bedd4 'UHCI: implement new semantics for URB_ISO_ASAP' Tested on two UHCI ho