Re: [patch v2] usb: phy: msm: change devm_ioremap() to devm_ioremap_resource()

2014-05-19 Thread Dan Carpenter
On Mon, May 19, 2014 at 12:19:10PM +0300, Ivan T. Ivanov wrote: > On Wed, 2014-05-14 at 16:54 +0300, Dan Carpenter wrote: > > There are several issues here: > > 1) platform_get_resource() can return NULL and that wasn't handled. > > 2) We should request the memory before we remap it, and > >dev

Re: [patch v2] usb: phy: msm: change devm_ioremap() to devm_ioremap_resource()

2014-05-19 Thread Ivan T. Ivanov
On Wed, 2014-05-14 at 16:54 +0300, Dan Carpenter wrote: > There are several issues here: > 1) platform_get_resource() can return NULL and that wasn't handled. > 2) We should request the memory before we remap it, and >devm_ioremap_resource() does that. > 3) devm_ioremap() returns a NULL but we

[patch v2] usb: phy: msm: change devm_ioremap() to devm_ioremap_resource()

2014-05-14 Thread Dan Carpenter
There are several issues here: 1) platform_get_resource() can return NULL and that wasn't handled. 2) We should request the memory before we remap it, and devm_ioremap_resource() does that. 3) devm_ioremap() returns a NULL but we were checking for IS_ERR(). Fixes: 6b99c68ec1f9 ('usb: phy: msm: