Re: [patch v2] usb: f_fs: off by one bug in _ffs_func_bind()

2016-05-28 Thread Michal Nazarewicz
On Sat, May 28 2016, Dan Carpenter wrote: > This loop is supposed to set all the .num[] values to -1 but it's off by > one so it skips the first element and sets one element past the end of > the array. > > I've cleaned up the loop a little as well. > > Fixes: ddf8abd25994 ('USB: f_fs: the Function

Re: [patch v2] usb: f_fs: off by one bug in _ffs_func_bind()

2016-05-28 Thread walter harms
much better readable than the original. nice work re, wh Am 28.05.2016 06:48, schrieb Dan Carpenter: > This loop is supposed to set all the .num[] values to -1 but it's off by > one so it skips the first element and sets one element past the end of > the array. > > I've cleaned up the loop a li

[patch v2] usb: f_fs: off by one bug in _ffs_func_bind()

2016-05-27 Thread Dan Carpenter
This loop is supposed to set all the .num[] values to -1 but it's off by one so it skips the first element and sets one element past the end of the array. I've cleaned up the loop a little as well. Fixes: ddf8abd25994 ('USB: f_fs: the FunctionFS driver') Signed-off-by: Dan Carpenter --- v2: move