Re: [patch net-next 3/5] ipv6: consider net.ipv6.conf.all sysctls when making decisions

2014-06-12 Thread Milos Vyletel
David, my words may have been poorly chosen. Last thing I want is to break things... What I meant to say is that this changes the behavior of conf.all.* sysctls from no-op to be part of decision along with interface specific ones. Default settings still work the same way unless conf.all.* was man

Re: [patch net-next 3/5] ipv6: consider net.ipv6.conf.all sysctls when making decisions

2014-06-11 Thread David Miller
From: Milos Vyletel Date: Tue, 10 Jun 2014 13:49:35 -0400 > On Tue, Jun 10, 2014 at 1:13 PM, Stephen Hemminger > wrote: >> On Tue, 10 Jun 2014 12:19:11 -0400 >> Milos Vyletel wrote: >> >>> As it is right now net.ipv6.conf.all.* are mostly ignored and instead >>> we're only making decisions base

Re: [patch net-next 3/5] ipv6: consider net.ipv6.conf.all sysctls when making decisions

2014-06-10 Thread Milos Vyletel
On Tue, Jun 10, 2014 at 1:13 PM, Stephen Hemminger wrote: > On Tue, 10 Jun 2014 12:19:11 -0400 > Milos Vyletel wrote: > >> As it is right now net.ipv6.conf.all.* are mostly ignored and instead >> we're only making decisions based on interface specific settings. These >> settings are coppied from

Re: [patch net-next 3/5] ipv6: consider net.ipv6.conf.all sysctls when making decisions

2014-06-10 Thread Milos Vyletel
> Hello, > >> >> IN6_DEV_MAXCONF >> IN6_DEV_HOPLIMIT >> IN6_DEV_MTU > > I'm a little bit surprise to set the MTU as the maximum of all/dev > value. Since the default for "all" is IPV6_MIN_MTU, it is probably > harmless, but it could be a little bit surprising for administrators. > >> I

Re: [patch net-next 3/5] ipv6: consider net.ipv6.conf.all sysctls when making decisions

2014-06-10 Thread Florent Fourcot
Hello, > > IN6_DEV_MAXCONF > IN6_DEV_HOPLIMIT > IN6_DEV_MTU I'm a little bit surprise to set the MTU as the maximum of all/dev value. Since the default for "all" is IPV6_MIN_MTU, it is probably harmless, but it could be a little bit surprising for administrators. > IN6_DEV_USE_TEMP

Re: [patch net-next 3/5] ipv6: consider net.ipv6.conf.all sysctls when making decisions

2014-06-10 Thread Stephen Hemminger
On Tue, 10 Jun 2014 12:19:11 -0400 Milos Vyletel wrote: > As it is right now net.ipv6.conf.all.* are mostly ignored and instead > we're only making decisions based on interface specific settings. These > settings are coppied from net.ipv6.conf.default and changing either all > or default settings