Am Dienstag, 12. Februar 2008 18:49:14 schrieb Greg KH:
> On Tue, Feb 12, 2008 at 06:23:13PM +0100, Oliver Neukum wrote:
> > Am Dienstag, 12. Februar 2008 17:05:25 schrieb Greg KH:
> > > Heh, I haven't even posted this driver for review yet, nice catches :)
> >
> > While we are at that. In close()
On Tue, Feb 12, 2008 at 06:23:13PM +0100, Oliver Neukum wrote:
> Am Dienstag, 12. Februar 2008 17:05:25 schrieb Greg KH:
> > Heh, I haven't even posted this driver for review yet, nice catches :)
>
> While we are at that. In close() you take extreme pains to kill all URBs?
> What for? You don't do
Am Dienstag, 12. Februar 2008 17:05:25 schrieb Greg KH:
> Heh, I haven't even posted this driver for review yet, nice catches :)
While we are at that. In close() you take extreme pains to kill all URBs?
What for? You don't do error reporting anyway.
Regards
Oliver
-
To un
Am Dienstag, 12. Februar 2008 17:05:25 schrieb Greg KH:
> On Tue, Feb 12, 2008 at 04:04:50PM +0100, Oliver Neukum wrote:
> > Hi,
> >
> > - use kzalloc
> > - no GFP_KERNEL in interrupt
> > - kfree can take NULL
> >
> > Signed-off-by: Oliver Neukum <[EMAIL PROTECTED]>
>
> Heh, I haven't even poste
On Tue, Feb 12, 2008 at 04:04:50PM +0100, Oliver Neukum wrote:
> Hi,
>
> - use kzalloc
> - no GFP_KERNEL in interrupt
> - kfree can take NULL
>
> Signed-off-by: Oliver Neukum <[EMAIL PROTECTED]>
Heh, I haven't even posted this driver for review yet, nice catches :)
Mind if I just merge these in
Hi,
- use kzalloc
- no GFP_KERNEL in interrupt
- kfree can take NULL
Signed-off-by: Oliver Neukum <[EMAIL PROTECTED]>
Regards
Oliver
--- linux-2.6/drivers/usb/serial/spcp8x5.c.alt 2008-02-12 14:53:25.0
+0100
+++ linux-2.6/drivers/usb/serial/spcp8x5.c
