Re: [patch] USB: make hcd->irq signed for error handling

2013-11-07 Thread Alan Stern
On Thu, 7 Nov 2013, Dan Carpenter wrote: > There is a bug in ehci_msm_probe() where we do: > > hcd->irq = platform_get_irq(pdev, 0); > if (hcd->irq < 0) { > > The problem is that hcd->irq is unsigned so the error handling doesn't > work. I have made it signed. > > Signed-off-by: Da

[patch] USB: make hcd->irq signed for error handling

2013-11-06 Thread Dan Carpenter
There is a bug in ehci_msm_probe() where we do: hcd->irq = platform_get_irq(pdev, 0); if (hcd->irq < 0) { The problem is that hcd->irq is unsigned so the error handling doesn't work. I have made it signed. Signed-off-by: Dan Carpenter diff --git a/include/linux/usb/hcd.h b/inc