Re: [alsa-devel] [PATCH] usb: add USB_QUIRK_RESET_RESUME for M-Audio 49

2012-11-26 Thread Alan Stern
On Mon, 26 Nov 2012, Clemens Ladisch wrote: > Alan Stern wrote: > > On Mon, 26 Nov 2012, Oliver Neukum wrote: > >> On Monday 26 November 2012 14:43:13 Clemens Ladisch wrote: > >>> usb_autopm_get_interface() cannot be called from the USB probe callback. > >> > >> You can use usb_autopm_get_interfac

Re: [alsa-devel] [PATCH] usb: add USB_QUIRK_RESET_RESUME for M-Audio 49

2012-11-26 Thread Clemens Ladisch
Alan Stern wrote: > On Mon, 26 Nov 2012, Oliver Neukum wrote: >> On Monday 26 November 2012 14:43:13 Clemens Ladisch wrote: >>> usb_autopm_get_interface() cannot be called from the USB probe callback. >> >> You can use usb_autopm_get_interface_no_resume() >> During probe() the device is known to no

Re: [alsa-devel] [PATCH] usb: add USB_QUIRK_RESET_RESUME for M-Audio 49

2012-11-26 Thread Alan Stern
On Mon, 26 Nov 2012, Oliver Neukum wrote: > On Monday 26 November 2012 14:43:13 Clemens Ladisch wrote: > > > > If it has to be running, the easiest fix would be the patch like > > > below. This will turn off the autopm essentially, but better than > > > breakage. > > > > > > @@ -2074,6 +2077,8 @

Re: [alsa-devel] [PATCH] usb: add USB_QUIRK_RESET_RESUME for M-Audio 49

2012-11-26 Thread Takashi Iwai
At Mon, 26 Nov 2012 14:43:13 +0100, Clemens Ladisch wrote: > > Takashi Iwai wrote: > > Clemens Ladisch wrote: > >> Takashi Iwai wrote: > >>> Clemens Ladisch wrote: > I'm working on a fix that adds proper power management for input ports, > but this requires the driver to be reorganized a

Re: [alsa-devel] [PATCH] usb: add USB_QUIRK_RESET_RESUME for M-Audio 49

2012-11-26 Thread Oliver Neukum
On Monday 26 November 2012 14:43:13 Clemens Ladisch wrote: > > If it has to be running, the easiest fix would be the patch like > > below. This will turn off the autopm essentially, but better than > > breakage. > > > > @@ -2074,6 +2077,8 @@ static void snd_usbmidi_input_start_ep(struct > > snd_

Re: [alsa-devel] [PATCH] usb: add USB_QUIRK_RESET_RESUME for M-Audio 49

2012-11-26 Thread Clemens Ladisch
Takashi Iwai wrote: > Clemens Ladisch wrote: >> Takashi Iwai wrote: >>> Clemens Ladisch wrote: I'm working on a fix that adds proper power management for input ports, but this requires the driver to be reorganized a little ... >>> >>> Doesn't a simple patch like below work? >> >>> +static

Re: [alsa-devel] [PATCH] usb: add USB_QUIRK_RESET_RESUME for M-Audio 49

2012-11-26 Thread Takashi Iwai
At Mon, 26 Nov 2012 13:35:31 +0100, Clemens Ladisch wrote: > > Takashi Iwai wrote:> At Sun, 25 Nov 2012 23:01:27 +0100, > > Clemens Ladisch wrote: > >> > >> Jonathan Nieder wrote: > >>> Some USB MIDI keyboards fail to operate after a USB autosuspend. > >> > >> Make that *all* USB MIDI devices with

Re: [alsa-devel] [PATCH] usb: add USB_QUIRK_RESET_RESUME for M-Audio 49

2012-11-26 Thread Clemens Ladisch
Takashi Iwai wrote:> At Sun, 25 Nov 2012 23:01:27 +0100, > Clemens Ladisch wrote: >> >> Jonathan Nieder wrote: >>> Some USB MIDI keyboards fail to operate after a USB autosuspend. >> >> Make that *all* USB MIDI devices with input ports. >> >> This is not a bug in the device, but one of the many bug

Re: [alsa-devel] [PATCH] usb: add USB_QUIRK_RESET_RESUME for M-Audio 49

2012-11-26 Thread Takashi Iwai
At Sun, 25 Nov 2012 23:01:27 +0100, Clemens Ladisch wrote: > > Jonathan Nieder wrote: > > Some USB MIDI keyboards fail to operate after a USB autosuspend. > > Make that *all* USB MIDI devices with input ports. > > This is not a bug in the device, but one of the many bugs introduced > with the au

Re: [alsa-devel] [PATCH] usb: add USB_QUIRK_RESET_RESUME for M-Audio 49

2012-11-25 Thread Clemens Ladisch
Jonathan Nieder wrote: > Some USB MIDI keyboards fail to operate after a USB autosuspend. Make that *all* USB MIDI devices with input ports. This is not a bug in the device, but one of the many bugs introduced with the autosuspend code in . That patch do