Re: [TESTPATCH] xhci: usb2 hw lpm extra debug

2016-06-16 Thread Christian M . Amsüss
Hello Mathias, On Thu, Jun 16, 2016 at 01:26:25PM +0300, Mathias Nyman wrote: > This should be fixed with patch: > > commit 27a41a83ec54d0edfcaf079310244e7f013a7701 > xhci: Cleanup only when releasing primary hcd > > which is only in Gregs usb-linus branch, but should end up in Linus tree so

Re: [TESTPATCH] xhci: usb2 hw lpm extra debug

2016-06-15 Thread Christian M . Amsüss
On Wed, Jun 15, 2016 at 05:43:56PM +0200, chrysn wrote: > Reviewing the patches, that was because the invalid port_num is used in > `readl(pm_addr)` already, too early for your `portnum %d > > num_usb2_ports` debug line. I'm shoving the line up to make it out > before the segfault, and will report

Re: [TESTPATCH] xhci: usb2 hw lpm extra debug

2016-06-15 Thread Christian M . Amsüss
On Wed, Jun 15, 2016 at 05:32:11PM +0200, chrysn wrote: > I've only spotted one of your debug statements in the resulting dmesg > ("USB2 LPM capable set, port 4 speed 2"), which confuses me, given that > at least the `portnum %d > num_usb2_ports` line should have shown up > (the equivalent debug st

Re: [TESTPATCH] xhci: usb2 hw lpm extra debug

2016-06-15 Thread Christian M . Amsüss
Hi, On Wed, Jun 15, 2016 at 01:56:57PM +0300, Mathias Nyman wrote: > custom testpatch to show more info about touching usb2 hw lpm > setting for usb3 devices Applied, built, booted and hit the oops; most interestingly, the crashes these days don't get me into the kdump kernel anymore (might be a

[TESTPATCH] xhci: usb2 hw lpm extra debug

2016-06-15 Thread Mathias Nyman
custom testpatch to show more info about touching usb2 hw lpm setting for usb3 devices not for upstream, just testing Signed-off-by: Mathias Nyman --- drivers/usb/core/hub.c | 32 +--- drivers/usb/host/xhci.c | 11 +++ 2 files changed, 36 insertions(+), 7 de