Re: [RFCv4 PATCH 01/13] usb: composite: add make_group and add_function operations

2012-11-23 Thread 'Greg Kroah-Hartman'
rasiewicz; linux-usb@vger.kernel.org; 'Kyungmin Park'; > > 'Felipe Balbi'; 'Greg Kroah-Hartman'; 'Joel Becker'; Marek Szyprowski > > Subject: Re: [RFCv4 PATCH 01/13] usb: composite: add make_group and > > add_function operations > > >

RE: [RFCv4 PATCH 01/13] usb: composite: add make_group and add_function operations

2012-11-23 Thread Kyungmin Park
'Michal Nazarewicz' > Cc: 'Andrzej Pietrasiewicz'; 'linux-usb@vger.kernel.org'; 'Felipe Balbi'; > 'Greg Kroah-Hartman'; 'Joel Becker'; 'Marek Szyprowski' > Subject: RE: [RFCv4 PATCH 01/13] usb: composite: add make_gro

RE: [RFCv4 PATCH 01/13] usb: composite: add make_group and add_function operations

2012-11-23 Thread Kyungmin Park
7;Greg Kroah-Hartman'; 'Joel Becker'; Marek Szyprowski > Subject: Re: [RFCv4 PATCH 01/13] usb: composite: add make_group and > add_function operations > > On 11/22/2012 09:48 PM, Michal Nazarewicz wrote: > > I think neither is correct. The reviewed-by tag imp

Re: [RFCv4 PATCH 01/13] usb: composite: add make_group and add_function operations

2012-11-23 Thread Sebastian Andrzej Siewior
On 11/22/2012 09:48 PM, Michal Nazarewicz wrote: I think neither is correct. The reviewed-by tag implies that the person did a careful review of the code as per “Reviewer's statement of oversight” (see Documentation/SubmittingPatches). What actually happens is Kyungmin giving a green light to s

RE: [RFCv4 PATCH 01/13] usb: composite: add make_group and add_function operations

2012-11-23 Thread Andrzej Pietrasiewicz
On Thursday, November 22, 2012 3:55 PM Sebastian Andrzej Siewior wrote: > * Andrzej Pietrasiewicz | 2012-11-22 13:06:55 [+0100]: > > >diff --git a/include/linux/usb/composite.h > b/include/linux/usb/composite.h > >index e84c754..5bac1f8 100644 > >--- a/include/linux/usb/composite.h > >+++ b/inc

RE: [RFCv4 PATCH 01/13] usb: composite: add make_group and add_function operations

2012-11-22 Thread Michal Nazarewicz
> * Andrzej Pietrasiewicz | 2012-11-22 13:06:55 [+0100]: >> Using configfs to create/configure a usb gadget requires >> providing a method to create config group for a usb function >> and a wrapper for usb_add_function. >> >> Signed-off-by: Andrzej Pietrasiewicz >> Signed-off-by: Kyungmin Park O

[RFCv4 PATCH 01/13] usb: composite: add make_group and add_function operations

2012-11-22 Thread Andrzej Pietrasiewicz
Using configfs to create/configure a usb gadget requires providing a method to create config group for a usb function and a wrapper for usb_add_function. Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park --- include/linux/usb/composite.h |6 ++ 1 files changed, 6 inserti

RE: [RFCv4 PATCH 01/13] usb: composite: add make_group and add_function operations

2012-11-22 Thread Andrzej Pietrasiewicz
On Thursday, November 22, 2012 3:55 PM Sebastian Andrzej Siewior wrote: > * Andrzej Pietrasiewicz | 2012-11-22 13:06:55 [+0100]: > > >Using configfs to create/configure a usb gadget requires > >providing a method to create config group for a usb function > >and a wrapper for usb_add_function. > >

Re: [RFCv4 PATCH 01/13] usb: composite: add make_group and add_function operations

2012-11-22 Thread Sebastian Andrzej Siewior
* Andrzej Pietrasiewicz | 2012-11-22 13:06:55 [+0100]: >Using configfs to create/configure a usb gadget requires >providing a method to create config group for a usb function >and a wrapper for usb_add_function. > >Signed-off-by: Andrzej Pietrasiewicz >Signed-off-by: Kyungmin Park Just a side n