Re: [RFC v3 03/18] xhci: refactor TRB_ENABLE_SLOT case into function

2013-08-30 Thread Sarah Sharp
On Sun, Aug 25, 2013 at 02:25:54AM +0300, Xenia Ragiadakou wrote: > On 08/25/2013 12:48 AM, Oliver Neukum wrote: > >On Fri, 2013-08-23 at 11:15 +0300, Xenia Ragiadakou wrote: > >>This patch refactors the code in TRB_ENABLE_SLOT switch case in > >>handle_cmd_completion() into a fuction named xhci_ha

Re: [RFC v3 03/18] xhci: refactor TRB_ENABLE_SLOT case into function

2013-08-24 Thread Xenia Ragiadakou
On 08/25/2013 12:48 AM, Oliver Neukum wrote: On Fri, 2013-08-23 at 11:15 +0300, Xenia Ragiadakou wrote: This patch refactors the code in TRB_ENABLE_SLOT switch case in handle_cmd_completion() into a fuction named xhci_handle_cmd_enable_slot(). Hi, it would be nice, in fact probably a requireme

Re: [RFC v3 03/18] xhci: refactor TRB_ENABLE_SLOT case into function

2013-08-24 Thread Oliver Neukum
On Fri, 2013-08-23 at 11:15 +0300, Xenia Ragiadakou wrote: > This patch refactors the code in TRB_ENABLE_SLOT switch case in > handle_cmd_completion() into a fuction named xhci_handle_cmd_enable_slot(). Hi, it would be nice, in fact probably a requirement, for the commit message to explain what t

[RFC v3 03/18] xhci: refactor TRB_ENABLE_SLOT case into function

2013-08-23 Thread Xenia Ragiadakou
This patch refactors the code in TRB_ENABLE_SLOT switch case in handle_cmd_completion() into a fuction named xhci_handle_cmd_enable_slot(). Signed-off-by: Xenia Ragiadakou --- drivers/usb/host/xhci-ring.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/driv