Re: [RFC v3] xhci-hub: Roothub USB2.0 descriptor for BESL DBESL

2013-08-14 Thread Alexandra Yates
Paul, Thank you for catching the bug. Sarah, Thank you for the detailed description and explanation on the changes. I will send the patch shortly with the updated changes and test. Alexandra. > On Sat, Aug 10, 2013 at 04:04:02AM +, Paul Zimmerman wrote: >> > From: linux-usb-ow...@vger.kerne

Re: [RFC v3] xhci-hub: Roothub USB2.0 descriptor for BESL DBESL

2013-08-13 Thread Sarah Sharp
On Sat, Aug 10, 2013 at 04:04:02AM +, Paul Zimmerman wrote: > > From: linux-usb-ow...@vger.kernel.org > > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Alexandra Yates > > Sent: Friday, August 09, 2013 12:21 PM > > Hi Alexandra, > > > > > > > +/* USB 2.0 BOS descriptor and a capab

RE: [RFC v3] xhci-hub: Roothub USB2.0 descriptor for BESL DBESL

2013-08-09 Thread Paul Zimmerman
> From: linux-usb-ow...@vger.kernel.org > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Alexandra Yates > Sent: Friday, August 09, 2013 12:21 PM Hi Alexandra, > > +/* USB 2.0 BOS descriptor and a capability descriptor, combined */ > +static u8 usb2_bos_descriptor[] = { > + USB_DT_

RE: [RFC v3] xhci-hub: Roothub USB2.0 descriptor for BESL DBESL

2013-08-09 Thread Yates, Alexandra
...@linuxfoundation.org; linux-usb@vger.kernel.org Subject: Re: [RFC v3] xhci-hub: Roothub USB2.0 descriptor for BESL DBESL Hi Alex, Can you make sure to add the checkpatch.pl to your git pre-commit hooks? This patch fails checkpatch: sarah@xanatos:~/git/kernels/xhci$ git am -s

Re: [RFC v3] xhci-hub: Roothub USB2.0 descriptor for BESL DBESL

2013-08-09 Thread Sarah Sharp
n Behalf Of Sarah Sharp > Sent: Friday, August 09, 2013 1:03 PM > To: Alexandra Yates > Cc: gre...@linuxfoundation.org; linux-usb@vger.kernel.org > Subject: Re: [RFC v3] xhci-hub: Roothub USB2.0 descriptor for BESL DBESL > > Hi Alex, > > For just one patch, you don't n

RE: [RFC v3] xhci-hub: Roothub USB2.0 descriptor for BESL DBESL

2013-08-09 Thread Yates, Alexandra
: Alexandra Yates Cc: gre...@linuxfoundation.org; linux-usb@vger.kernel.org Subject: Re: [RFC v3] xhci-hub: Roothub USB2.0 descriptor for BESL DBESL Hi Alex, For just one patch, you don't need to send a cover letter, especially when it contains the contents of your patch description. Also, pleas

Re: [RFC v3] xhci-hub: Roothub USB2.0 descriptor for BESL DBESL

2013-08-09 Thread Sarah Sharp
Hi Alex, For just one patch, you don't need to send a cover letter, especially when it contains the contents of your patch description. Also, please use PATCH instead of RFC in the future. I'll test this patch out, and try to come up with a way to get the USB core to use bcdUSB 2.10 for xHCI USB

[RFC v3] xhci-hub: Roothub USB2.0 descriptor for BESL DBESL

2013-08-09 Thread Alexandra Yates
Modified the xHCI roothub descriptor to return USB2.0 extension descriptor Best Effort Service Latency (BESL) and Deep Best Effort Service Latency (DBESL) values when set on the xHCI host. On link power management the BESL and DBESL values are used to estimate L1 exit latency for USB2.0 host and d

[RFC v3] xhci-hub: Roothub USB2.0 descriptor for BESL DBESL

2013-08-09 Thread Alexandra Yates
Modified the xHCI roothub descriptor to return USB2.0 extension descriptor Best Effort Service Latency (BESL) and Deep Best Effort Service Latency (DBESL) values when set on the xHCI host. On link power management the BESL and DBESL values are used to estimate L1 exit latency for USB2.0 host and d