Re: [RFC v3] xhci: fix dma mask setup in xhci.c

2013-07-10 Thread Felipe Balbi
Hi, On Tue, Jul 09, 2013 at 02:43:45PM -0700, Sarah Sharp wrote: > On Tue, Jul 09, 2013 at 02:59:38PM +0300, Felipe Balbi wrote: > > Hi, > > > > On Mon, Jul 08, 2013 at 09:55:15PM -0700, Sarah Sharp wrote: > > > Felipe, Andy, and Seb, I have a couple questions below. > > > > > > On Fri, Jul 05,

Re: [RFC v3] xhci: fix dma mask setup in xhci.c

2013-07-09 Thread Xenia Ragiadakou
On 07/10/2013 12:45 AM, Sarah Sharp wrote: On Tue, Jul 09, 2013 at 10:23:46AM -0400, Alan Stern wrote: On Tue, 9 Jul 2013, Felipe Balbi wrote: On Mon, Jul 08, 2013 at 09:55:15PM -0700, Sarah Sharp wrote: As far as I can tell, that means the setup packet for control transfers doesn't actually g

Re: [RFC v3] xhci: fix dma mask setup in xhci.c

2013-07-09 Thread Sarah Sharp
On Tue, Jul 09, 2013 at 10:23:46AM -0400, Alan Stern wrote: > On Tue, 9 Jul 2013, Felipe Balbi wrote: > > On Mon, Jul 08, 2013 at 09:55:15PM -0700, Sarah Sharp wrote: > > > As far as I can tell, that means the setup packet for control transfers > > > doesn't actually get mapped for DMA currently.

Re: [RFC v3] xhci: fix dma mask setup in xhci.c

2013-07-09 Thread Sarah Sharp
On Tue, Jul 09, 2013 at 02:59:38PM +0300, Felipe Balbi wrote: > Hi, > > On Mon, Jul 08, 2013 at 09:55:15PM -0700, Sarah Sharp wrote: > > Felipe, Andy, and Seb, I have a couple questions below. > > > > On Fri, Jul 05, 2013 at 08:24:56PM +0300, Xenia Ragiadakou wrote: > > Felipe, Andy, is there any

Re: [RFC v3] xhci: fix dma mask setup in xhci.c

2013-07-09 Thread Alan Stern
On Tue, 9 Jul 2013, Felipe Balbi wrote: > Hi, > > On Mon, Jul 08, 2013 at 09:55:15PM -0700, Sarah Sharp wrote: > > Xenia, I'm not sure what you mean by "the xHC controller and the host > > support > > 64 bit DMA addresses". The xHC controller is the xHCI host. Did you maybe > > mean "If both

Re: [RFC v3] xhci: fix dma mask setup in xhci.c

2013-07-09 Thread Sebastian Andrzej Siewior
On 07/09/2013 01:59 PM, Felipe Balbi wrote: >> Xenia, I'm not sure what you mean by "the xHC controller and the >> host support 64 bit DMA addresses". The xHC controller is the >> xHCI host. Did you maybe mean "If both the xHCI host and the >> system support 64-bit DMA"? >> >>> For non-pci plat

Re: [RFC v3] xhci: fix dma mask setup in xhci.c

2013-07-09 Thread Felipe Balbi
Hi, On Mon, Jul 08, 2013 at 09:55:15PM -0700, Sarah Sharp wrote: > Felipe, Andy, and Seb, I have a couple questions below. > > On Fri, Jul 05, 2013 at 08:24:56PM +0300, Xenia Ragiadakou wrote: > > The function dma_set_mask() tests internally whether the dma_mask pointer > > for the device is init

Re: [RFC v3] xhci: fix dma mask setup in xhci.c

2013-07-08 Thread Sarah Sharp
Felipe, Andy, and Seb, I have a couple questions below. On Fri, Jul 05, 2013 at 08:24:56PM +0300, Xenia Ragiadakou wrote: > The function dma_set_mask() tests internally whether the dma_mask pointer > for the device is initialized and fails if the dma_mask pointer is NULL. > On pci platforms, the i

[RFC v3] xhci: fix dma mask setup in xhci.c

2013-07-05 Thread Xenia Ragiadakou
The function dma_set_mask() tests internally whether the dma_mask pointer for the device is initialized and fails if the dma_mask pointer is NULL. On pci platforms, the initialization of the device dma_mask pointer is performed when pci devices are enumerated and is set to point to the pci_dev->dma