Re: [RFC v2 10/11] USB: Rip out recursive call on warm port reset.

2012-12-07 Thread Alan Stern
On Fri, 7 Dec 2012, Sarah Sharp wrote: > > > 2. It doesn't consider a connect status change to be a failed reset. If > > > multiple warm resets needed to be issued, the connect status may have > > > changed, so we need to ignore that and look at the port link state > > > instead. hub_port_reset

Re: [RFC v2 10/11] USB: Rip out recursive call on warm port reset.

2012-12-07 Thread Sarah Sharp
On Wed, Dec 05, 2012 at 02:41:11PM -0500, Alan Stern wrote: > On Tue, 4 Dec 2012, Sarah Sharp wrote: > > > When a hot reset fails on a USB 3.0 port, the current port reset code > > recursively calls hub_port_reset inside hub_port_wait_reset. This isn't > > ideal, since we should avoid recursive c

Re: [RFC v2 10/11] USB: Rip out recursive call on warm port reset.

2012-12-05 Thread Alan Stern
On Tue, 4 Dec 2012, Sarah Sharp wrote: > When a hot reset fails on a USB 3.0 port, the current port reset code > recursively calls hub_port_reset inside hub_port_wait_reset. This isn't > ideal, since we should avoid recursive calls in the kernel, and it also > doesn't allow us to issue multiple w

[RFC v2 10/11] USB: Rip out recursive call on warm port reset.

2012-12-04 Thread Sarah Sharp
When a hot reset fails on a USB 3.0 port, the current port reset code recursively calls hub_port_reset inside hub_port_wait_reset. This isn't ideal, since we should avoid recursive calls in the kernel, and it also doesn't allow us to issue multiple warm resets on reset failures. Rip out the recur