Re: [RFC ebeam PATCH v4 2/2] input: misc: New USB eBeam input driver.

2012-09-03 Thread Oliver Neukum
On Friday 24 August 2012 16:42:20 Yann Cantin wrote: > Hi, > > Le 24/08/2012 13:41, Oliver Neukum a écrit : > > On Friday 24 August 2012 11:37:45 Yann Cantin wrote: > >> Hi, > >> > >> Le 23/08/2012 09:23, Oliver Neukum a écrit : > >>> On Thursday 23 August 2012 00:11:54 Yann Cantin wrote: > > > >

Re: [RFC ebeam PATCH v4 2/2] input: misc: New USB eBeam input driver.

2012-08-24 Thread Yann Cantin
Hi, Le 24/08/2012 13:41, Oliver Neukum a écrit : > On Friday 24 August 2012 11:37:45 Yann Cantin wrote: >> Hi, >> >> Le 23/08/2012 09:23, Oliver Neukum a écrit : >>> On Thursday 23 August 2012 00:11:54 Yann Cantin wrote: > >>> These functions are identical. You should unify them. >> >> Removed re

Re: [RFC ebeam PATCH v4 2/2] input: misc: New USB eBeam input driver.

2012-08-24 Thread Oliver Neukum
On Friday 24 August 2012 11:37:45 Yann Cantin wrote: > Hi, > > Le 23/08/2012 09:23, Oliver Neukum a écrit : > > On Thursday 23 August 2012 00:11:54 Yann Cantin wrote: > > These functions are identical. You should unify them. > > Removed reset_resume from the driver (optional, and not needed > fo

Re: [RFC ebeam PATCH v4 2/2] input: misc: New USB eBeam input driver.

2012-08-24 Thread Yann Cantin
Hi, Le 23/08/2012 09:23, Oliver Neukum a écrit : > On Thursday 23 August 2012 00:11:54 Yann Cantin wrote: >> +static int ebeam_resume(struct usb_interface *intf) >> +{ >> + struct ebeam_device *ebeam = usb_get_intfdata(intf); >> + struct input_dev *input = ebeam->input; >> + int

Re: [RFC ebeam PATCH v4 2/2] input: misc: New USB eBeam input driver.

2012-08-24 Thread Yann Cantin
Hi, Le 23/08/2012 08:54, Oliver Neukum a écrit : > On Thursday 23 August 2012 00:11:54 Yann Cantin wrote: >> + /* input final setup */ >> + err = input_register_device(ebeam->input); >> + if (err) { >> + dev_dbg(&intf->dev, >> + "%s - input_reg

Re: [RFC ebeam PATCH v4 2/2] input: misc: New USB eBeam input driver.

2012-08-23 Thread Oliver Neukum
On Thursday 23 August 2012 00:11:54 Yann Cantin wrote: > +static int ebeam_resume(struct usb_interface *intf) > +{ > + struct ebeam_device *ebeam = usb_get_intfdata(intf); > + struct input_dev *input = ebeam->input; > + int result = 0; > + > + mutex_lock(&input->mutex); > +

Re: [RFC ebeam PATCH v4 2/2] input: misc: New USB eBeam input driver.

2012-08-23 Thread Oliver Neukum
On Thursday 23 August 2012 00:11:54 Yann Cantin wrote: > + /* input final setup */ > + err = input_register_device(ebeam->input); > + if (err) { > + dev_dbg(&intf->dev, > + "%s - input_register_device failed, err: %d\n", > +

[RFC ebeam PATCH v4 2/2] input: misc: New USB eBeam input driver.

2012-08-22 Thread Yann Cantin
Signed-off-by: Yann Cantin --- drivers/input/misc/Kconfig | 22 ++ drivers/input/misc/Makefile |1 + drivers/input/misc/ebeam.c | 766 +++ 3 files changed, 789 insertions(+) create mode 100644 drivers/input/misc/ebeam.c diff --git a/drivers/inpu