Re: [RFC PATCH 4/5] usb: add runtime pm support for usb port device

2012-11-12 Thread Lan Tianyu
On 2012年11月12日 10:43, Alan Stern wrote: > On Mon, 12 Nov 2012, Lan Tianyu wrote: > This will consume more power than suspend it agian. >>> >>> No it won't, because the device will suspend itself after 3 ms. >> But the premise is "they see a constant Idle state on their upstream >> faci

Re: [RFC PATCH 4/5] usb: add runtime pm support for usb port device

2012-11-11 Thread Alan Stern
On Mon, 12 Nov 2012, Lan Tianyu wrote: > >> This will consume more power than suspend it > >> agian. > > > > No it won't, because the device will suspend itself after 3 ms. > But the premise is "they see a constant Idle state on their upstream > facing bus lines for more than 3.0 ms", that mean

Re: [RFC PATCH 4/5] usb: add runtime pm support for usb port device

2012-11-11 Thread Lan Tianyu
On 2012年11月11日 23:46, Alan Stern wrote: > On Sun, 11 Nov 2012, Lan Tianyu wrote: > >> Hi Alan: >> Great thanks for your review and good suggestions. >> I think the main problem is that when the port device resumed(you said >> turn on/off power in the port's runtime callback ) and device

Re: [RFC PATCH 4/5] usb: add runtime pm support for usb port device

2012-11-11 Thread Alan Stern
On Sun, 11 Nov 2012, Lan Tianyu wrote: > Hi Alan: > Great thanks for your review and good suggestions. > I think the main problem is that when the port device resumed(you said > turn on/off power in the port's runtime callback ) and device powered on > again, If we did't resume the d

Re: [RFC PATCH 4/5] usb: add runtime pm support for usb port device

2012-11-11 Thread Lan Tianyu
On 2012/11/10 0:07, Alan Stern wrote: On Fri, 9 Nov 2012, Lan Tianyu wrote: When pm qos flags is changing, the pm core will keep device not in RPM_SUSPEND via pm_runtime_get_sync/put(dev). When the flags are changed, this will affect usb device status. If NO_POWER_OFF flag was set when the devi

Re: [RFC PATCH 4/5] usb: add runtime pm support for usb port device

2012-11-09 Thread Alan Stern
On Fri, 9 Nov 2012, Lan Tianyu wrote: > When pm qos flags is changing, the pm core will keep device not > in RPM_SUSPEND via pm_runtime_get_sync/put(dev). When the flags are > changed, this will affect usb device status. If NO_POWER_OFF flag was > set when the device was power off, it would need t

[RFC PATCH 4/5] usb: add runtime pm support for usb port device

2012-11-09 Thread Lan Tianyu
When pm qos flags is changing, the pm core will keep device not in RPM_SUSPEND via pm_runtime_get_sync/put(dev). When the flags are changed, this will affect usb device status. If NO_POWER_OFF flag was set when the device was power off, it would need to be resumed and suspended again without power