Re: [RFC PATCH 3/4] usb: dwc3: add quirk to be compatible for AMD NL

2014-10-13 Thread Felipe Balbi
Hi, On Sat, Oct 11, 2014 at 01:22:58PM +0800, Huang Rui wrote: > On Sat, Oct 11, 2014 at 01:14:44PM +0800, Huang Rui wrote: > > On Fri, Oct 10, 2014 at 09:04:15AM -0500, Felipe Balbi wrote: > > > Hi, > > > > > > On Fri, Oct 10, 2014 at 05:25:34PM +0800, Huang Rui wrote: > > > > > > I enabled dwc3

Re: [RFC PATCH 3/4] usb: dwc3: add quirk to be compatible for AMD NL

2014-10-10 Thread Huang Rui
On Sat, Oct 11, 2014 at 01:14:44PM +0800, Huang Rui wrote: > On Fri, Oct 10, 2014 at 09:04:15AM -0500, Felipe Balbi wrote: > > Hi, > > > > On Fri, Oct 10, 2014 at 05:25:34PM +0800, Huang Rui wrote: > > > > > I enabled dwc3 and gadget debug/verbose configuration, the whole > > > > > testing dmesg

Re: [RFC PATCH 3/4] usb: dwc3: add quirk to be compatible for AMD NL

2014-10-10 Thread Huang Rui
On Fri, Oct 10, 2014 at 09:04:15AM -0500, Felipe Balbi wrote: > Hi, > > On Fri, Oct 10, 2014 at 05:25:34PM +0800, Huang Rui wrote: > > > > I enabled dwc3 and gadget debug/verbose configuration, the whole > > > > testing dmesg > > > > > > oh, that's why it's so slow :-) I'm getting over 30MB/sec

Re: [RFC PATCH 3/4] usb: dwc3: add quirk to be compatible for AMD NL

2014-10-10 Thread Felipe Balbi
Hi, On Fri, Oct 10, 2014 at 05:25:34PM +0800, Huang Rui wrote: > > > I enabled dwc3 and gadget debug/verbose configuration, the whole testing > > > dmesg > > > > oh, that's why it's so slow :-) I'm getting over 30MB/sec with a Cortex > > A9 :-) > > > > Yes, maybe have two reasons: > 1) The inp

Re: [RFC PATCH 3/4] usb: dwc3: add quirk to be compatible for AMD NL

2014-10-09 Thread Felipe Balbi
Hi, On Fri, Oct 10, 2014 at 08:43:20AM +0800, Huang Rui wrote: > > > But it does't block my building. Because I can comment CROSS_COMPILE at > > > makefile. > > > > > > I am testing my driver and dwc3 controller with MSC tool currently, and > > > will > > > let you know message log later. > > >

Re: [RFC PATCH 3/4] usb: dwc3: add quirk to be compatible for AMD NL

2014-10-09 Thread Huang Rui
On Thu, Oct 09, 2014 at 10:09:37AM -0500, Felipe Balbi wrote: > Hi, > > On Thu, Oct 09, 2014 at 01:10:36PM +0800, Huang Rui wrote: > > > don't worry about that. Some of the tools need to run on the target but > you're not doing that :-) You can make a specific tool by e.g. "make msc". > > >

Re: [RFC PATCH 3/4] usb: dwc3: add quirk to be compatible for AMD NL

2014-10-09 Thread Huang Rui
On Fri, Oct 10, 2014 at 08:43:19AM +0800, Huang Rui wrote: > On Thu, Oct 09, 2014 at 10:09:37AM -0500, Felipe Balbi wrote: > > Hi, > > > > On Thu, Oct 09, 2014 at 01:10:36PM +0800, Huang Rui wrote: > > > > > > > > > don't worry about that. Some of the tools need to run on the target but > > y

Re: [RFC PATCH 3/4] usb: dwc3: add quirk to be compatible for AMD NL

2014-10-09 Thread Felipe Balbi
Hi, On Thu, Oct 09, 2014 at 01:10:36PM +0800, Huang Rui wrote: > > > > ray@hr-ub:~/felipe/usb-tools$ make > > > > LINK companion-desc > > > > companion-desc.o: In function `main': > > > > /home/ray/felipe/usb-tools/companion-desc.c:219: undefined reference to > > > > `libusb_init' > >

Re: [RFC PATCH 3/4] usb: dwc3: add quirk to be compatible for AMD NL

2014-10-08 Thread Huang Rui
On Tue, Sep 30, 2014 at 09:33:49AM -0500, Felipe Balbi wrote: > On Mon, Sep 29, 2014 at 11:48:41PM -0500, Felipe Balbi wrote: > > Hi, > > > > On Tue, Sep 30, 2014 at 11:12:55AM +0800, Huang Rui wrote: > > > > > > > > > > On Thu, Sep 25, 2014 at 03:21:46PM +0800, Huang Rui wrote: > > > > > > > > >

Re: [RFC PATCH 3/4] usb: dwc3: add quirk to be compatible for AMD NL

2014-10-08 Thread Huang Rui
On Mon, Sep 29, 2014 at 11:28:57AM +0300, Heikki Krogerus wrote: > > > > A question, the dwc3 controller is the PCI-E device in my platform, > > > > but the class code of PCI header is 0x0c0330, the same with xHC. > > > > That's because it need to meet the windows enviroment. The dwc3 > > > > contr

Re: [RFC PATCH 3/4] usb: dwc3: add quirk to be compatible for AMD NL

2014-09-30 Thread Felipe Balbi
On Mon, Sep 29, 2014 at 11:48:41PM -0500, Felipe Balbi wrote: > Hi, > > On Tue, Sep 30, 2014 at 11:12:55AM +0800, Huang Rui wrote: > > > > > > > > > On Thu, Sep 25, 2014 at 03:21:46PM +0800, Huang Rui wrote: > > > > > > > > > > diff --git a/drivers/usb/dwc3/core.c > > > > > > > > > > b/drivers/us

Re: [RFC PATCH 3/4] usb: dwc3: add quirk to be compatible for AMD NL

2014-09-29 Thread Felipe Balbi
Hi, On Tue, Sep 30, 2014 at 11:12:55AM +0800, Huang Rui wrote: > > > > > > > > On Thu, Sep 25, 2014 at 03:21:46PM +0800, Huang Rui wrote: > > > > > > > > > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c > > > > > > > > > index b0f4d52..6138c5d 100644 > > > > > > > > > --- a/drivers

Re: [RFC PATCH 3/4] usb: dwc3: add quirk to be compatible for AMD NL

2014-09-29 Thread Huang Rui
On Mon, Sep 29, 2014 at 09:15:13AM -0500, Felipe Balbi wrote: > Hi, > > On Mon, Sep 29, 2014 at 05:38:32PM +0800, Huang Rui wrote: > > > > > > > On Thu, Sep 25, 2014 at 03:21:46PM +0800, Huang Rui wrote: > > > > > > > > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c > > > > > > > >

Re: [RFC PATCH 3/4] usb: dwc3: add quirk to be compatible for AMD NL

2014-09-29 Thread Felipe Balbi
Hi, On Mon, Sep 29, 2014 at 05:59:42PM +, Paul Zimmerman wrote: > > diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c > > index 68497b3..112352e 100644 > > --- a/drivers/usb/dwc3/gadget.c > > +++ b/drivers/usb/dwc3/gadget.c > > @@ -1577,6 +1577,13 @@ static int dwc3_gadget_sta

RE: [RFC PATCH 3/4] usb: dwc3: add quirk to be compatible for AMD NL

2014-09-29 Thread Paul Zimmerman
> From: Felipe Balbi [mailto:ba...@ti.com] > Sent: Friday, September 26, 2014 9:31 PM > > On Sat, Sep 27, 2014 at 01:05:46AM +, Paul Zimmerman wrote: > > > > Well, it's called LPM Errata because the feature was added to the USB > > spec as an erratum. It's not an erratum to our controller. But

Re: [RFC PATCH 3/4] usb: dwc3: add quirk to be compatible for AMD NL

2014-09-29 Thread Felipe Balbi
Hi, On Mon, Sep 29, 2014 at 05:38:32PM +0800, Huang Rui wrote: > > > > > > On Thu, Sep 25, 2014 at 03:21:46PM +0800, Huang Rui wrote: > > > > > > > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c > > > > > > > index b0f4d52..6138c5d 100644 > > > > > > > --- a/drivers/usb/dwc3/core.c

Re: [RFC PATCH 3/4] usb: dwc3: add quirk to be compatible for AMD NL

2014-09-29 Thread Huang Rui
On Sun, Sep 28, 2014 at 06:41:39PM -0500, Felipe Balbi wrote: > Hi, > > On Sun, Sep 28, 2014 at 11:11:23AM +0800, Huang Rui wrote: > > On Fri, Sep 26, 2014 at 09:35:21AM -0500, Felipe Balbi wrote: > > > On Fri, Sep 26, 2014 at 04:50:26PM +0800, Huang Rui wrote: > > > > On Thu, Sep 25, 2014 at 09:5

Re: [RFC PATCH 3/4] usb: dwc3: add quirk to be compatible for AMD NL

2014-09-29 Thread Heikki Krogerus
> > > A question, the dwc3 controller is the PCI-E device in my platform, > > > but the class code of PCI header is 0x0c0330, the same with xHC. > > > That's because it need to meet the windows enviroment. The dwc3 > > > controller acted as only host mode to bind with windows xhci driver. > > > But

Re: [RFC PATCH 3/4] usb: dwc3: add quirk to be compatible for AMD NL

2014-09-28 Thread Huang Rui
On Sun, Sep 28, 2014 at 06:46:14PM -0500, Felipe Balbi wrote: > Hi, > > On Sun, Sep 28, 2014 at 05:18:58PM +0800, Huang Rui wrote: > > > > > From: Felipe Balbi [mailto:ba...@ti.com] > > > > > Sent: Friday, September 26, 2014 5:54 PM > > > > > > > > > > On Fri, Sep 26, 2014 at 11:18:48PM +, Pa

Re: [RFC PATCH 3/4] usb: dwc3: add quirk to be compatible for AMD NL

2014-09-28 Thread Felipe Balbi
Hi, On Sun, Sep 28, 2014 at 05:18:58PM +0800, Huang Rui wrote: > > > > From: Felipe Balbi [mailto:ba...@ti.com] > > > > Sent: Friday, September 26, 2014 5:54 PM > > > > > > > > On Fri, Sep 26, 2014 at 11:18:48PM +, Paul Zimmerman wrote: > > > > > > From: Felipe Balbi [mailto:ba...@ti.com] > >

Re: [RFC PATCH 3/4] usb: dwc3: add quirk to be compatible for AMD NL

2014-09-28 Thread Felipe Balbi
Hi, On Sun, Sep 28, 2014 at 11:11:23AM +0800, Huang Rui wrote: > On Fri, Sep 26, 2014 at 09:35:21AM -0500, Felipe Balbi wrote: > > On Fri, Sep 26, 2014 at 04:50:26PM +0800, Huang Rui wrote: > > > On Thu, Sep 25, 2014 at 09:50:32AM -0500, Felipe Balbi wrote: > > > > Hi, > > > > > > > > On Thu, Sep

Re: [RFC PATCH 3/4] usb: dwc3: add quirk to be compatible for AMD NL

2014-09-28 Thread Huang Rui
On Fri, Sep 26, 2014 at 11:30:44PM -0500, Felipe Balbi wrote: > Hi, > > On Sat, Sep 27, 2014 at 01:05:46AM +, Paul Zimmerman wrote: > > > From: Felipe Balbi [mailto:ba...@ti.com] > > > Sent: Friday, September 26, 2014 5:54 PM > > > > > > On Fri, Sep 26, 2014 at 11:18:48PM +, Paul Zimmerma

Re: [RFC PATCH 3/4] usb: dwc3: add quirk to be compatible for AMD NL

2014-09-27 Thread Huang Rui
On Fri, Sep 26, 2014 at 09:35:21AM -0500, Felipe Balbi wrote: > On Fri, Sep 26, 2014 at 04:50:26PM +0800, Huang Rui wrote: > > On Thu, Sep 25, 2014 at 09:50:32AM -0500, Felipe Balbi wrote: > > > Hi, > > > > > > On Thu, Sep 25, 2014 at 03:21:46PM +0800, Huang Rui wrote: > > > > diff --git a/drivers

Re: [RFC PATCH 3/4] usb: dwc3: add quirk to be compatible for AMD NL

2014-09-27 Thread Huang Rui
On Fri, Sep 26, 2014 at 09:35:21AM -0500, Felipe Balbi wrote: > On Fri, Sep 26, 2014 at 04:50:26PM +0800, Huang Rui wrote: > > On Thu, Sep 25, 2014 at 09:50:32AM -0500, Felipe Balbi wrote: > > > Hi, > > > > > > On Thu, Sep 25, 2014 at 03:21:46PM +0800, Huang Rui wrote: > > > > diff --git a/drivers

Re: [RFC PATCH 3/4] usb: dwc3: add quirk to be compatible for AMD NL

2014-09-26 Thread Felipe Balbi
Hi, On Sat, Sep 27, 2014 at 01:05:46AM +, Paul Zimmerman wrote: > > From: Felipe Balbi [mailto:ba...@ti.com] > > Sent: Friday, September 26, 2014 5:54 PM > > > > On Fri, Sep 26, 2014 at 11:18:48PM +, Paul Zimmerman wrote: > > > > From: Felipe Balbi [mailto:ba...@ti.com] > > > > Sent: Frid

RE: [RFC PATCH 3/4] usb: dwc3: add quirk to be compatible for AMD NL

2014-09-26 Thread Paul Zimmerman
> From: Felipe Balbi [mailto:ba...@ti.com] > Sent: Friday, September 26, 2014 5:54 PM > > On Fri, Sep 26, 2014 at 11:18:48PM +, Paul Zimmerman wrote: > > > From: Felipe Balbi [mailto:ba...@ti.com] > > > Sent: Friday, September 26, 2014 2:40 PM > > > > > > On Fri, Sep 26, 2014 at 08:57:19PM +00

Re: [RFC PATCH 3/4] usb: dwc3: add quirk to be compatible for AMD NL

2014-09-26 Thread Felipe Balbi
Hi, On Fri, Sep 26, 2014 at 11:18:48PM +, Paul Zimmerman wrote: > > From: Felipe Balbi [mailto:ba...@ti.com] > > Sent: Friday, September 26, 2014 2:40 PM > > > > On Fri, Sep 26, 2014 at 08:57:19PM +, Paul Zimmerman wrote: > > > > > diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3

RE: [RFC PATCH 3/4] usb: dwc3: add quirk to be compatible for AMD NL

2014-09-26 Thread Paul Zimmerman
> From: Felipe Balbi [mailto:ba...@ti.com] > Sent: Friday, September 26, 2014 2:40 PM > > On Fri, Sep 26, 2014 at 08:57:19PM +, Paul Zimmerman wrote: > > > > diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c > > > > index 0fcc0a3..8277065 100644 > > > > --- a/drivers/usb/dwc3/

Re: [RFC PATCH 3/4] usb: dwc3: add quirk to be compatible for AMD NL

2014-09-26 Thread Felipe Balbi
Hi, On Fri, Sep 26, 2014 at 08:57:19PM +, Paul Zimmerman wrote: > > > diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c > > > index 0fcc0a3..8277065 100644 > > > --- a/drivers/usb/dwc3/gadget.c > > > +++ b/drivers/usb/dwc3/gadget.c > > > @@ -2635,6 +2635,7 @@ static irqreturn_

RE: [RFC PATCH 3/4] usb: dwc3: add quirk to be compatible for AMD NL

2014-09-26 Thread Paul Zimmerman
From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Felipe Balbi Sent: Thursday, September 25, 2014 7:51 AM > On Thu, Sep 25, 2014 at 03:21:46PM +0800, Huang Rui wrote: > > diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c > > index 0fcc0a3

Re: [RFC PATCH 3/4] usb: dwc3: add quirk to be compatible for AMD NL

2014-09-26 Thread Felipe Balbi
Hi, On Fri, Sep 26, 2014 at 09:35:21AM -0500, Felipe Balbi wrote: > This is just because I don't have access to the HW myself, so I can't > verify your patches. One thing I can tell you, with my testing/next, > dwc3 is really stable. I have every test passing except for Halt > Endpoint which I'm d

Re: [RFC PATCH 3/4] usb: dwc3: add quirk to be compatible for AMD NL

2014-09-26 Thread Felipe Balbi
On Fri, Sep 26, 2014 at 04:50:26PM +0800, Huang Rui wrote: > On Thu, Sep 25, 2014 at 09:50:32AM -0500, Felipe Balbi wrote: > > Hi, > > > > On Thu, Sep 25, 2014 at 03:21:46PM +0800, Huang Rui wrote: > > > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c > > > index b0f4d52..6138c5d 10

Re: [RFC PATCH 3/4] usb: dwc3: add quirk to be compatible for AMD NL

2014-09-26 Thread Huang Rui
On Thu, Sep 25, 2014 at 09:50:32AM -0500, Felipe Balbi wrote: > Hi, > > On Thu, Sep 25, 2014 at 03:21:46PM +0800, Huang Rui wrote: > > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c > > index b0f4d52..6138c5d 100644 > > --- a/drivers/usb/dwc3/core.c > > +++ b/drivers/usb/dwc3/core.

Re: [RFC PATCH 3/4] usb: dwc3: add quirk to be compatible for AMD NL

2014-09-25 Thread Felipe Balbi
Hi, On Thu, Sep 25, 2014 at 03:21:46PM +0800, Huang Rui wrote: > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c > index b0f4d52..6138c5d 100644 > --- a/drivers/usb/dwc3/core.c > +++ b/drivers/usb/dwc3/core.c > @@ -115,6 +115,25 @@ static int dwc3_core_soft_reset(struct dwc3 *dwc) >

[RFC PATCH 3/4] usb: dwc3: add quirk to be compatible for AMD NL

2014-09-25 Thread Huang Rui
This patch add a quirk to be compatible for AMD NL SoC Some specific behaviors on NL: - configure USB3 PIPE registers - enable GCTL disscramble - enable U2EXIT_LFPS - enable hibernation at the global level - set LPM errata dissabled Signed-off-by: Huang Rui --- drivers/usb/dwc3/core.c