Re: [RFC PATCH 2/2] usb: storage: scsiglue: limit USB3 devices to 2048 sectors

2015-11-05 Thread Felipe Balbi
Hi, Alan Stern writes: > On Thu, 5 Nov 2015, Felipe Balbi wrote: > >> Hi, >> >> Oliver Neukum writes: >> > On Wed, 2015-11-04 at 16:26 -0500, Alan Stern wrote: >> >> This doesn't need to be stored as one of the usb-storage flags. And >> >> since we are close to running out of flag bits (on 32

Re: [RFC PATCH 2/2] usb: storage: scsiglue: limit USB3 devices to 2048 sectors

2015-11-05 Thread Alan Stern
On Thu, 5 Nov 2015, Felipe Balbi wrote: > Hi, > > Oliver Neukum writes: > > On Wed, 2015-11-04 at 16:26 -0500, Alan Stern wrote: > >> This doesn't need to be stored as one of the usb-storage flags. And > >> since we are close to running out of flag bits (on 32-bit > >> architectures), it would

Re: [RFC PATCH 2/2] usb: storage: scsiglue: limit USB3 devices to 2048 sectors

2015-11-05 Thread Felipe Balbi
Hi, Oliver Neukum writes: > On Wed, 2015-11-04 at 16:26 -0500, Alan Stern wrote: >> This doesn't need to be stored as one of the usb-storage flags. And >> since we are close to running out of flag bits (on 32-bit >> architectures), it would be better not to use one of them for this. > > Do we w

Re: [RFC PATCH 2/2] usb: storage: scsiglue: limit USB3 devices to 2048 sectors

2015-11-05 Thread Alan Stern
On Thu, 5 Nov 2015, Oliver Neukum wrote: > On Wed, 2015-11-04 at 16:26 -0500, Alan Stern wrote: > > This doesn't need to be stored as one of the usb-storage flags. And > > since we are close to running out of flag bits (on 32-bit > > architectures), it would be better not to use one of them for t

Re: [RFC PATCH 2/2] usb: storage: scsiglue: limit USB3 devices to 2048 sectors

2015-11-05 Thread Oliver Neukum
On Wed, 2015-11-04 at 16:26 -0500, Alan Stern wrote: > This doesn't need to be stored as one of the usb-storage flags. And > since we are close to running out of flag bits (on 32-bit > architectures), it would be better not to use one of them for this. Do we want the opposite flag? 25% for known

Re: [RFC PATCH 2/2] usb: storage: scsiglue: limit USB3 devices to 2048 sectors

2015-11-04 Thread Felipe Balbi
Hi, Alan Stern writes: > On Wed, 4 Nov 2015, Felipe Balbi wrote: > >> USB3 devices, because they are much newer, have much >> less chance of having issues with larger transfers. >> >> We still keep a limit because anything above 2048 >> sectors really rendered negligible speed >> improvements,

Re: [RFC PATCH 2/2] usb: storage: scsiglue: limit USB3 devices to 2048 sectors

2015-11-04 Thread Alan Stern
On Wed, 4 Nov 2015, Felipe Balbi wrote: > USB3 devices, because they are much newer, have much > less chance of having issues with larger transfers. > > We still keep a limit because anything above 2048 > sectors really rendered negligible speed > improvements, so we will simply ignore > that. Tr

Re: [RFC PATCH 2/2] usb: storage: scsiglue: limit USB3 devices to 2048 sectors

2015-11-04 Thread Felipe Balbi
Hi, Greg KH writes: > On Wed, Nov 04, 2015 at 02:48:32PM -0600, Felipe Balbi wrote: >> USB3 devices, because they are much newer, have much >> less chance of having issues with larger transfers. >> >> We still keep a limit because anything above 2048 >> sectors really rendered negligible speed

Re: [RFC PATCH 2/2] usb: storage: scsiglue: limit USB3 devices to 2048 sectors

2015-11-04 Thread Greg KH
On Wed, Nov 04, 2015 at 02:48:32PM -0600, Felipe Balbi wrote: > USB3 devices, because they are much newer, have much > less chance of having issues with larger transfers. > > We still keep a limit because anything above 2048 > sectors really rendered negligible speed > improvements, so we will sim

[RFC PATCH 2/2] usb: storage: scsiglue: limit USB3 devices to 2048 sectors

2015-11-04 Thread Felipe Balbi
USB3 devices, because they are much newer, have much less chance of having issues with larger transfers. We still keep a limit because anything above 2048 sectors really rendered negligible speed improvements, so we will simply ignore that. Transferring 1MiB should already give us pretty good perf