Re: [RFC PATCH 15/15] checkpatch: allow list_for_each helper macros

2013-10-24 Thread Dan Williams
On Thu, Oct 24, 2013 at 9:48 PM, Paul Zimmerman wrote: >> From: Joe Perches [mailto:j...@perches.com] >> Sent: Thursday, October 24, 2013 9:34 PM >> >> On Fri, 2013-10-25 at 03:52 +, Paul Zimmerman wrote: >> > > From: Dan Williams >> > > Sent: Thursday, October 24, 2013 12:45 AM >> > > >> > >

RE: [RFC PATCH 15/15] checkpatch: allow list_for_each helper macros

2013-10-24 Thread Paul Zimmerman
> From: Joe Perches [mailto:j...@perches.com] > Sent: Thursday, October 24, 2013 9:34 PM > > On Fri, 2013-10-25 at 03:52 +, Paul Zimmerman wrote: > > > From: Dan Williams > > > Sent: Thursday, October 24, 2013 12:45 AM > > > > > > On Thu, Oct 24, 2013 at 12:36 AM, Dan Williams > > > wrote: >

Re: [RFC PATCH 15/15] checkpatch: allow list_for_each helper macros

2013-10-24 Thread Joe Perches
On Fri, 2013-10-25 at 03:52 +, Paul Zimmerman wrote: > > From: Dan Williams > > Sent: Thursday, October 24, 2013 12:45 AM > > > > On Thu, Oct 24, 2013 at 12:36 AM, Dan Williams > > wrote: > > > Permit list_for_each redifinitions like: > > > > > > #define for_each_connector_peer(peer, port, c

RE: [RFC PATCH 15/15] checkpatch: allow list_for_each helper macros

2013-10-24 Thread Paul Zimmerman
> From: Dan Williams > Sent: Thursday, October 24, 2013 12:45 AM > > On Thu, Oct 24, 2013 at 12:36 AM, Dan Williams > wrote: > > Permit list_for_each redifinitions like: > > > > #define for_each_connector_peer(peer, port, c) \ > >list_for_each_entry(peer, &(c)->ports, node) \ > >

Re: [RFC PATCH 15/15] checkpatch: allow list_for_each helper macros

2013-10-24 Thread Dan Williams
[ adding Andy and Joe ] On Thu, Oct 24, 2013 at 12:36 AM, Dan Williams wrote: > Permit list_for_each redifinitions like: > > #define for_each_connector_peer(peer, port, c) \ >list_for_each_entry(peer, &(c)->ports, node) \ >if (port != peer) > > ...which triggers: > ERROR:

[RFC PATCH 15/15] checkpatch: allow list_for_each helper macros

2013-10-24 Thread Dan Williams
Permit list_for_each redifinitions like: #define for_each_connector_peer(peer, port, c) \ list_for_each_entry(peer, &(c)->ports, node) \ if (port != peer) ...which triggers: ERROR: Macros with complex values should be enclosed in parenthesis Cc: Andrew Morton Cc: Joe Perch