Re: [RFC PATCH 1/7] usb: typec: Generalize mux mode names

2018-05-21 Thread Heikki Krogerus
On Fri, May 18, 2018 at 07:26:40AM +0200, Mats Karrman wrote: > On 2018-05-17 13:50, Heikki Krogerus wrote: > > > On Wed, May 16, 2018 at 11:11:02PM +0200, Mats Karrman wrote: > > > On 05/16/2018 01:43 PM, Heikki Krogerus wrote: > > > > > > > On Tue, May 15, 2018 at 11:24:07PM +0200, Mats Karrman

Re: [RFC PATCH 1/7] usb: typec: Generalize mux mode names

2018-05-17 Thread Mats Karrman
On 2018-05-17 13:50, Heikki Krogerus wrote: On Wed, May 16, 2018 at 11:11:02PM +0200, Mats Karrman wrote: On 05/16/2018 01:43 PM, Heikki Krogerus wrote: On Tue, May 15, 2018 at 11:24:07PM +0200, Mats Karrman wrote: Hi Heikki, On 05/15/2018 09:30 AM, Heikki Krogerus wrote: Hi Mats, On Fri

Re: [RFC PATCH 1/7] usb: typec: Generalize mux mode names

2018-05-17 Thread Heikki Krogerus
On Wed, May 16, 2018 at 11:11:02PM +0200, Mats Karrman wrote: > On 05/16/2018 01:43 PM, Heikki Krogerus wrote: > > > On Tue, May 15, 2018 at 11:24:07PM +0200, Mats Karrman wrote: > >> Hi Heikki, > >> > >> On 05/15/2018 09:30 AM, Heikki Krogerus wrote: > >> > >>> Hi Mats, > >>> > >>> On Fri, May 11

Re: [RFC PATCH 1/7] usb: typec: Generalize mux mode names

2018-05-16 Thread Mats Karrman
On 05/16/2018 01:43 PM, Heikki Krogerus wrote: > On Tue, May 15, 2018 at 11:24:07PM +0200, Mats Karrman wrote: >> Hi Heikki, >> >> On 05/15/2018 09:30 AM, Heikki Krogerus wrote: >> >>> Hi Mats, >>> >>> On Fri, May 11, 2018 at 09:28:04PM +0200, Mats Karrman wrote: On 2018-05-11 13:14, Heikki K

Re: [RFC PATCH 1/7] usb: typec: Generalize mux mode names

2018-05-16 Thread Heikki Krogerus
On Tue, May 15, 2018 at 11:24:07PM +0200, Mats Karrman wrote: > Hi Heikki, > > On 05/15/2018 09:30 AM, Heikki Krogerus wrote: > > > Hi Mats, > > > > On Fri, May 11, 2018 at 09:28:04PM +0200, Mats Karrman wrote: > >> On 2018-05-11 13:14, Heikki Krogerus wrote: > >> > >>> On Fri, May 11, 2018 at 11

Re: [RFC PATCH 1/7] usb: typec: Generalize mux mode names

2018-05-15 Thread Mats Karrman
Hi Heikki, On 05/15/2018 09:30 AM, Heikki Krogerus wrote: > Hi Mats, > > On Fri, May 11, 2018 at 09:28:04PM +0200, Mats Karrman wrote: >> On 2018-05-11 13:14, Heikki Krogerus wrote: >> >>> On Fri, May 11, 2018 at 11:05:55AM +0200, Mats Karrman wrote: On 2018-05-10 19:49, Heikki Krogerus wrot

Re: [RFC PATCH 1/7] usb: typec: Generalize mux mode names

2018-05-15 Thread Heikki Krogerus
Hi Mats, On Fri, May 11, 2018 at 09:28:04PM +0200, Mats Karrman wrote: > On 2018-05-11 13:14, Heikki Krogerus wrote: > > > On Fri, May 11, 2018 at 11:05:55AM +0200, Mats Karrman wrote: > > > On 2018-05-10 19:49, Heikki Krogerus wrote: > > > > > > > On Thu, May 10, 2018 at 10:04:21AM +0200, Mats

Re: [RFC PATCH 1/7] usb: typec: Generalize mux mode names

2018-05-11 Thread Mats Karrman
On 2018-05-11 13:14, Heikki Krogerus wrote: On Fri, May 11, 2018 at 11:05:55AM +0200, Mats Karrman wrote: On 2018-05-10 19:49, Heikki Krogerus wrote: On Thu, May 10, 2018 at 10:04:21AM +0200, Mats Karrman wrote: Hi, On 05/09/2018 02:49 PM, Heikki Krogerus wrote: On Tue, May 08, 2018 at 09

Re: [RFC PATCH 1/7] usb: typec: Generalize mux mode names

2018-05-09 Thread Heikki Krogerus
On Tue, May 08, 2018 at 09:10:13PM +0200, Mats Karrman wrote: > Hi, > > On 05/08/2018 04:25 PM, Heikki Krogerus wrote: > > > Hi, > > > > On Mon, May 07, 2018 at 11:19:40PM +0200, Mats Karrman wrote: > Even so, when the mux driver "set" function is called, it will just get > the >

Re: [RFC PATCH 1/7] usb: typec: Generalize mux mode names

2018-05-08 Thread Mats Karrman
Hi, On 05/08/2018 04:25 PM, Heikki Krogerus wrote: > Hi, > > On Mon, May 07, 2018 at 11:19:40PM +0200, Mats Karrman wrote: Even so, when the mux driver "set" function is called, it will just get the mode argument but since the mode (TYPEC_STATE_...) is overlapping for different >>

Re: [RFC PATCH 1/7] usb: typec: Generalize mux mode names

2018-05-08 Thread Heikki Krogerus
Hi, On Mon, May 07, 2018 at 11:19:40PM +0200, Mats Karrman wrote: > >> Even so, when the mux driver "set" function is called, it will just get the > >> mode argument but since the mode (TYPEC_STATE_...) is overlapping for > >> different > >> AMs if I understand your proposal correctly, the mux al

Re: [RFC PATCH 1/7] usb: typec: Generalize mux mode names

2018-05-07 Thread Mats Karrman
Hi Heikki, On 05/07/2018 03:39 PM, Heikki Krogerus wrote: > Hi Mats, > > On Fri, May 04, 2018 at 06:57:31PM +0200, Mats Karrman wrote: >> On 2018-05-04 16:56, Heikki Krogerus wrote: >> >>> On Wed, May 02, 2018 at 03:13:44PM +0200, Mats Karrman wrote: Hi Heikki, On 2018-05-02 10:25,

Re: [RFC PATCH 1/7] usb: typec: Generalize mux mode names

2018-05-07 Thread Heikki Krogerus
Hi Mats, On Fri, May 04, 2018 at 06:57:31PM +0200, Mats Karrman wrote: > > On 2018-05-04 16:56, Heikki Krogerus wrote: > > > On Wed, May 02, 2018 at 03:13:44PM +0200, Mats Karrman wrote: > > > Hi Heikki, > > > > > > On 2018-05-02 10:25, Heikki Krogerus wrote: > > > > > > > On Wed, May 02, 2018

Re: [RFC PATCH 1/7] usb: typec: Generalize mux mode names

2018-05-04 Thread Mats Karrman
On 2018-05-04 16:56, Heikki Krogerus wrote: On Wed, May 02, 2018 at 03:13:44PM +0200, Mats Karrman wrote: Hi Heikki, On 2018-05-02 10:25, Heikki Krogerus wrote: On Wed, May 02, 2018 at 11:23:35AM +0300, Heikki Krogerus wrote: Hi Mats, On Wed, May 02, 2018 at 12:21:07AM +0200, Mats Karrman

Re: [RFC PATCH 1/7] usb: typec: Generalize mux mode names

2018-05-04 Thread Heikki Krogerus
On Wed, May 02, 2018 at 03:13:44PM +0200, Mats Karrman wrote: > Hi Heikki, > > On 2018-05-02 10:25, Heikki Krogerus wrote: > > > On Wed, May 02, 2018 at 11:23:35AM +0300, Heikki Krogerus wrote: > > > Hi Mats, > > > > > > On Wed, May 02, 2018 at 12:21:07AM +0200, Mats Karrman wrote: > > > > The c

Re: [RFC PATCH 1/7] usb: typec: Generalize mux mode names

2018-05-02 Thread Mats Karrman
Hi Heikki, On 2018-05-02 10:25, Heikki Krogerus wrote: On Wed, May 02, 2018 at 11:23:35AM +0300, Heikki Krogerus wrote: Hi Mats, On Wed, May 02, 2018 at 12:21:07AM +0200, Mats Karrman wrote: The current naming used for tcpc_mux_mode constants makes too much assumptioms about the usage of the

Re: [RFC PATCH 1/7] usb: typec: Generalize mux mode names

2018-05-02 Thread Heikki Krogerus
On Wed, May 02, 2018 at 11:23:35AM +0300, Heikki Krogerus wrote: > Hi Mats, > > On Wed, May 02, 2018 at 12:21:07AM +0200, Mats Karrman wrote: > > The current naming used for tcpc_mux_mode constants makes > > too much assumptioms about the usage of the signals. > > This patch replaces the names wit

Re: [RFC PATCH 1/7] usb: typec: Generalize mux mode names

2018-05-02 Thread Heikki Krogerus
Hi Mats, On Wed, May 02, 2018 at 12:21:07AM +0200, Mats Karrman wrote: > The current naming used for tcpc_mux_mode constants makes > too much assumptioms about the usage of the signals. > This patch replaces the names with generic names more closely > tied to the Type-C specifications and also add

[RFC PATCH 1/7] usb: typec: Generalize mux mode names

2018-05-01 Thread Mats Karrman
The current naming used for tcpc_mux_mode constants makes too much assumptioms about the usage of the signals. This patch replaces the names with generic names more closely tied to the Type-C specifications and also adds some new ones. At the same time TCPC_MUX_* defines are removed as they do not