Re: [RFC 2/2] xhci: refactor handle_cmd_completion() switch into separate function

2013-08-20 Thread Sarah Sharp
That's not quite what I wanted. :) What I wanted was for you to take each of the larger chunks of code in the case statements, and turn them into separate functions. I.e.: switch (le32_to_cpu(xhci->cmd_ring->dequeue->generic.field[3]) & TRB_TYPE_BITMASK) { case TR

[RFC 2/2] xhci: refactor handle_cmd_completion() switch into separate function

2013-08-16 Thread Xenia Ragiadakou
This patch refactors the big switch statement in handle_cmd_completion() into a separate function, called handle_cmd_completion2() (this name is temporary, we will need a different name). There have been declared some additional local variables, such as cmd_trb, cmd_comp_code, cmd_type, add_flags