Re: [RFC 1/2] USB: OTG: Hold wakeupsource when VBUS present

2014-09-02 Thread Todd Poynor
On Fri, Aug 29, 2014 at 1:50 PM, Felipe Balbi wrote: > Hi, > > On Wed, Aug 27, 2014 at 02:58:30PM -0700, Todd Poynor wrote: >> On Fri, Aug 22, 2014 at 10:12 AM, Felipe Balbi wrote: >> ... >> > you never explain why this is needed and you have also added some >> > information to commit log which s

Re: [RFC 1/2] USB: OTG: Hold wakeupsource when VBUS present

2014-08-31 Thread Peter Chen
On Fri, Aug 22, 2014 at 03:19:32PM +0530, Kiran Kumar Raparthy wrote: > From: Todd Poynor > > USB: OTG: Hold wakeupsource when VBUS present > It is not related to OTG, would you change a name? > Enabled by default, can disable with: >echo N > /sys/module/otg_wakeupsource/parameters/enabled

Re: [RFC 1/2] USB: OTG: Hold wakeupsource when VBUS present

2014-08-29 Thread Felipe Balbi
Hi, On Wed, Aug 27, 2014 at 02:58:30PM -0700, Todd Poynor wrote: > On Fri, Aug 22, 2014 at 10:12 AM, Felipe Balbi wrote: > ... > > you never explain why this is needed and you have also added some > > information to commit log which shouldn't be here. > > Android uses this to prevent suspend fro

Re: [RFC 1/2] USB: OTG: Hold wakeupsource when VBUS present

2014-08-27 Thread Todd Poynor
On Fri, Aug 22, 2014 at 10:12 AM, Felipe Balbi wrote: ... > you never explain why this is needed and you have also added some > information to commit log which shouldn't be here. Android uses this to prevent suspend from interfering with USB peripheral traffic, notably adb. The wakeup source is

Re: [RFC 1/2] USB: OTG: Hold wakeupsource when VBUS present

2014-08-22 Thread Felipe Balbi
Hi, On Fri, Aug 22, 2014 at 03:19:32PM +0530, Kiran Kumar Raparthy wrote: > From: Todd Poynor > > USB: OTG: Hold wakeupsource when VBUS present > > Enabled by default, can disable with: I would turn this around and make it disabled by default so that it doesn't change behavior for distro kerne

Re: [RFC 1/2] USB: OTG: Hold wakeupsource when VBUS present

2014-08-22 Thread Alan Stern
On Fri, 22 Aug 2014, Kiran Kumar Raparthy wrote: > From: Todd Poynor > > USB: OTG: Hold wakeupsource when VBUS present > > Enabled by default, can disable with: >echo N > /sys/module/otg_wakeupsource/parameters/enabled > > This is one of the number of patches from the Android AOSP common.g

[RFC 1/2] USB: OTG: Hold wakeupsource when VBUS present

2014-08-22 Thread Kiran Kumar Raparthy
From: Todd Poynor USB: OTG: Hold wakeupsource when VBUS present Enabled by default, can disable with: echo N > /sys/module/otg_wakeupsource/parameters/enabled This is one of the number of patches from the Android AOSP common.git tree, which is used on almost all Android devices. so I wanted