Re: [RFC] usb: gadget: serial: remove PREFIX macro

2014-08-20 Thread Sergei Shtylyov
Hello. On 08/20/2014 07:54 PM, Felipe Balbi wrote: Remove the ttyGS PREFIX macro from u_serial.c and replace all occurences with the hardcoded ttyGS string. This macro was mostly used in a few debug/warning messages and a lot of hardcoded ttyGS existed beneath. It may have been used for rena

Re: [RFC] usb: gadget: serial: remove PREFIX macro

2014-08-20 Thread Felipe Balbi
Hi, On Fri, Jul 18, 2014 at 11:39:46AM +0200, Richard Leitner wrote: > Remove the ttyGS PREFIX macro from u_serial.c and replace all occurences with > the hardcoded ttyGS string. > > This macro was mostly used in a few debug/warning messages and a lot of > hardcoded ttyGS existed beneath. It may

Re: [RFC] usb: gadget: serial: remove PREFIX macro

2014-08-11 Thread Felipe Balbi
Hi, On Mon, Aug 11, 2014 at 04:52:38PM +0200, Richard Leitner wrote: > On Mon, 11 Aug 2014 08:50:34 -0500 > Felipe Balbi wrote: > > > On Mon, Aug 11, 2014 at 03:04:35PM +0200, Richard Leitner wrote: > > > Hi, > > > this patch was lying around for some time... > > > are there any comments or obje

Re: [RFC] usb: gadget: serial: remove PREFIX macro

2014-08-11 Thread Richard Leitner
Hi, On Mon, 11 Aug 2014 08:50:34 -0500 Felipe Balbi wrote: > On Mon, Aug 11, 2014 at 03:04:35PM +0200, Richard Leitner wrote: > > Hi, > > this patch was lying around for some time... > > are there any comments or objections on this? > > you realise we're still in the middle of the merge window,

Re: [RFC] usb: gadget: serial: remove PREFIX macro

2014-08-11 Thread Felipe Balbi
On Mon, Aug 11, 2014 at 03:04:35PM +0200, Richard Leitner wrote: > Hi, > this patch was lying around for some time... > are there any comments or objections on this? you realise we're still in the middle of the merge window, right ? -- balbi signature.asc Description: Digital signature

Re: [RFC] usb: gadget: serial: remove PREFIX macro

2014-08-11 Thread Richard Leitner
Hi, this patch was lying around for some time... are there any comments or objections on this? regards, richard On Fri, 18 Jul 2014 11:39:46 +0200 Richard Leitner wrote: > Remove the ttyGS PREFIX macro from u_serial.c and replace all occurences with > the hardcoded ttyGS string. > > This macro

[RFC] usb: gadget: serial: remove PREFIX macro

2014-07-18 Thread Richard Leitner
Remove the ttyGS PREFIX macro from u_serial.c and replace all occurences with the hardcoded ttyGS string. This macro was mostly used in a few debug/warning messages and a lot of hardcoded ttyGS existed beneath. It may have been used for renaming the tty, but if done so most debug messages would ha