Re: [RESEND PATCH] usb: gadget: at91_udc: move prepare clk into process context

2015-01-13 Thread Kamal Mostafa
On Fri, 2014-12-19 at 13:51 +, Luis Henriques wrote: > Hi Felipe, > > On Thu, Nov 20, 2014 at 01:50:49PM -0600, Felipe Balbi wrote: > > On Wed, Nov 19, 2014 at 04:37:27PM +0100, Nicolas Ferre wrote: > > > From: Ronald Wahl > > > > > > Commit 7628083227b6bc4a7e33d7c381d7a4e558424b6b (usb: gad

Re: [RESEND PATCH] usb: gadget: at91_udc: move prepare clk into process context

2014-12-22 Thread Felipe Balbi
Hi, On Fri, Dec 19, 2014 at 02:18:31PM +, Luis Henriques wrote: > On Fri, Dec 19, 2014 at 03:08:15PM +0100, Nicolas Ferre wrote: > > Le 19/12/2014 15:02, Ronald Wahl a écrit : > > > On 19.12.2014 14:51, Luis Henriques wrote: > > >> Hi Felipe, > > >> > > >> On Thu, Nov 20, 2014 at 01:50:49PM -0

Re: [RESEND PATCH] usb: gadget: at91_udc: move prepare clk into process context

2014-12-19 Thread Luis Henriques
On Fri, Dec 19, 2014 at 03:08:15PM +0100, Nicolas Ferre wrote: > Le 19/12/2014 15:02, Ronald Wahl a écrit : > > On 19.12.2014 14:51, Luis Henriques wrote: > >> Hi Felipe, > >> > >> On Thu, Nov 20, 2014 at 01:50:49PM -0600, Felipe Balbi wrote: > >>> On Wed, Nov 19, 2014 at 04:37:27PM +0100, Nicolas

Re: [RESEND PATCH] usb: gadget: at91_udc: move prepare clk into process context

2014-12-19 Thread Ronald Wahl
On 19.12.2014 14:51, Luis Henriques wrote: Hi Felipe, On Thu, Nov 20, 2014 at 01:50:49PM -0600, Felipe Balbi wrote: On Wed, Nov 19, 2014 at 04:37:27PM +0100, Nicolas Ferre wrote: From: Ronald Wahl Commit 7628083227b6bc4a7e33d7c381d7a4e558424b6b (usb: gadget: at91_udc: prepare clk before call

Re: [RESEND PATCH] usb: gadget: at91_udc: move prepare clk into process context

2014-12-19 Thread Nicolas Ferre
Le 19/12/2014 15:02, Ronald Wahl a écrit : > On 19.12.2014 14:51, Luis Henriques wrote: >> Hi Felipe, >> >> On Thu, Nov 20, 2014 at 01:50:49PM -0600, Felipe Balbi wrote: >>> On Wed, Nov 19, 2014 at 04:37:27PM +0100, Nicolas Ferre wrote: From: Ronald Wahl Commit 7628083227b6bc4a7e33d

Re: [RESEND PATCH] usb: gadget: at91_udc: move prepare clk into process context

2014-12-19 Thread Luis Henriques
Hi Felipe, On Thu, Nov 20, 2014 at 01:50:49PM -0600, Felipe Balbi wrote: > On Wed, Nov 19, 2014 at 04:37:27PM +0100, Nicolas Ferre wrote: > > From: Ronald Wahl > > > > Commit 7628083227b6bc4a7e33d7c381d7a4e558424b6b (usb: gadget: at91_udc: > > prepare clk before calling enable) added clock prepa

Re: [RESEND PATCH] usb: gadget: at91_udc: move prepare clk into process context

2014-11-20 Thread Felipe Balbi
On Wed, Nov 19, 2014 at 04:37:27PM +0100, Nicolas Ferre wrote: > From: Ronald Wahl > > Commit 7628083227b6bc4a7e33d7c381d7a4e558424b6b (usb: gadget: at91_udc: > prepare clk before calling enable) added clock preparation in interrupt > context. This is not allowed as it might sleep. Also setting t

[RESEND PATCH] usb: gadget: at91_udc: move prepare clk into process context

2014-11-19 Thread Nicolas Ferre
From: Ronald Wahl Commit 7628083227b6bc4a7e33d7c381d7a4e558424b6b (usb: gadget: at91_udc: prepare clk before calling enable) added clock preparation in interrupt context. This is not allowed as it might sleep. Also setting the clock rate is unsafe to call from there for the same reason. Move cloc