Re: [REGRESSION 3.17] scsi (uas) disks no longer using tagged command queuing

2014-09-12 Thread Hans de Goede
Hi, On 09/11/2014 06:13 PM, Christoph Hellwig wrote: > On Thu, Sep 11, 2014 at 12:01:13PM +0200, Hans de Goede wrote: >>> So we're initializing the tag map, but scsi_activate_tcq doesn't pick it >>> up. I can't really come up with a good explanation for it, but there >>> even without that there i

Re: [REGRESSION 3.17] scsi (uas) disks no longer using tagged command queuing

2014-09-11 Thread Christoph Hellwig
On Thu, Sep 11, 2014 at 12:01:13PM +0200, Hans de Goede wrote: > > So we're initializing the tag map, but scsi_activate_tcq doesn't pick it > > up. I can't really come up with a good explanation for it, but there > > even without that there is an elephant in the room: as part of the > > scsi-mq s

Re: [REGRESSION 3.17] scsi (uas) disks no longer using tagged command queuing

2014-09-11 Thread Hans de Goede
Hi, On 09/10/2014 05:45 PM, Christoph Hellwig wrote: > On Wed, Sep 10, 2014 at 09:21:24AM +0200, Hans de Goede wrote: >> I've applied the patch, this results in the following new dmesg output >> when using uas: >> >> [ 120.602632] initialized host-wide tag map! >> >> Thank you for looking into th

Re: [REGRESSION 3.17] scsi (uas) disks no longer using tagged command queuing

2014-09-10 Thread Christoph Hellwig
On Wed, Sep 10, 2014 at 09:21:24AM +0200, Hans de Goede wrote: > I've applied the patch, this results in the following new dmesg output > when using uas: > > [ 120.602632] initialized host-wide tag map! > > Thank you for looking into this. So we're initializing the tag map, but scsi_activate_tc

Re: [REGRESSION 3.17] scsi (uas) disks no longer using tagged command queuing

2014-09-10 Thread Hans de Goede
Hi, On 09/09/2014 05:27 PM, Christoph Hellwig wrote: > On Tue, Sep 09, 2014 at 11:15:24AM +0200, Hans de Goede wrote: >> Taking the uas.c file from 3.17, and building it for 3.16 restores >> the use of tcq (debugged by adding a printk blk_rq_tagged + request->tag). >> >> So either uas is doing som

Re: [REGRESSION 3.17] scsi (uas) disks no longer using tagged command queuing

2014-09-09 Thread Christoph Hellwig
On Tue, Sep 09, 2014 at 11:15:24AM +0200, Hans de Goede wrote: > Taking the uas.c file from 3.17, and building it for 3.16 restores > the use of tcq (debugged by adding a printk blk_rq_tagged + request->tag). > > So either uas is doing something wrong which happened to work in > 3.16, or something

[REGRESSION 3.17] scsi (uas) disks no longer using tagged command queuing

2014-09-09 Thread Hans de Goede
Hi All, While working on making error handling in the uas driver more robust, I noticed that all the commands being send to a sata ssd hooked up over uas were untagged, where I would expect tcq to be used, as that is the big advantage of uas over usb-storage / bot. Taking the uas.c file from 3.17