Re: [PATCHv2] usb: musb: Fix unbalanced platform_disable

2016-09-30 Thread Tony Lindgren
* Laurent Pinchart [160929 02:38]: > Hi Tony, > > On Wednesday 28 Sep 2016 11:42:35 Tony Lindgren wrote: > > * Tony Lindgren [160920 11:37]: > > > * Tony Lindgren [160920 10:11]: > > >> * Laurent Pinchart [160919 23:36]: > > >>> No, I perform the following steps: > > >>> > > >>> - Connect the

Re: [PATCHv2] usb: musb: Fix unbalanced platform_disable

2016-09-29 Thread Laurent Pinchart
Hi Tony, On Wednesday 28 Sep 2016 11:42:35 Tony Lindgren wrote: > * Tony Lindgren [160920 11:37]: > > * Tony Lindgren [160920 10:11]: > >> * Laurent Pinchart [160919 23:36]: > >>> No, I perform the following steps: > >>> > >>> - Connect the panda board to the USB through USB (which powers the

Re: [PATCHv2] usb: musb: Fix unbalanced platform_disable

2016-09-28 Thread Tony Lindgren
* Tony Lindgren [160920 11:37]: > * Tony Lindgren [160920 10:11]: > > * Laurent Pinchart [160919 23:36]: > > > No, I perform the following steps: > > > > > > - Connect the panda board to the USB through USB (which powers the board > > > on) > > > - Let the board boot over NFS > > > - Log in as

Re: [PATCHv2] usb: musb: Fix unbalanced platform_disable

2016-09-20 Thread Tony Lindgren
* Tony Lindgren [160920 10:11]: > * Laurent Pinchart [160919 23:36]: > > No, I perform the following steps: > > > > - Connect the panda board to the USB through USB (which powers the board on) > > - Let the board boot over NFS > > - Log in as root, run 'reboot' > > > > The second boot produces

Re: [PATCHv2] usb: musb: Fix unbalanced platform_disable

2016-09-20 Thread Tony Lindgren
* Laurent Pinchart [160919 23:36]: > Hi Tony, > > On Monday 19 Sep 2016 15:41:50 Tony Lindgren wrote: > > * Laurent Pinchart [160919 13:35]: > > > On Sunday 18 Sep 2016 08:19:02 Tony Lindgren wrote: > > >>> [5.711303] [] (_raw_spin_unlock_irqrestore) from > > >>> [] > > >>> (musb_gadget_queu

Re: [PATCHv2] usb: musb: Fix unbalanced platform_disable

2016-09-20 Thread Tony Lindgren
* Andreas Kemnade [160919 22:05]: > On Mon, 19 Sep 2016 09:02:50 -0700 > Tony Lindgren wrote: > > > * Andreas Kemnade [160918 23:00]: > > > On Sun, 18 Sep 2016 08:19:02 -0700 > > > Tony Lindgren wrote: > > > > > > > * Laurent Pinchart [160918 > > > > 05:13]: > > > > > > > > > > FYI, while t

Re: [PATCHv2] usb: musb: Fix unbalanced platform_disable

2016-09-19 Thread Laurent Pinchart
Hi Tony, On Monday 19 Sep 2016 15:41:50 Tony Lindgren wrote: > * Laurent Pinchart [160919 13:35]: > > On Sunday 18 Sep 2016 08:19:02 Tony Lindgren wrote: > >>> [5.711303] [] (_raw_spin_unlock_irqrestore) from > >>> [] > >>> (musb_gadget_queue+0x128/0x4ac) > >>> [5.711303] [] (musb_gadget_

Re: [PATCHv2] usb: musb: Fix unbalanced platform_disable

2016-09-19 Thread Andreas Kemnade
On Mon, 19 Sep 2016 09:02:50 -0700 Tony Lindgren wrote: > * Andreas Kemnade [160918 23:00]: > > On Sun, 18 Sep 2016 08:19:02 -0700 > > Tony Lindgren wrote: > > > > > * Laurent Pinchart [160918 > > > 05:13]: > > > > > > > > FYI, while this patch allows me to boot my Panda board with NFS > > >

Re: [PATCHv2] usb: musb: Fix unbalanced platform_disable

2016-09-19 Thread Tony Lindgren
* Laurent Pinchart [160919 13:35]: > On Sunday 18 Sep 2016 08:19:02 Tony Lindgren wrote: > > > [5.711303] [] (_raw_spin_unlock_irqrestore) from > > > [] > > > (musb_gadget_queue+0x128/0x4ac) > > > [5.711303] [] (musb_gadget_queue) from [] > > > (usb_ep_queue+0x38/0x1d4) > > > [5.729766

Re: [PATCHv2] usb: musb: Fix unbalanced platform_disable

2016-09-19 Thread Laurent Pinchart
Hi Tony, On Sunday 18 Sep 2016 08:19:02 Tony Lindgren wrote: > * Laurent Pinchart [160918 05:13]: > > FYI, while this patch allows me to boot my Panda board with NFS over > > usbnet, it only works with cold boots. A warm reboot results in the > > following warning, and no ethernet traffic going t

Re: [PATCHv2] usb: musb: Fix unbalanced platform_disable

2016-09-19 Thread Tony Lindgren
* Andreas Kemnade [160918 23:00]: > On Sun, 18 Sep 2016 08:19:02 -0700 > Tony Lindgren wrote: > > > * Laurent Pinchart [160918 05:13]: > > > > > > FYI, while this patch allows me to boot my Panda board with NFS > > > over usbnet, it only works with cold boots. A warm reboot results > > > in th

Re: [PATCHv2] usb: musb: Fix unbalanced platform_disable

2016-09-18 Thread Andreas Kemnade
On Sun, 18 Sep 2016 08:19:02 -0700 Tony Lindgren wrote: > * Laurent Pinchart [160918 05:13]: > > > > FYI, while this patch allows me to boot my Panda board with NFS > > over usbnet, it only works with cold boots. A warm reboot results > > in the following warning, and no ethernet traffic going

Re: [PATCHv2] usb: musb: Fix unbalanced platform_disable

2016-09-18 Thread Tony Lindgren
* Laurent Pinchart [160918 05:13]: > > FYI, while this patch allows me to boot my Panda board with NFS over usbnet, > it only works with cold boots. A warm reboot results in the following > warning, > and no ethernet traffic going through. The USB device is detected by the host > though. Yea

Re: [PATCHv2] usb: musb: Fix unbalanced platform_disable

2016-09-18 Thread Laurent Pinchart
Hi Tony, On Monday 12 Sep 2016 08:39:49 Tony Lindgren wrote: > Commit a83e17d0f73b ("usb: musb: Improve PM runtime and phy handling > for 2430 glue layer") moved PHY enable/disable calls to happen from > omap2430_musb_enable/disable(). That broke enumeration for several > devices as PM runtime in

Re: [PATCHv2] usb: musb: Fix unbalanced platform_disable

2016-09-13 Thread Laurent Pinchart
Hi Bin, On Tuesday 13 Sep 2016 09:14:48 Bin Liu wrote: > On Mon, Sep 12, 2016 at 08:18:05PM -0700, Tony Lindgren wrote: > > * Bin Liu [160912 11:36]: > > > On Mon, Sep 12, 2016 at 08:05:30PM +0200, Andreas Kemnade wrote: > > > > Hmm, then the question is: Couldn't the X_musb_disable simply be > >

Re: [PATCHv2] usb: musb: Fix unbalanced platform_disable

2016-09-13 Thread Tony Lindgren
* Bin Liu [160913 07:40]: > On Tue, Sep 13, 2016 at 05:32:23PM +0300, Laurent Pinchart wrote: > > Hi Bin, > > > > On Tuesday 13 Sep 2016 09:14:48 Bin Liu wrote: > > > On Mon, Sep 12, 2016 at 08:18:05PM -0700, Tony Lindgren wrote: > > > > * Bin Liu [160912 11:36]: > > > > > On Mon, Sep 12, 2016 a

Re: [PATCHv2] usb: musb: Fix unbalanced platform_disable

2016-09-13 Thread Bin Liu
On Tue, Sep 13, 2016 at 05:32:23PM +0300, Laurent Pinchart wrote: > Hi Bin, > > On Tuesday 13 Sep 2016 09:14:48 Bin Liu wrote: > > On Mon, Sep 12, 2016 at 08:18:05PM -0700, Tony Lindgren wrote: > > > * Bin Liu [160912 11:36]: > > > > On Mon, Sep 12, 2016 at 08:05:30PM +0200, Andreas Kemnade wrote

Re: [PATCHv2] usb: musb: Fix unbalanced platform_disable

2016-09-13 Thread Bin Liu
Hi, On Mon, Sep 12, 2016 at 08:18:05PM -0700, Tony Lindgren wrote: > * Bin Liu [160912 11:36]: > > On Mon, Sep 12, 2016 at 08:05:30PM +0200, Andreas Kemnade wrote: > > > Hmm, then the question is: Couldn't the X_musb_disable simply be called > > > from X_probe if needed to be an the safe side? >

Re: [PATCHv2] usb: musb: Fix unbalanced platform_disable

2016-09-12 Thread Tony Lindgren
* Bin Liu [160912 11:36]: > On Mon, Sep 12, 2016 at 08:05:30PM +0200, Andreas Kemnade wrote: > > Hmm, then the question is: Couldn't the X_musb_disable simply be called > > from X_probe if needed to be an the safe side? > > In general, we try not to do so if all possible. We want to put common >

Re: [PATCHv2] usb: musb: Fix unbalanced platform_disable

2016-09-12 Thread Bin Liu
On Mon, Sep 12, 2016 at 08:05:30PM +0200, Andreas Kemnade wrote: > On Mon, 12 Sep 2016 10:34:08 -0700 > Tony Lindgren wrote: > > > * Tony Lindgren [160912 10:26]: > > > * Bin Liu [160912 09:55]: > > > > Hi Tony, > > > > > > > > On Mon, Sep 12, 2016 at 08:39:49AM -0700, Tony Lindgren wrote: > >

Re: [PATCHv2] usb: musb: Fix unbalanced platform_disable

2016-09-12 Thread Tony Lindgren
* Tony Lindgren [160912 11:13]: > * Andreas Kemnade [160912 11:05]: > > On Mon, 12 Sep 2016 10:34:08 -0700 > > Tony Lindgren wrote: > > > > > > Oh I see davinci_musb_disable and am35x_musb_disable reset devctl and > > > clear interrupts. I'll try to check on am3517 here today, don't have > > >

Re: [PATCHv2] usb: musb: Fix unbalanced platform_disable

2016-09-12 Thread Tony Lindgren
* Andreas Kemnade [160912 11:05]: > On Mon, 12 Sep 2016 10:34:08 -0700 > Tony Lindgren wrote: > > > * Tony Lindgren [160912 10:26]: > > > * Bin Liu [160912 09:55]: > > > > Hi Tony, > > > > > > > > On Mon, Sep 12, 2016 at 08:39:49AM -0700, Tony Lindgren wrote: > > > > > Commit a83e17d0f73b ("u

Re: [PATCHv2] usb: musb: Fix unbalanced platform_disable

2016-09-12 Thread Andreas Kemnade
On Mon, 12 Sep 2016 10:34:08 -0700 Tony Lindgren wrote: > * Tony Lindgren [160912 10:26]: > > * Bin Liu [160912 09:55]: > > > Hi Tony, > > > > > > On Mon, Sep 12, 2016 at 08:39:49AM -0700, Tony Lindgren wrote: > > > > Commit a83e17d0f73b ("usb: musb: Improve PM runtime and phy > > > > handling

Re: [PATCHv2] usb: musb: Fix unbalanced platform_disable

2016-09-12 Thread Tony Lindgren
* Tony Lindgren [160912 10:26]: > * Bin Liu [160912 09:55]: > > Hi Tony, > > > > On Mon, Sep 12, 2016 at 08:39:49AM -0700, Tony Lindgren wrote: > > > Commit a83e17d0f73b ("usb: musb: Improve PM runtime and phy handling > > > for 2430 glue layer") moved PHY enable/disable calls to happen from > >

Re: [PATCHv2] usb: musb: Fix unbalanced platform_disable

2016-09-12 Thread Bin Liu
On Mon, Sep 12, 2016 at 10:19:40AM -0700, Tony Lindgren wrote: > * Bin Liu [160912 09:55]: > > Hi Tony, > > > > On Mon, Sep 12, 2016 at 08:39:49AM -0700, Tony Lindgren wrote: > > > Commit a83e17d0f73b ("usb: musb: Improve PM runtime and phy handling > > > for 2430 glue layer") moved PHY enable/di

Re: [PATCHv2] usb: musb: Fix unbalanced platform_disable

2016-09-12 Thread Bin Liu
On Mon, Sep 12, 2016 at 12:32:42PM -0500, Bin Liu wrote: > On Mon, Sep 12, 2016 at 10:19:40AM -0700, Tony Lindgren wrote: > > * Bin Liu [160912 09:55]: > > > Hi Tony, > > > > > > On Mon, Sep 12, 2016 at 08:39:49AM -0700, Tony Lindgren wrote: > > > > Commit a83e17d0f73b ("usb: musb: Improve PM run

Re: [PATCHv2] usb: musb: Fix unbalanced platform_disable

2016-09-12 Thread Tony Lindgren
* Bin Liu [160912 09:55]: > Hi Tony, > > On Mon, Sep 12, 2016 at 08:39:49AM -0700, Tony Lindgren wrote: > > Commit a83e17d0f73b ("usb: musb: Improve PM runtime and phy handling > > for 2430 glue layer") moved PHY enable/disable calls to happen from > > omap2430_musb_enable/disable(). That broke e

Re: [PATCHv2] usb: musb: Fix unbalanced platform_disable

2016-09-12 Thread Bin Liu
Hi Tony, On Mon, Sep 12, 2016 at 08:39:49AM -0700, Tony Lindgren wrote: > Commit a83e17d0f73b ("usb: musb: Improve PM runtime and phy handling > for 2430 glue layer") moved PHY enable/disable calls to happen from > omap2430_musb_enable/disable(). That broke enumeration for several > devices as PM

[PATCHv2] usb: musb: Fix unbalanced platform_disable

2016-09-12 Thread Tony Lindgren
Commit a83e17d0f73b ("usb: musb: Improve PM runtime and phy handling for 2430 glue layer") moved PHY enable/disable calls to happen from omap2430_musb_enable/disable(). That broke enumeration for several devices as PM runtime in the PHY will never enable it. The root cause of the problem is unpair