Re: [PATCHv2] Input: xpad - Fix double URB submission races

2015-08-26 Thread Dmitry Torokhov
On Mon, Aug 24, 2015 at 9:22 PM, Laura Abbott wrote: > On 08/21/2015 09:50 AM, Dmitry Torokhov wrote: >> >> Hi Laura, >> >> On Mon, Aug 10, 2015 at 05:26:12PM -0700, Laura Abbott wrote: >>> >>> v2: Created a proper queue for events instead of just dropping them >> >> >> How long does it take for t

Re: [PATCHv2] Input: xpad - Fix double URB submission races

2015-08-24 Thread Laura Abbott
On 08/21/2015 09:50 AM, Dmitry Torokhov wrote: Hi Laura, On Mon, Aug 10, 2015 at 05:26:12PM -0700, Laura Abbott wrote: v2: Created a proper queue for events instead of just dropping them How long does it take for the queue to exhaust your memory if you keep bombarding the driver with requests

Re: [PATCHv2] Input: xpad - Fix double URB submission races

2015-08-21 Thread Dmitry Torokhov
Hi Laura, On Mon, Aug 10, 2015 at 05:26:12PM -0700, Laura Abbott wrote: > v2: Created a proper queue for events instead of just dropping them How long does it take for the queue to exhaust your memory if you keep bombarding the driver with requests? I do not think you need a queue. I believe the

[PATCHv2] Input: xpad - Fix double URB submission races

2015-08-10 Thread Laura Abbott
The xpad driver has several races with respect to URB submission which make it easy to end up with submission while active: [ cut here ] WARNING: CPU: 3 PID: 3563 at drivers/usb/core/urb.c:339 usb_submit_urb+0x2ad/0x5a0() URB 8804078ac240 submitted while active Modules