On 11/05/16 15:39, Felipe Balbi wrote:
>
> Hi,
>
> Roger Quadros writes:
> static irqreturn_t dwc3_omap_threaded_interrupt(int irq, void *_omap)
> {
> struct dwc3_omap *omap = _omap;
> u32 reg;
>
> spin_lock(&omap->lock);
Do we really nee
Hi,
Roger Quadros writes:
static irqreturn_t dwc3_omap_threaded_interrupt(int irq, void *_omap)
{
struct dwc3_omap *omap = _omap;
u32 reg;
spin_lock(&omap->lock);
>>>
>>> Do we really need a spin_lock for the dwc3-omap driver?
>>> Currently w
On 11/05/16 12:47, Felipe Balbi wrote:
>
> Hi,
>
> Roger Quadros writes:
>>> Roger Quadros writes:
>> @@ -497,8 +503,8 @@ static int dwc3_omap_probe(struct platform_device
>> *pdev)
>> /* check the DMA Status */
>> reg = dwc3_omap_readl(omap->base, USBOTGSS_SY
Hi,
Roger Quadros writes:
>> Roger Quadros writes:
> @@ -497,8 +503,8 @@ static int dwc3_omap_probe(struct platform_device
> *pdev)
> /* check the DMA Status */
> reg = dwc3_omap_readl(omap->base, USBOTGSS_SYSCONFIG);
>
> - ret = devm_request_irq(dev, omap->irq, d
Felipe,
On 10/05/16 13:12, Felipe Balbi wrote:
>
> Hi,
>
> Roger Quadros writes:
@@ -497,8 +503,8 @@ static int dwc3_omap_probe(struct platform_device
*pdev)
/* check the DMA Status */
reg = dwc3_omap_readl(omap->base, USBOTGSS_SYSCONFIG);
- ret = devm_re
On 10/05/16 13:12, Felipe Balbi wrote:
>
> Hi,
>
> Roger Quadros writes:
@@ -497,8 +503,8 @@ static int dwc3_omap_probe(struct platform_device
*pdev)
/* check the DMA Status */
reg = dwc3_omap_readl(omap->base, USBOTGSS_SYSCONFIG);
- ret = devm_request_irq
Hi,
Roger Quadros writes:
>>> @@ -497,8 +503,8 @@ static int dwc3_omap_probe(struct platform_device *pdev)
>>> /* check the DMA Status */
>>> reg = dwc3_omap_readl(omap->base, USBOTGSS_SYSCONFIG);
>>>
>>> - ret = devm_request_irq(dev, omap->irq, dwc3_omap_interrupt, 0,
>>> -
On 10/05/16 12:58, Felipe Balbi wrote:
>
> Hi,
>
> Roger Quadros writes:
>> We intend to share this interrupt with the OTG driver an to ensure
>> that irqflags match for the shared interrupt handlers we use
>> request_threaded_irq()
>>
>> If we don't use request_treaded_irq() then forced threade
Hi,
Roger Quadros writes:
> We intend to share this interrupt with the OTG driver an to ensure
> that irqflags match for the shared interrupt handlers we use
> request_threaded_irq()
>
> If we don't use request_treaded_irq() then forced threaded irq will
> set IRQF_ONESHOT and this won't match w
We intend to share this interrupt with the OTG driver an to ensure
that irqflags match for the shared interrupt handlers we use
request_threaded_irq()
If we don't use request_treaded_irq() then forced threaded irq will
set IRQF_ONESHOT and this won't match with the OTG IRQ handler's
IRQ flags.
NO
10 matches
Mail list logo
