Re: [PATCH v7] usb_8dev: Add support for USB2CAN interface from 8 devices

2012-12-14 Thread Marc Kleine-Budde
On 12/14/2012 07:22 PM, "Bernd Krumböck" wrote: > Hello Marc! > >> Looks good to me. Minor style issue inline. Please provide a >> documentation for the sysfs entries and place it under: >> Documentation/ABI/testing/sysfs-platform. > > Should I change the sysfs path to /sys/devices/platform/usb_8

Re: [PATCH v7] usb_8dev: Add support for USB2CAN interface from 8 devices

2012-12-14 Thread Bernd Krumböck
Hello Marc! > Looks good to me. Minor style issue inline. Please provide a > documentation for the sysfs entries and place it under: > Documentation/ABI/testing/sysfs-platform. Should I change the sysfs path to /sys/devices/platform/usb_8dev? At the moment the path is /sys/bus/usb/devices/:. reg

Re: [PATCH v7] usb_8dev: Add support for USB2CAN interface from 8 devices

2012-12-14 Thread Wolfgang Grandegger
On 12/13/2012 07:40 PM, Bernd Krumboeck wrote: > Add device driver for USB2CAN interface from "8 devices" > (http://www.8devices.com). > > changes since v6: > * changed some variable types to big endian equivalent > * small cleanups > > changes since v5: > * unlock mutex on error > > changes si

Re: [PATCH v7] usb_8dev: Add support for USB2CAN interface from 8 devices

2012-12-14 Thread Marc Kleine-Budde
On 12/13/2012 07:40 PM, Bernd Krumboeck wrote: > Add device driver for USB2CAN interface from "8 devices" > (http://www.8devices.com). > > changes since v6: > * changed some variable types to big endian equivalent > * small cleanups > > changes since v5: > * unlock mutex on error > > changes si

[PATCH v7] usb_8dev: Add support for USB2CAN interface from 8 devices

2012-12-13 Thread Bernd Krumboeck
Add device driver for USB2CAN interface from "8 devices" (http://www.8devices.com). changes since v6: * changed some variable types to big endian equivalent * small cleanups changes since v5: * unlock mutex on error changes since v4: * removed FSF address * renamed struct usb_8dev * removed unu