Re: Resend Re: [PATCH v6] usb:serial:pl2303: add GPIOs interface on PL2303

2014-08-29 Thread Johan Hovold
On Thu, Aug 28, 2014 at 07:38:10AM +0800, Wang YanQing wrote: > On Tue, Aug 12, 2014 at 04:02:59PM +0200, Johan Hovold wrote: > > On Sat, Aug 09, 2014 at 02:46:56AM +0800, Wang YanQing wrote: > > > On Fri, Aug 08, 2014 at 09:54:42AM +0200, Johan Hovold wrote: > > > > On Fri, Aug 08, 2014 at 03:10:3

Re: Resend Re: [PATCH v6] usb:serial:pl2303: add GPIOs interface on PL2303

2014-08-27 Thread Wang YanQing
On Tue, Aug 12, 2014 at 04:02:59PM +0200, Johan Hovold wrote: > On Sat, Aug 09, 2014 at 02:46:56AM +0800, Wang YanQing wrote: > > On Fri, Aug 08, 2014 at 09:54:42AM +0200, Johan Hovold wrote: > > > On Fri, Aug 08, 2014 at 03:10:34AM +0800, Wang YanQing wrote: > > > > On Tue, Aug 05, 2014 at 03:54:0

Re: Resend Re: [PATCH v6] usb:serial:pl2303: add GPIOs interface on PL2303

2014-08-12 Thread Johan Hovold
On Sat, Aug 09, 2014 at 02:46:56AM +0800, Wang YanQing wrote: > On Fri, Aug 08, 2014 at 09:54:42AM +0200, Johan Hovold wrote: > > On Fri, Aug 08, 2014 at 03:10:34AM +0800, Wang YanQing wrote: > > > On Tue, Aug 05, 2014 at 03:54:08PM +0200, Johan Hovold wrote: > > > > > > I noticed that setting dire

Re: Resend Re: [PATCH v6] usb:serial:pl2303: add GPIOs interface on PL2303

2014-08-08 Thread Wang YanQing
On Fri, Aug 08, 2014 at 09:54:42AM +0200, Johan Hovold wrote: > On Fri, Aug 08, 2014 at 03:10:34AM +0800, Wang YanQing wrote: > > On Tue, Aug 05, 2014 at 03:54:08PM +0200, Johan Hovold wrote: > > > > > I noticed that setting direction to output and setting the gpio high > > > > > has > > > > > no

Re: Resend Re: [PATCH v6] usb:serial:pl2303: add GPIOs interface on PL2303

2014-08-08 Thread Johan Hovold
On Fri, Aug 08, 2014 at 03:10:34AM +0800, Wang YanQing wrote: > On Tue, Aug 05, 2014 at 03:54:08PM +0200, Johan Hovold wrote: > > > > I noticed that setting direction to output and setting the gpio high has > > > > no effect on the read-back value (i.e. I still read back 0) for my > > > > pl2303hx

Re: Resend Re: [PATCH v6] usb:serial:pl2303: add GPIOs interface on PL2303

2014-08-07 Thread Wang YanQing
On Tue, Aug 05, 2014 at 03:54:08PM +0200, Johan Hovold wrote: > > > I noticed that setting direction to output and setting the gpio high has > > > no effect on the read-back value (i.e. I still read back 0) for my > > > pl2303hx (note that my device has no easily accessible gpios so I > > > haven't

Re: Resend Re: [PATCH v6] usb:serial:pl2303: add GPIOs interface on PL2303

2014-08-05 Thread Johan Hovold
On Tue, Aug 05, 2014 at 01:15:36AM +0800, Wang YanQing wrote: > I change my system recently, and sendmail has trouble > to send mails to kernel mail list, so I resend it > with my old system. I got all three. > Ok, before I send out next version, I still has some > vague places, see below: >

Resend Re: [PATCH v6] usb:serial:pl2303: add GPIOs interface on PL2303

2014-08-04 Thread Wang YanQing
I change my system recently, and sendmail has trouble to send mails to kernel mail list, so I resend it with my old system. Ok, before I send out next version, I still has some vague places, see below: On Mon, Aug 04, 2014 at 04:00:32PM +0200, Johan Hovold wrote: > > +config USB_SERIAL_P

Re: [PATCH v6] usb:serial:pl2303: add GPIOs interface on PL2303

2014-08-04 Thread Johan Hovold
On Wed, Jul 30, 2014 at 12:57:09AM +0800, Wang YanQing wrote: > PL2303HX has two GPIOs, this patch add interface for it. In fact, PL2303HX (rev D) has four dedicated GPIOs (and an additional four multiplexed ones). Even if we do not know how to use the other two at this time, we should not be har

Re: [PATCH v6] usb:serial:pl2303: add GPIOs interface on PL2303

2014-07-29 Thread Johan Hovold
On Wed, Jul 30, 2014 at 12:57:09AM +0800, Wang YanQing wrote: > PL2303HX has two GPIOs, this patch add interface for it. > > Signed-off-by: Wang YanQing > --- > Changes v5-v6: > 1: fix typo error in Kconfig reported by Andreas Mohr > 2: add const qulification to gpio_dir_mask and gpio_value_ma

[PATCH v6] usb:serial:pl2303: add GPIOs interface on PL2303

2014-07-29 Thread Wang YanQing
PL2303HX has two GPIOs, this patch add interface for it. Signed-off-by: Wang YanQing --- Changes v5-v6: 1: fix typo error in Kconfig reported by Andreas Mohr 2: add const qulification to gpio_dir_mask and gpio_value_mask suggested by Andreas Mohr Hi, Linus Walleij, I see you give your revie