Hi Sergei
Thank you for pointing it
> > + /* set platform specific port settings */
> > + iowrite32(0x, (reg0 + USBPCTRL0));
>
> This register contains completely board specific setting,
> hard-coding it to 0 is wrong.
> Shouldn't you have passed its value as pl
Hello.
On 11/01/2012 05:03 AM, Kuninori Morimoto wrote:
Sorry for the late feedback but I'm studying this driver just now
(in order to port it to R-Car M1A).
diff --git a/drivers/usb/phy/rcar-phy.c b/drivers/usb/phy/rcar-phy.c
new file mode 100644
index 000..792f505
--- /dev/null
+++
Hi,
On Wed, Oct 31, 2012 at 07:03:11PM -0700, Kuninori Morimoto wrote:
> + /*
> + * CAUTION
> + *
> + * Because this phy address is also mapped under OHCI/EHCI address area,
> + * this driver can't use devm_request_and_ioremap(dev, res) here
> + */
peculiar... but fai
This patch adds Renesas R-Car USB phy driver.
It supports R8A7779 chip at this point.
R-Car has some USB controllers, but has only one phy-initializer.
So, this driver is counting users.
Signed-off-by: Kuninori Morimoto
---
v5 -> v6
- used if (priv->counter++ == 0)
- used if (priv->counter--
