Re: [PATCH v5 2/9] mfd: omap-usb-host: Get clocks based on hardware revision

2014-01-20 Thread Roger Quadros
On 01/10/2014 04:26 PM, Lee Jones wrote: > On Fri, 10 Jan 2014, Arnd Bergmann wrote: > >> On Friday 10 January 2014, Lee Jones wrote: - need_logic_fck = false; + /* Set all clocks as invalid to begin with */ + omap->ehci_logic_fck = omap->init_60m_fclk = ERR_PTR(-

Re: [PATCH v5 2/9] mfd: omap-usb-host: Get clocks based on hardware revision

2014-01-10 Thread Lee Jones
On Fri, 10 Jan 2014, Arnd Bergmann wrote: > On Friday 10 January 2014, Lee Jones wrote: > > > > > > - need_logic_fck = false; > > > + /* Set all clocks as invalid to begin with */ > > > + omap->ehci_logic_fck = omap->init_60m_fclk = ERR_PTR(-EINVAL); > > > + omap->utmi_p1_gfclk =

Re: [PATCH v5 2/9] mfd: omap-usb-host: Get clocks based on hardware revision

2014-01-10 Thread Arnd Bergmann
On Friday 10 January 2014, Lee Jones wrote: > > > > - need_logic_fck = false; > > + /* Set all clocks as invalid to begin with */ > > + omap->ehci_logic_fck = omap->init_60m_fclk = ERR_PTR(-EINVAL); > > + omap->utmi_p1_gfclk = omap->utmi_p2_gfclk = ERR_PTR(-EINVAL); > > + omap

Re: [PATCH v5 2/9] mfd: omap-usb-host: Get clocks based on hardware revision

2014-01-10 Thread Lee Jones
> Not all revisions have all the clocks so get the necessary clocks > based on hardware revision. > > This should avoid un-necessary clk_get failure messages that were > observed earlier. > > Be more strict and always fail on clk_get() error. > > CC: Lee Jones > CC: Samuel Ortiz > Signed-off-b

[PATCH v5 2/9] mfd: omap-usb-host: Get clocks based on hardware revision

2014-01-09 Thread Roger Quadros
Not all revisions have all the clocks so get the necessary clocks based on hardware revision. This should avoid un-necessary clk_get failure messages that were observed earlier. Be more strict and always fail on clk_get() error. CC: Lee Jones CC: Samuel Ortiz Signed-off-by: Roger Quadros ---