Re: [PATCH v5 15/15] usb: phy-mxs: Add sync time after controller clear phcd

2013-12-09 Thread Peter Chen
On Mon, Dec 09, 2013 at 09:20:08PM +0300, Sergei Shtylyov wrote: > Hello. > > On 12/09/2013 09:31 AM, Peter Chen wrote: > > >After clear portsc.phcd, PHY needs 200us stable time for switch > >32K clock to AHB clock. > > >Signed-off-by: Peter Chen > >--- > > drivers/usb/phy/phy-mxs-usb.c | 11

Re: [PATCH v5 15/15] usb: phy-mxs: Add sync time after controller clear phcd

2013-12-09 Thread Sergei Shtylyov
Hello. On 12/09/2013 09:31 AM, Peter Chen wrote: After clear portsc.phcd, PHY needs 200us stable time for switch 32K clock to AHB clock. Signed-off-by: Peter Chen --- drivers/usb/phy/phy-mxs-usb.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/drive

Re: [PATCH v5 15/15] usb: phy-mxs: Add sync time after controller clear phcd

2013-12-09 Thread Marc Kleine-Budde
On 12/09/2013 10:19 AM, Peter Chen wrote: > On Mon, Dec 09, 2013 at 10:05:17AM +0100, Marc Kleine-Budde wrote: >> On 12/09/2013 07:31 AM, Peter Chen wrote: >>> After clear portsc.phcd, PHY needs 200us stable time for switch >>> 32K clock to AHB clock. >> >> If this is a general bugbix, please move

Re: [PATCH v5 15/15] usb: phy-mxs: Add sync time after controller clear phcd

2013-12-09 Thread Peter Chen
On Mon, Dec 09, 2013 at 10:05:17AM +0100, Marc Kleine-Budde wrote: > On 12/09/2013 07:31 AM, Peter Chen wrote: > > After clear portsc.phcd, PHY needs 200us stable time for switch > > 32K clock to AHB clock. > > If this is a general bugbix, please move it to the start of this series > and add stabl

Re: [PATCH v5 15/15] usb: phy-mxs: Add sync time after controller clear phcd

2013-12-09 Thread Marc Kleine-Budde
On 12/09/2013 07:31 AM, Peter Chen wrote: > After clear portsc.phcd, PHY needs 200us stable time for switch > 32K clock to AHB clock. If this is a general bugbix, please move it to the start of this series and add stable on Cc. I think I hit the bug on the second USB port of a custom MX28 board, t

[PATCH v5 15/15] usb: phy-mxs: Add sync time after controller clear phcd

2013-12-08 Thread Peter Chen
After clear portsc.phcd, PHY needs 200us stable time for switch 32K clock to AHB clock. Signed-off-by: Peter Chen --- drivers/usb/phy/phy-mxs-usb.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy-mxs-usb.c in