Re: [PATCH v5 04/16] usb: find internal hub tier mismatch via acpi

2014-02-28 Thread Alan Stern
On Thu, 27 Feb 2014, Dan Williams wrote: > > BTW, after some more thought, I decided the right way to avoid races in > > the peer assignments is to do some of the work under hub.c's > > device_state_lock. Add a "usb_" prefix to the name and share it with > > port.c. We already are guaranteed tha

Re: [PATCH v5 04/16] usb: find internal hub tier mismatch via acpi

2014-02-27 Thread Dan Williams
On Thu, Feb 27, 2014 at 10:48 AM, Alan Stern wrote: > On Thu, 27 Feb 2014, Dan Williams wrote: > >> > If the port's ACPI data agrees with the default matching, there's no >> > issue. But if they disagree, don't accept the default match. That way >> > you never have to correct a mistaken match. >

Re: [PATCH v5 04/16] usb: find internal hub tier mismatch via acpi

2014-02-27 Thread Alan Stern
On Thu, 27 Feb 2014, Dan Williams wrote: > > If the port's ACPI data agrees with the default matching, there's no > > issue. But if they disagree, don't accept the default match. That way > > you never have to correct a mistaken match. > > So it turns out this simplifies the patch a bit, by get

Re: [PATCH v5 04/16] usb: find internal hub tier mismatch via acpi

2014-02-27 Thread Dan Williams
On Wed, Feb 26, 2014 at 2:07 PM, Alan Stern wrote: > On Wed, 26 Feb 2014, Dan Williams wrote: > >> > I've been thinking about this. Maybe it isn't a problem, because now >> > you don't set up the peer matching until after the port has been >> > registered. All you have to do is allow the ACPI da

Re: [PATCH v5 04/16] usb: find internal hub tier mismatch via acpi

2014-02-26 Thread Alan Stern
On Wed, 26 Feb 2014, Dan Williams wrote: > > I've been thinking about this. Maybe it isn't a problem, because now > > you don't set up the peer matching until after the port has been > > registered. All you have to do is allow the ACPI data to prevent a > > default match if the location data val

Re: [PATCH v5 04/16] usb: find internal hub tier mismatch via acpi

2014-02-26 Thread Dan Williams
On Wed, Feb 26, 2014 at 1:35 PM, Alan Stern wrote: > On Fri, 21 Feb 2014, Dan Williams wrote: > >> ACPI identifies peer ports by setting their 'group_token' and >> 'group_position' _PLD data to the same value. If a platform has tier >> mismatch [1] , ACPI can override the default (USB3 defined) p

Re: [PATCH v5 04/16] usb: find internal hub tier mismatch via acpi

2014-02-26 Thread Alan Stern
On Fri, 21 Feb 2014, Dan Williams wrote: > ACPI identifies peer ports by setting their 'group_token' and > 'group_position' _PLD data to the same value. If a platform has tier > mismatch [1] , ACPI can override the default (USB3 defined) peer port > association for internal hubs. External hubs f

[PATCH v5 04/16] usb: find internal hub tier mismatch via acpi

2014-02-21 Thread Dan Williams
ACPI identifies peer ports by setting their 'group_token' and 'group_position' _PLD data to the same value. If a platform has tier mismatch [1] , ACPI can override the default (USB3 defined) peer port association for internal hubs. External hubs follow the default peer association scheme. Locati