Re: [PATCH v4 2/2] usb: gadget: Add xilinx usb2 device support

2014-09-10 Thread Arnd Bergmann
On Wednesday 10 September 2014 19:25:11 sundeep subbaraya wrote: > > that's not exactly what I asked Usually you only add COMPILE_TEST > > when you have an ARCH dependency. So something like: > > > > depends on ARCH_ARM || COMPILE_TEST > > > > would make it clear that this driver is only a

Re: [PATCH v4 2/2] usb: gadget: Add xilinx usb2 device support

2014-09-10 Thread sundeep subbaraya
Hi Felipe, On Thu, Aug 21, 2014 at 7:30 PM, Felipe Balbi wrote: > On Thu, Aug 21, 2014 at 12:19:03PM +0530, sundeep subbaraya wrote: >> Hi Daniel, >> >> On Tue, Aug 19, 2014 at 3:26 PM, Daniel Mack wrote: >> > Hi, >> > >> > On 07/22/2014 11:08 AM, Subbaraya Sundeep Bhatta wrote: >> >> This patch

Re: [PATCH v4 2/2] usb: gadget: Add xilinx usb2 device support

2014-08-21 Thread Felipe Balbi
On Thu, Aug 21, 2014 at 12:19:03PM +0530, sundeep subbaraya wrote: > Hi Daniel, > > On Tue, Aug 19, 2014 at 3:26 PM, Daniel Mack wrote: > > Hi, > > > > On 07/22/2014 11:08 AM, Subbaraya Sundeep Bhatta wrote: > >> This patch adds xilinx usb2 device driver support > > > > Add some more information

Re: [PATCH v4 2/2] usb: gadget: Add xilinx usb2 device support

2014-08-20 Thread sundeep subbaraya
Hi Daniel, On Tue, Aug 19, 2014 at 3:26 PM, Daniel Mack wrote: > Hi, > > On 07/22/2014 11:08 AM, Subbaraya Sundeep Bhatta wrote: >> This patch adds xilinx usb2 device driver support > > Add some more information here, please. Copying the text from the > Kconfig option is already a good start. > >

Re: [PATCH v4 2/2] usb: gadget: Add xilinx usb2 device support

2014-08-19 Thread Daniel Mack
On 08/19/2014 11:56 AM, Daniel Mack wrote: > On 07/22/2014 11:08 AM, Subbaraya Sundeep Bhatta wrote: >> drivers/usb/gadget/Kconfig | 14 + >> drivers/usb/gadget/Makefile |1 + >> drivers/usb/gadget/udc-xilinx.c | 2261 >> +++ >> 3 files changed,

Re: [PATCH v4 2/2] usb: gadget: Add xilinx usb2 device support

2014-08-19 Thread Daniel Mack
Hi, On 07/22/2014 11:08 AM, Subbaraya Sundeep Bhatta wrote: > This patch adds xilinx usb2 device driver support Add some more information here, please. Copying the text from the Kconfig option is already a good start. > drivers/usb/gadget/Kconfig | 14 + > drivers/usb/gadget/Makefile

Re: [PATCH v4 2/2] usb: gadget: Add xilinx usb2 device support

2014-08-18 Thread sundeep subbaraya
Hi, On Tue, Jul 22, 2014 at 3:32 PM, Varka Bhadram wrote: > On 07/22/2014 02:38 PM, Subbaraya Sundeep Bhatta wrote: >> >> +#include >> +#include >> +#include >> +#include "gadget_chips.h" >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#inc

Re: [PATCH v4 2/2] usb: gadget: Add xilinx usb2 device support

2014-07-22 Thread Varka Bhadram
On 07/22/2014 02:38 PM, Subbaraya Sundeep Bhatta wrote: +#include +#include +#include +#include "gadget_chips.h" +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + Normally we will put the includes in alphabetical because it looks