On Tue, Oct 23, 2012 at 09:56:45AM +0300, Felipe Balbi wrote:
>
> that's fine, it doesn't matter how many files you touch as long as the
> patch is a single, logical, self-contained change. Look at how many
> things you're doing in a single patch:
>
> you add new function pointers to a structure,
On Mon, Oct 22, 2012 at 11:18:58AM +0800, Peter Chen wrote:
> On Fri, Oct 19, 2012 at 07:20:01PM +0300, Felipe Balbi wrote:
> > Hi,
> >
> > On Tue, Oct 16, 2012 at 09:36:46AM +0800, Peter Chen wrote:
> > > The patch includes both API change and caller change.
> > > The main changes like below:
> >
On Fri, Oct 19, 2012 at 07:20:01PM +0300, Felipe Balbi wrote:
> Hi,
>
> On Tue, Oct 16, 2012 at 09:36:46AM +0800, Peter Chen wrote:
> > The patch includes both API change and caller change.
> > The main changes like below:
> >
> > - add notify_suspend/notify_resume callback
> >
> > This let usb
Hi,
On Tue, Oct 16, 2012 at 09:36:46AM +0800, Peter Chen wrote:
> The patch includes both API change and caller change.
> The main changes like below:
>
> - add notify_suspend/notify_resume callback
>
> This let usb phy driver has the chance to change hw settings during
> the controller suspend/
On Tue, Oct 16, 2012 at 09:36:46AM +0800, Peter Chen wrote:
Hi Felipe & Alex,
Do you have any comments for this patch?
> The patch includes both API change and caller change.
> The main changes like below:
>
> - add notify_suspend/notify_resume callback
>
> This let usb phy driver has the cha
The patch includes both API change and caller change.
The main changes like below:
- add notify_suspend/notify_resume callback
This let usb phy driver has the chance to change hw settings during
the controller suspend/resume procedure.
Besides, old parameter "port" is useless for phy notify, as
