Re: [PATCH v4 03/14] usb: find internal hub tier mismatch via acpi

2014-02-07 Thread Dan Williams
On Fri, Feb 7, 2014 at 7:15 AM, Alan Stern wrote: > On Fri, 7 Feb 2014, Dan Williams wrote: > >> >> +static int pair_port(struct device *dev, void *data) >> >> +{ >> >> + struct usb_port *peer = data; >> >> + struct usb_port *port_dev = to_usb_port(dev); >> > >> > Isn't this backward? dat

Re: [PATCH v4 03/14] usb: find internal hub tier mismatch via acpi

2014-02-07 Thread Alan Stern
On Fri, 7 Feb 2014, Dan Williams wrote: > >> +static int pair_port(struct device *dev, void *data) > >> +{ > >> + struct usb_port *peer = data; > >> + struct usb_port *port_dev = to_usb_port(dev); > > > > Isn't this backward? data is the port you want to match, and dev > > is the device (

Re: [PATCH v4 03/14] usb: find internal hub tier mismatch via acpi

2014-02-07 Thread Dan Williams
On Thu, Feb 6, 2014 at 12:46 PM, Alan Stern wrote: > On Fri, 31 Jan 2014, Dan Williams wrote: > >> ACPI identifies peer ports by setting their 'group_token' and >> 'group_position' _PLD data to the same value. If a platform has tier >> mismatch [1] , ACPI can override the default, USB3 defined, p

Re: [PATCH v4 03/14] usb: find internal hub tier mismatch via acpi

2014-02-06 Thread Alan Stern
On Fri, 31 Jan 2014, Dan Williams wrote: > ACPI identifies peer ports by setting their 'group_token' and > 'group_position' _PLD data to the same value. If a platform has tier > mismatch [1] , ACPI can override the default, USB3 defined, peer port > association for internal hubs. External hubs f

[PATCH v4 03/14] usb: find internal hub tier mismatch via acpi

2014-01-31 Thread Dan Williams
ACPI identifies peer ports by setting their 'group_token' and 'group_position' _PLD data to the same value. If a platform has tier mismatch [1] , ACPI can override the default, USB3 defined, peer port association for internal hubs. External hubs follow the default peer association scheme. Locati