On 12/04/2012 11:43 PM, Bernd Krumboeck wrote:
> Add device driver for USB2CAN interface from "8 devices"
> (http://www.8devices.com).
[...]
> +/* Send data to device */
> +static netdev_tx_t usb_8dev_start_xmit(struct sk_buff *skb,
> + struct net_device *netdev)
> +{
> +
On 12/05/2012 05:00 PM, Marc Kleine-Budde wrote:
> On 12/05/2012 04:49 PM, Oliver Hartkopp wrote:
>> On 05.12.2012 11:13, Wolfgang Grandegger wrote:
>>
+outmsg.command = USB_8DEV_OPEN;
+outmsg.opt1 = USB_8DEV_BAUD_MANUAL;
+outmsg.data[0] = (bt->prop_seg + bt->phase_seg1);
On 12/05/2012 04:49 PM, Oliver Hartkopp wrote:
> On 05.12.2012 11:13, Wolfgang Grandegger wrote:
>
>>> +outmsg.command = USB_8DEV_OPEN;
>>> +outmsg.opt1 = USB_8DEV_BAUD_MANUAL;
>>> +outmsg.data[0] = (bt->prop_seg + bt->phase_seg1);
>>
>> Minor issue. Brackets not needed.
>>
>>> +ou
On 05.12.2012 11:13, Wolfgang Grandegger wrote:
+outmsg.command = USB_8DEV_OPEN;
+outmsg.opt1 = USB_8DEV_BAUD_MANUAL;
+outmsg.data[0] = (bt->prop_seg + bt->phase_seg1);
Minor issue. Brackets not needed.
+outmsg.data[1] = bt->phase_seg2;
+outmsg.data[2] = bt->sjw;
+
That
Hi Bernd,
still a few issues with error handling.
> +/* Send open command to device */
> +static int usb_8dev_cmd_open(struct usb_8dev *dev)
> +{
> +struct can_bittiming *bt = &dev->can.bittiming;
> +struct usb_8dev_cmd_msg outmsg;
> +struct usb_8dev_cmd_msg inmsg;
> +u32 flags =
> On 12/04/2012 11:11 PM, Marc Kleine-Budde wrote:
>> On 12/04/2012 11:43 PM, Bernd Krumboeck wrote:
>
>
> btw: your clock is wrong by about 1h :)
Corrected. I like UTC system clock, but Windows doesn't.
Bernd
--
To unsubscribe from this list: send the line "unsubscribe
On 12/04/2012 11:11 PM, Marc Kleine-Budde wrote:
> On 12/04/2012 11:43 PM, Bernd Krumboeck wrote:
btw: your clock is wrong by about 1h :)
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924
On 12/04/2012 11:43 PM, Bernd Krumboeck wrote:
> Add device driver for USB2CAN interface from "8 devices"
> (http://www.8devices.com).
>
> Signed-off-by: Bernd Krumboeck
Please use git send-email.
A changelog would be nice, in the form of:
changes since v4:
- done this, deleted that
If you po
Add device driver for USB2CAN interface from "8 devices"
(http://www.8devices.com).
Signed-off-by: Bernd Krumboeck
---
drivers/net/can/usb/Kconfig|6 +
drivers/net/can/usb/Makefile |1 +
drivers/net/can/usb/usb_8dev.c | 1089
3 files chang
