Re: [PATCH v3 4/4] usb: ohci: add AMD remote wakeup quirk into ohci driver

2013-09-10 Thread Huang Rui
On Fri, Sep 06, 2013 at 11:42:09PM +0800, Greg Kroah-Hartman wrote: > On Fri, Sep 06, 2013 at 06:24:44PM +0800, Huang Rui wrote: > > static void dl_done_list (struct ohci_hcd *); > > static void finish_unlinks (struct ohci_hcd *, u16); > > +static inline int root_port_reset (struct ohci_hcd *, un

Re: [PATCH v3 4/4] usb: ohci: add AMD remote wakeup quirk into ohci driver

2013-09-10 Thread Huang Rui
On Sat, Sep 07, 2013 at 12:08:27AM +0800, Alan Stern wrote: > On Fri, 6 Sep 2013, Huang Rui wrote: > > > The following patch is required to resolve remote wake issues with > > certain devices. > > > > Issue description: > > If the remote wake is issued from the device in a specific timing > > con

Re: [PATCH v3 4/4] usb: ohci: add AMD remote wakeup quirk into ohci driver

2013-09-06 Thread Alan Stern
On Fri, 6 Sep 2013, Huang Rui wrote: > The following patch is required to resolve remote wake issues with > certain devices. > > Issue description: > If the remote wake is issued from the device in a specific timing > condition while the system is entering sleep state then it may cause > system t

Re: [PATCH v3 4/4] usb: ohci: add AMD remote wakeup quirk into ohci driver

2013-09-06 Thread Greg Kroah-Hartman
On Fri, Sep 06, 2013 at 06:24:44PM +0800, Huang Rui wrote: > static void dl_done_list (struct ohci_hcd *); > static void finish_unlinks (struct ohci_hcd *, u16); > +static inline int root_port_reset (struct ohci_hcd *, unsigned); How can a definition of a function be inline? :) Can't you just

[PATCH v3 4/4] usb: ohci: add AMD remote wakeup quirk into ohci driver

2013-09-06 Thread Huang Rui
The following patch is required to resolve remote wake issues with certain devices. Issue description: If the remote wake is issued from the device in a specific timing condition while the system is entering sleep state then it may cause system to auto wake on subsequent sleep cycle. Root cause: