Re: [PATCH v3 2/4] usb: pci-quirks: add remote wakeup quirk for AMD platforms

2013-09-10 Thread Huang Rui
On Fri, Sep 06, 2013 at 11:37:28PM +0800, Greg Kroah-Hartman wrote: > On Fri, Sep 06, 2013 at 06:24:42PM +0800, Huang Rui wrote: > > It add a remote wakeup pci quirk for some special AMD platforms. This > > quirk filters southbridge revision which is 0x39 or 0x3a. > > > > Signed-off-by: Huang Rui

Re: [PATCH v3 2/4] usb: pci-quirks: add remote wakeup quirk for AMD platforms

2013-09-10 Thread Greg Kroah-Hartman
On Tue, Sep 10, 2013 at 11:37:44PM +0800, Huang Rui wrote: > > > +EXPORT_SYMBOL_GPL(usb_amd_remote_wakeup_quirk); > > > > Nothing calls this function, so why have you added it here? > > > > The way you have broken up the patches is a bit odd. You are creating > > functions that aren't called yet

Re: [PATCH v3 2/4] usb: pci-quirks: add remote wakeup quirk for AMD platforms

2013-09-06 Thread Greg Kroah-Hartman
On Fri, Sep 06, 2013 at 06:24:42PM +0800, Huang Rui wrote: > It add a remote wakeup pci quirk for some special AMD platforms. This > quirk filters southbridge revision which is 0x39 or 0x3a. > > Signed-off-by: Huang Rui > --- > drivers/usb/host/pci-quirks.c | 14 +- > drivers/usb/hos

[PATCH v3 2/4] usb: pci-quirks: add remote wakeup quirk for AMD platforms

2013-09-06 Thread Huang Rui
It add a remote wakeup pci quirk for some special AMD platforms. This quirk filters southbridge revision which is 0x39 or 0x3a. Signed-off-by: Huang Rui --- drivers/usb/host/pci-quirks.c | 14 +- drivers/usb/host/pci-quirks.h | 1 + 2 files changed, 14 insertions(+), 1 deletion(-)