Re: [PATCH v3 2/4] extcon: usb-gpio: add support for VBUS detection

2015-04-16 Thread Chanwoo Choi
On 04/16/2015 05:01 PM, Peter Chen wrote: > On Thu, Apr 16, 2015 at 04:59:31PM +0900, Chanwoo Choi wrote: >> On 04/16/2015 04:13 PM, Ivan T. Ivanov wrote: >>> Hi, >>> >>> On Thu, 2015-04-16 at 16:00 +0900, Chanwoo Choi wrote: Hi Peter, On 04/16/2015 10:59 AM, Peter Chen wrote: >

Re: [PATCH v3 2/4] extcon: usb-gpio: add support for VBUS detection

2015-04-16 Thread Peter Chen
On Thu, Apr 16, 2015 at 04:59:31PM +0900, Chanwoo Choi wrote: > On 04/16/2015 04:13 PM, Ivan T. Ivanov wrote: > > Hi, > > > > On Thu, 2015-04-16 at 16:00 +0900, Chanwoo Choi wrote: > >> Hi Peter, > >> > >> On 04/16/2015 10:59 AM, Peter Chen wrote: > >>> > > > >>> Ok, from USB point, external id/v

Re: [PATCH v3 2/4] extcon: usb-gpio: add support for VBUS detection

2015-04-16 Thread Peter Chen
On Thu, Apr 16, 2015 at 10:13:44AM +0300, Ivan T. Ivanov wrote: > Hi, > > On Thu, 2015-04-16 at 16:00 +0900, Chanwoo Choi wrote: > > Hi Peter, > > > > On 04/16/2015 10:59 AM, Peter Chen wrote: > > > > > > > Ok, from USB point, external id/vbus value can't decide > > > which role the controller

Re: [PATCH v3 2/4] extcon: usb-gpio: add support for VBUS detection

2015-04-16 Thread Chanwoo Choi
On 04/16/2015 04:13 PM, Ivan T. Ivanov wrote: > Hi, > > On Thu, 2015-04-16 at 16:00 +0900, Chanwoo Choi wrote: >> Hi Peter, >> >> On 04/16/2015 10:59 AM, Peter Chen wrote: >>> > >>> Ok, from USB point, external id/vbus value can't decide >>> which role the controller will be, the controller drive

Re: [PATCH v3 2/4] extcon: usb-gpio: add support for VBUS detection

2015-04-16 Thread Roger Quadros
On 16/04/15 10:00, Chanwoo Choi wrote: > Hi Peter, > > On 04/16/2015 10:59 AM, Peter Chen wrote: >> On Wed, Apr 15, 2015 at 06:26:23PM +0900, Chanwoo Choi wrote: >>> Hi Roger and Peter, >>> >>> On 04/15/2015 04:50 PM, Roger Quadros wrote: On 15/04/15 06:27, Peter Chen wrote: > On Tue, Apr

Re: [PATCH v3 2/4] extcon: usb-gpio: add support for VBUS detection

2015-04-16 Thread Ivan T. Ivanov
Hi, On Thu, 2015-04-16 at 16:00 +0900, Chanwoo Choi wrote: > Hi Peter, > > On 04/16/2015 10:59 AM, Peter Chen wrote: > > > > Ok, from USB point, external id/vbus value can't decide > > which role the controller will be, the controller driver > > will decide role according to many things, eg, us

Re: [PATCH v3 2/4] extcon: usb-gpio: add support for VBUS detection

2015-04-16 Thread Chanwoo Choi
Hi Peter, On 04/16/2015 10:59 AM, Peter Chen wrote: > On Wed, Apr 15, 2015 at 06:26:23PM +0900, Chanwoo Choi wrote: >> Hi Roger and Peter, >> >> On 04/15/2015 04:50 PM, Roger Quadros wrote: >>> On 15/04/15 06:27, Peter Chen wrote: On Tue, Apr 14, 2015 at 08:29:34PM +0900, Chanwoo Choi wrote:

Re: [PATCH v3 2/4] extcon: usb-gpio: add support for VBUS detection

2015-04-15 Thread Peter Chen
On Wed, Apr 15, 2015 at 06:26:23PM +0900, Chanwoo Choi wrote: > Hi Roger and Peter, > > On 04/15/2015 04:50 PM, Roger Quadros wrote: > > On 15/04/15 06:27, Peter Chen wrote: > >> On Tue, Apr 14, 2015 at 08:29:34PM +0900, Chanwoo Choi wrote: > >>> On 04/14/2015 07:38 PM, Roger Quadros wrote: >

Re: [PATCH v3 2/4] extcon: usb-gpio: add support for VBUS detection

2015-04-15 Thread Chanwoo Choi
Hi Roger and Peter, On 04/15/2015 04:50 PM, Roger Quadros wrote: > On 15/04/15 06:27, Peter Chen wrote: >> On Tue, Apr 14, 2015 at 08:29:34PM +0900, Chanwoo Choi wrote: >>> On 04/14/2015 07:38 PM, Roger Quadros wrote: On 14/04/15 13:31, Chanwoo Choi wrote: > On 04/14/2015 07:02 PM, Roger

Re: [PATCH v3 2/4] extcon: usb-gpio: add support for VBUS detection

2015-04-15 Thread Roger Quadros
On 15/04/15 06:27, Peter Chen wrote: > On Tue, Apr 14, 2015 at 08:29:34PM +0900, Chanwoo Choi wrote: >> On 04/14/2015 07:38 PM, Roger Quadros wrote: >>> On 14/04/15 13:31, Chanwoo Choi wrote: On 04/14/2015 07:02 PM, Roger Quadros wrote: > Fixed Kishon's id. > > On 14/04/15 13:01, R

Re: [PATCH v3 2/4] extcon: usb-gpio: add support for VBUS detection

2015-04-14 Thread Peter Chen
On Tue, Apr 14, 2015 at 08:29:34PM +0900, Chanwoo Choi wrote: > On 04/14/2015 07:38 PM, Roger Quadros wrote: > > On 14/04/15 13:31, Chanwoo Choi wrote: > >> On 04/14/2015 07:02 PM, Roger Quadros wrote: > >>> Fixed Kishon's id. > >>> > >>> On 14/04/15 13:01, Roger Quadros wrote: > On 10/04/15 1

Re: [PATCH v3 2/4] extcon: usb-gpio: add support for VBUS detection

2015-04-14 Thread Chanwoo Choi
On 04/14/2015 07:38 PM, Roger Quadros wrote: > On 14/04/15 13:31, Chanwoo Choi wrote: >> On 04/14/2015 07:02 PM, Roger Quadros wrote: >>> Fixed Kishon's id. >>> >>> On 14/04/15 13:01, Roger Quadros wrote: On 10/04/15 12:18, Chanwoo Choi wrote: > On 04/10/2015 05:46 PM, Robert Baldyga wrote

Re: [PATCH v3 2/4] extcon: usb-gpio: add support for VBUS detection

2015-04-14 Thread Roger Quadros
On 14/04/15 13:31, Chanwoo Choi wrote: > On 04/14/2015 07:02 PM, Roger Quadros wrote: >> Fixed Kishon's id. >> >> On 14/04/15 13:01, Roger Quadros wrote: >>> On 10/04/15 12:18, Chanwoo Choi wrote: On 04/10/2015 05:46 PM, Robert Baldyga wrote: > On 04/10/2015 10:10 AM, Chanwoo Choi wrote: >

Re: [PATCH v3 2/4] extcon: usb-gpio: add support for VBUS detection

2015-04-14 Thread Chanwoo Choi
On 04/14/2015 07:02 PM, Roger Quadros wrote: > Fixed Kishon's id. > > On 14/04/15 13:01, Roger Quadros wrote: >> On 10/04/15 12:18, Chanwoo Choi wrote: >>> On 04/10/2015 05:46 PM, Robert Baldyga wrote: On 04/10/2015 10:10 AM, Chanwoo Choi wrote: > On 04/10/2015 04:45 PM, Robert Baldyga wr

Re: [PATCH v3 2/4] extcon: usb-gpio: add support for VBUS detection

2015-04-14 Thread Roger Quadros
Fixed Kishon's id. On 14/04/15 13:01, Roger Quadros wrote: > On 10/04/15 12:18, Chanwoo Choi wrote: >> On 04/10/2015 05:46 PM, Robert Baldyga wrote: >>> On 04/10/2015 10:10 AM, Chanwoo Choi wrote: On 04/10/2015 04:45 PM, Robert Baldyga wrote: > On 04/10/2015 09:17 AM, Chanwoo Choi wrote:

Re: [PATCH v3 2/4] extcon: usb-gpio: add support for VBUS detection

2015-04-14 Thread Roger Quadros
On 10/04/15 12:18, Chanwoo Choi wrote: > On 04/10/2015 05:46 PM, Robert Baldyga wrote: >> On 04/10/2015 10:10 AM, Chanwoo Choi wrote: >>> On 04/10/2015 04:45 PM, Robert Baldyga wrote: On 04/10/2015 09:17 AM, Chanwoo Choi wrote: > Hi Robert, > > On 04/09/2015 06:24 PM, Robert Baldyg

Re: [PATCH v3 2/4] extcon: usb-gpio: add support for VBUS detection

2015-04-09 Thread Robert Baldyga
On 04/09/2015 11:59 AM, Roger Quadros wrote: > Hi, > > On 09/04/15 12:24, Robert Baldyga wrote: >> Hi Chanwoo, >> >> On 04/09/2015 11:07 AM, Chanwoo Choi wrote: >>> Hi Robert, >>> >>> On 04/09/2015 04:57 PM, Robert Baldyga wrote: Hi Chanwoo, On 04/09/2015 04:12 AM, Chanwoo Choi wrot

Re: [PATCH v3 2/4] extcon: usb-gpio: add support for VBUS detection

2015-04-09 Thread Roger Quadros
Hi, On 09/04/15 12:24, Robert Baldyga wrote: > Hi Chanwoo, > > On 04/09/2015 11:07 AM, Chanwoo Choi wrote: >> Hi Robert, >> >> On 04/09/2015 04:57 PM, Robert Baldyga wrote: >>> Hi Chanwoo, >>> >>> On 04/09/2015 04:12 AM, Chanwoo Choi wrote: Hi Robert, >> >> [snip] >> But, I have on

Re: [PATCH v3 2/4] extcon: usb-gpio: add support for VBUS detection

2015-04-09 Thread Robert Baldyga
Hi Chanwoo, On 04/09/2015 11:07 AM, Chanwoo Choi wrote: > Hi Robert, > > On 04/09/2015 04:57 PM, Robert Baldyga wrote: >> Hi Chanwoo, >> >> On 04/09/2015 04:12 AM, Chanwoo Choi wrote: >>> Hi Robert, >>> > > [snip] > >>> But, I have one question about case[3] >>> >>> If id is low and vbus is hig

Re: [PATCH v3 2/4] extcon: usb-gpio: add support for VBUS detection

2015-04-09 Thread Chanwoo Choi
Hi Robert, On 04/09/2015 04:57 PM, Robert Baldyga wrote: > Hi Chanwoo, > > On 04/09/2015 04:12 AM, Chanwoo Choi wrote: >> Hi Robert, >> [snip] >> But, I have one question about case[3] >> >> If id is low and vbus is high, this patch will update the state of both USB >> and USB-HOST cable as at

Re: [PATCH v3 2/4] extcon: usb-gpio: add support for VBUS detection

2015-04-09 Thread Robert Baldyga
Hi Chanwoo, On 04/09/2015 04:12 AM, Chanwoo Choi wrote: > Hi Robert, > > On 04/02/2015 10:13 PM, Robert Baldyga wrote: >> This patch adds VBUS pin detection support to extcon-usb-gpio driver. >> It allows to use this driver with boards which have both VBUS and ID >> pins, or only one of them. >>

Re: [PATCH v3 2/4] extcon: usb-gpio: add support for VBUS detection

2015-04-08 Thread Chanwoo Choi
Hi Robert, On 04/02/2015 10:13 PM, Robert Baldyga wrote: > This patch adds VBUS pin detection support to extcon-usb-gpio driver. > It allows to use this driver with boards which have both VBUS and ID > pins, or only one of them. > > Following table of states presents relationship between this sig

Re: [PATCH v3 2/4] extcon: usb-gpio: add support for VBUS detection

2015-04-02 Thread Roger Quadros
On 02/04/15 16:13, Robert Baldyga wrote: > This patch adds VBUS pin detection support to extcon-usb-gpio driver. > It allows to use this driver with boards which have both VBUS and ID > pins, or only one of them. > > Following table of states presents relationship between this signals > and detect

[PATCH v3 2/4] extcon: usb-gpio: add support for VBUS detection

2015-04-02 Thread Robert Baldyga
This patch adds VBUS pin detection support to extcon-usb-gpio driver. It allows to use this driver with boards which have both VBUS and ID pins, or only one of them. Following table of states presents relationship between this signals and detected cable type: State |ID | VBU